agent/pkg/agentic
Snider ba8de0c0bb fix(agent): purge sync.Once from pkg/agentic via core.Once (§14A)
Closes Mantis #863 ([agent] Phase 2: purge sync stdlib).

Per RFC plans/code/core/go/RFC.primitives-lifecycle.md §14A (landed core/go
dev 8995a80), swaps the four sync.Once usages to core.Once and the two
sync.Once{} reset-pattern callsites to core.Once.Reset():

pkg/agentic/statestore.go:
- Drop `import "sync"`.
- stateStoreRef.once: sync.Once → core.Once
- closeStateStore reset: `s.stateOnce = sync.Once{}` → `s.stateOnce.Reset()`

pkg/agentic/workspace_stats.go:
- Drop `import "sync"`.
- workspaceStatsRef.once: sync.Once → core.Once
- closeWorkspaceStatsStore reset: `s.workspaceStatsOnce = sync.Once{}` →
  `s.workspaceStatsOnce.Reset()`

pkg/agentic/prep.go:
- Drop `import "sync"`.
- PrepSubsystem.stateOnce + .workspaceStatsOnce: sync.Once → core.Once

The Reset() pattern matches stdlib semantics (see RFC §14A "Tradeoff: Once.
Reset semantics") — caller serialises via the existing closeStateStore /
closeWorkspaceStatsStore structure that nests Reset inside the lifecycle
inverse, so no concurrent Do races are introduced.

Net: 3 files, +7/-11. Mechanical line-edit per RFC §16 migration plan.

Audit re-check post-commit:
  grep -n '"sync"\|sync\.Once\|sync\.Mutex' pkg/agentic/{statestore,workspace_stats,prep}.go
  → empty (lib local variable named `sync` in mirror.go is unrelated; not
    in scope of this ticket).

Pre-flight verification: core.Once + Reset symbols verified present on
core/go dev 8995a80. Local AX-10 build blocked by the same pre-existing
workspace forge dep break that affects all consumers (root cause: fake
v0.8.0-alpha.1 pins per task #28); CI in healthy env will validate.

Co-Authored-By: Athena <athena@lthn.ai>
Co-Authored-By: Virgil <virgil@lethean.io>
2026-04-25 00:58:49 +01:00
..
actions.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
actions_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
actions_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
alias_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
auth.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
auth_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
auth_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
auto_pr.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
auto_pr_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
auto_pr_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
brain_seed_memory.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
brain_seed_memory_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_commit.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_commit_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_flow_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_forge.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
commands_forge_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_forge_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_message.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_phase.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_phase_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_plan.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_plan_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_platform.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_platform_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_platform_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_resume_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_session.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_session_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_setup.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_setup_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_sprint.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_sprint_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_state.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_state_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_task.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_task_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
commands_workspace.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_workspace_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commands_workspace_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commit.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
commit_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
content.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
content_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
content_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
deps.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
deps_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
deps_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
dispatch.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
dispatch_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
dispatch_runtime_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
dispatch_sync.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
dispatch_sync_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
dispatch_sync_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
dispatch_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
epic.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
epic_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
epic_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
events.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
events_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
events_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
handlers.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
handlers_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
handlers_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
helpers_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
ingest.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
ingest_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
ingest_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
issue.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
issue_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
lang.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
lang_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
logic_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
message.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
message_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
mirror.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
mirror_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
mirror_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
paths.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
paths_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
paths_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
phase.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
phase_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
pid.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
pid_example_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
pid_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_compat.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_compat_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_crud_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_dependencies_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_from_issue.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_from_issue_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_logic_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_retention.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_retention_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
plan_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
platform.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
platform_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
platform_test.go test(agentic): add HTTPS cert regression tests + fleet sync audit 2026-04-23 18:40:02 +01:00
platform_tools.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
pr.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
pr_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
pr_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
prep.go fix(agent): purge sync.Once from pkg/agentic via core.Once (§14A) 2026-04-25 00:58:49 +01:00
prep_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
prep_extra_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
prep_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
process_register.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
process_register_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
process_register_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
prompt_version.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
prompt_version_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
provider_manager.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
provider_manager_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
qa.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
qa_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
queue.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
queue_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
queue_extra_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
queue_logic_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
queue_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
register.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
register_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
register_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote_client.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote_client_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote_client_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote_dispatch_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote_status.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote_status_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote_status_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
remote_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
render_plan_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
resume.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
resume_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
resume_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
review_queue.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
review_queue_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
review_queue_extra_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
review_queue_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
runner.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
runner_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
runner_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
runtime_state.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
runtime_state_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
sanitise.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
sanitise_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
sanitise_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
scan.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
scan_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
scan_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
session.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
session_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
session_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
shutdown.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
shutdown_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
shutdown_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
sprint.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
sprint_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
state.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
state_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
state_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
statestore.go fix(agent): purge sync.Once from pkg/agentic via core.Once (§14A) 2026-04-25 00:58:49 +01:00
statestore_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
status.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
status_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
status_extra_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
status_logic_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
status_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
sync.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
sync_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
sync_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
task.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
task_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
template.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
template_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
template_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
transport.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
transport_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
transport_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
verify.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
verify_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
verify_extra_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
verify_test.go feat(ax-10): bring agent to v0.8.0-alpha.1 + CLI test scaffold 2026-04-24 23:48:34 +01:00
watch.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
watch_example_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
watch_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00
workspace_stats.go fix(agent): purge sync.Once from pkg/agentic via core.Once (§14A) 2026-04-25 00:58:49 +01:00
workspace_stats_test.go revert fcb9c189e5 2026-04-23 12:32:57 +01:00