c616ff1e32
Closes the 5 PARTIAL items flagged in docs/AUDIT-openbrain-20260424.md.
- Gap A (org scoping persisted on writes): new migration adds `org`
nullable+indexed column to brain_memories; BrainMemory fillable;
RememberKnowledge action forwards org; BrainService::remember
persists it.
- Gap B (supersede/forget Elastic cleanup): BrainService::forget
dispatches DeleteFromIndex (handles both Qdrant + Elastic); supersede
path dispatches cleanup for the old memory id before replacing it.
DeleteFromIndex itself untouched — already handled both indexes.
- Gap C (brain:reindex flags): --org, --project, --stale (null OR
>14d old), --dry-run (count+stop), --elastic-only added to the
artisan command.
- Gap D (MCP schemas expose org): brain_remember, brain_recall,
brain_list now accept `org` in input schema + forward into
action/service.
- Gap E (resilience uneven): brain_list now wrapped in
withCircuitBreaker('brain', ...) matching the pattern used by
BrainRemember/Recall/Forget. BrainService gains retryableHttp()
helper — 100/300/900ms exponential backoff, retries only on 5xx +
connection errors, not on 4xx. Qdrant calls route through it;
Ollama left alone (EmbedMemory job has its own retry).
Tests (Good/Bad/Ugly per gap):
- Feature/Brain/OrgScopingTest.php
- Feature/Brain/SupersedeForgetIndexCleanupTest.php
- Feature/Brain/ReindexFlagsTest.php
- Feature/Mcp/BrainSchemaOrgTest.php
- Feature/Brain/CircuitBreakerTest.php
php -l clean on all 13 files. Pest binary not in this checkout —
CI path validates the full suite.
Closes tasks.lthn.sh/view.php?id=107
Co-authored-by: Codex <noreply@openai.com>
Co-Authored-By: Virgil <virgil@lethean.io>
97 lines
3.4 KiB
PHP
97 lines
3.4 KiB
PHP
<?php
|
|
|
|
// SPDX-License-Identifier: EUPL-1.2
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Core\Mod\Agentic\Jobs\DeleteFromIndex;
|
|
use Core\Mod\Agentic\Jobs\EmbedMemory;
|
|
use Core\Mod\Agentic\Models\BrainMemory;
|
|
use Core\Mod\Agentic\Services\BrainService;
|
|
use Illuminate\Support\Facades\Queue;
|
|
|
|
function cleanupBrainService(): BrainService
|
|
{
|
|
return new BrainService;
|
|
}
|
|
|
|
function cleanupMemory(array $attributes = []): BrainMemory
|
|
{
|
|
return BrainMemory::create(array_merge([
|
|
'workspace_id' => $attributes['workspace_id'] ?? createWorkspace()->id,
|
|
'agent_id' => 'virgil',
|
|
'type' => 'observation',
|
|
'content' => 'Brain cleanup test memory.',
|
|
'confidence' => 0.84,
|
|
'org' => 'core',
|
|
'project' => 'agent',
|
|
], $attributes));
|
|
}
|
|
|
|
test('SupersedeForgetIndexCleanup_forget_Good_dispatches_delete_from_index', function (): void {
|
|
Queue::fake();
|
|
$memory = cleanupMemory(['indexed_at' => now()]);
|
|
|
|
cleanupBrainService()->forget($memory->id);
|
|
|
|
expect(BrainMemory::find($memory->id))->toBeNull()
|
|
->and(BrainMemory::withTrashed()->find($memory->id)?->trashed())->toBeTrue();
|
|
|
|
Queue::assertPushed(DeleteFromIndex::class, fn (DeleteFromIndex $job): bool => $job->memoryId === $memory->id);
|
|
});
|
|
|
|
test('SupersedeForgetIndexCleanup_supersede_Bad_dispatches_cleanup_for_old_indexed_memory', function (): void {
|
|
Queue::fake();
|
|
$workspace = createWorkspace();
|
|
$oldMemory = cleanupMemory([
|
|
'workspace_id' => $workspace->id,
|
|
'content' => 'Old indexed memory.',
|
|
'indexed_at' => now(),
|
|
]);
|
|
|
|
$newMemory = cleanupBrainService()->remember([
|
|
'workspace_id' => $workspace->id,
|
|
'agent_id' => 'virgil',
|
|
'type' => 'observation',
|
|
'content' => 'New superseding memory.',
|
|
'confidence' => 0.93,
|
|
'org' => 'core',
|
|
'project' => 'agent',
|
|
'supersedes_id' => $oldMemory->id,
|
|
]);
|
|
|
|
expect(BrainMemory::find($oldMemory->id))->toBeNull()
|
|
->and(BrainMemory::withTrashed()->find($oldMemory->id)?->trashed())->toBeTrue()
|
|
->and($newMemory->indexed_at)->toBeNull();
|
|
|
|
Queue::assertPushed(DeleteFromIndex::class, fn (DeleteFromIndex $job): bool => $job->memoryId === $oldMemory->id);
|
|
Queue::assertPushed(EmbedMemory::class, fn (EmbedMemory $job): bool => $job->memoryId === $newMemory->id);
|
|
});
|
|
|
|
test('SupersedeForgetIndexCleanup_supersede_Ugly_skips_cleanup_for_never_indexed_memory', function (): void {
|
|
Queue::fake();
|
|
$workspace = createWorkspace();
|
|
$oldMemory = cleanupMemory([
|
|
'workspace_id' => $workspace->id,
|
|
'content' => 'Old unindexed memory.',
|
|
'indexed_at' => null,
|
|
]);
|
|
|
|
$newMemory = cleanupBrainService()->remember([
|
|
'workspace_id' => $workspace->id,
|
|
'agent_id' => 'virgil',
|
|
'type' => 'observation',
|
|
'content' => 'Superseding unindexed memory.',
|
|
'confidence' => 0.9,
|
|
'org' => 'core',
|
|
'project' => 'agent',
|
|
'supersedes_id' => $oldMemory->id,
|
|
]);
|
|
|
|
expect(BrainMemory::find($oldMemory->id))->toBeNull()
|
|
->and(BrainMemory::withTrashed()->find($oldMemory->id)?->trashed())->toBeTrue()
|
|
->and($newMemory->indexed_at)->toBeNull();
|
|
|
|
Queue::assertNotPushed(DeleteFromIndex::class, fn (DeleteFromIndex $job): bool => $job->memoryId === $oldMemory->id);
|
|
Queue::assertPushed(EmbedMemory::class, fn (EmbedMemory $job): bool => $job->memoryId === $newMemory->id);
|
|
});
|