agent/pkg/agentic/remote_dispatch_test.go
Snider 537226bd4d feat: AX v0.8.0 upgrade — Core features + quality gates
AX Quality Gates (RFC-025):
- Eliminate os/exec from all test + production code (12+ files)
- Eliminate encoding/json from all test files (15 files, 66 occurrences)
- Eliminate os from all test files except TestMain (Go runtime contract)
- Eliminate path/filepath, net/url from all files
- String concat: 39 violations replaced with core.Concat()
- Test naming AX-7: 264 test functions renamed across all 6 packages
- Example test 1:1 coverage complete

Core Features Adopted:
- Task Composition: agent.completion pipeline (QA → PR → Verify → Ingest → Poke)
- PerformAsync: completion pipeline runs with WaitGroup + progress tracking
- Config: agents.yaml loaded once, feature flags (auto-qa/pr/merge/ingest)
- Named Locks: c.Lock("drain") for queue serialisation
- Registry: workspace state with cross-package QUERY access
- QUERY: c.QUERY(WorkspaceQuery{Status: "running"}) for cross-service queries
- Action descriptions: 25+ Actions self-documenting
- Data mounts: prompts/tasks/flows/personas/workspaces via c.Data()
- Content Actions: agentic.prompt/task/flow/persona callable via IPC
- Drive endpoints: forge + brain registered with tokens
- Drive REST helpers: DriveGet/DrivePost/DriveDo for Drive-aware HTTP
- HandleIPCEvents: auto-discovered by WithService (no manual wiring)
- Entitlement: frozen-queue gate on write Actions
- CLI dispatch: workspace dispatch wired to real dispatch method
- CLI: --quiet/-q and --debug/-d global flags
- CLI: banner, version, check (with service/action/command counts), env
- main.go: minimal — 5 services + c.Run(), no os import
- cmd tests: 84.2% coverage (was 0%)

Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-26 06:38:02 +00:00

106 lines
3.6 KiB
Go

// SPDX-License-Identifier: EUPL-1.2
// Tests for remote.go — dispatchRemote, resolveHost, remoteToken.
package agentic
import (
"context"
"net/http"
"net/http/httptest"
"testing"
"time"
core "dappco.re/go/core"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
// --- dispatchRemote ---
func TestRemote_DispatchRemote_Good(t *testing.T) {
callCount := 0
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
callCount++
w.Header().Set("Mcp-Session-Id", "test-session")
w.Header().Set("Content-Type", "text/event-stream")
switch callCount {
case 1:
core.Print(w, "data: {\"result\":{}}\n")
case 2:
w.WriteHeader(200)
case 3:
result := map[string]any{
"result": map[string]any{
"content": []map[string]any{
{"text": `{"success":true,"agent":"codex","repo":"go-io","workspace_dir":"/ws/go-io","pid":12345}`},
},
},
}
core.Print(w, "data: %s\n", core.JSONMarshalString(result))
}
}))
t.Cleanup(srv.Close)
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), backoff: make(map[string]time.Time), failCount: make(map[string]int)}
_, out, err := s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{
Host: srv.Listener.Addr().String(), Repo: "go-io", Task: "Fix tests",
})
require.NoError(t, err)
assert.True(t, out.Success)
assert.Equal(t, "go-io", out.Repo)
}
func TestRemote_DispatchRemote_Bad(t *testing.T) {
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), backoff: make(map[string]time.Time), failCount: make(map[string]int)}
// Missing host
_, _, err := s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{Repo: "go-io", Task: "do"})
assert.Contains(t, err.Error(), "host is required")
// Missing repo
_, _, err = s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{Host: "charon", Task: "do"})
assert.Contains(t, err.Error(), "repo is required")
// Missing task
_, _, err = s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{Host: "charon", Repo: "go-io"})
assert.Contains(t, err.Error(), "task is required")
// Init fails (server error)
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(500) }))
t.Cleanup(srv.Close)
_, _, err = s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{
Host: srv.Listener.Addr().String(), Repo: "go-io", Task: "test",
})
assert.Contains(t, err.Error(), "MCP initialize failed")
}
func TestRemote_DispatchRemote_Ugly(t *testing.T) {
callCount := 0
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
callCount++
w.Header().Set("Mcp-Session-Id", "s")
w.Header().Set("Content-Type", "text/event-stream")
switch callCount {
case 1:
core.Print(w, "data: {\"result\":{}}\n")
case 2:
w.WriteHeader(200)
case 3:
// JSON-RPC error response
result := map[string]any{"error": map[string]any{"message": "tool not found"}}
core.Print(w, "data: %s\n", core.JSONMarshalString(result))
}
}))
t.Cleanup(srv.Close)
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), backoff: make(map[string]time.Time), failCount: make(map[string]int)}
_, out, err := s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{
Host: srv.Listener.Addr().String(), Repo: "go-io", Task: "test",
Agent: "claude:opus", Org: "core", Template: "coding", Persona: "eng",
Variables: map[string]string{"key": "val"},
})
require.NoError(t, err)
assert.False(t, out.Success)
assert.Contains(t, out.Error, "tool not found")
}