agent/pkg/agentic/prep_test.go
Snider eeaed52256 test: batch 3 — add 73 Good/Bad/Ugly tests across 9 files
Fill missing categories for:
- prep.go: 25 lifecycle/detect/env tests
- prep_extra.go: pullWikiContent/renderPlan/brainRecall/findConsumers Ugly
- pr.go: buildPRBody/commentOnIssue/createPR/listPRs/listRepoPRs GBU
- epic.go: createEpic/createIssue/resolveLabelIDs/createLabel Ugly
- scan.go: scan/listOrgRepos/listRepoIssues GBU
- events (logic_test.go): emitStartEvent/emitCompletionEvent GBU
- review_queue_extra.go: buildReviewCommand/countFindings/parseRetryAfter/store/save/load
- watch.go: findActiveWorkspaces/resolveWorkspaceDir Bad/Ugly
- paths.go: newFs/parseInt Good
- plan_crud.go: generatePlanID/planList/writePlan Bad/Ugly

AX-7 scorecard: 425/516 categories filled (82%)
Gap: 166 → 91 missing categories
Tests: 690 → 765 (+75)
Coverage: 76.0% → 76.8%

Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-25 09:19:05 +00:00

529 lines
15 KiB
Go

// SPDX-License-Identifier: EUPL-1.2
package agentic
import (
"context"
"path/filepath"
"strings"
"testing"
"time"
core "dappco.re/go/core"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestPrep_EnvOr_Good_EnvSet(t *testing.T) {
t.Setenv("TEST_ENVVAR_CUSTOM", "custom-value")
assert.Equal(t, "custom-value", envOr("TEST_ENVVAR_CUSTOM", "default"))
}
func TestPrep_EnvOr_Good_Fallback(t *testing.T) {
t.Setenv("TEST_ENVVAR_MISSING", "")
assert.Equal(t, "default-value", envOr("TEST_ENVVAR_MISSING", "default-value"))
}
func TestPrep_EnvOr_Good_UnsetUsesFallback(t *testing.T) {
t.Setenv("TEST_ENVVAR_TOTALLY_MISSING", "")
assert.Equal(t, "fallback", envOr("TEST_ENVVAR_TOTALLY_MISSING", "fallback"))
}
func TestPrep_DetectLanguage_Good_Go(t *testing.T) {
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, "go.mod"), "module test").OK)
assert.Equal(t, "go", detectLanguage(dir))
}
func TestPrep_DetectLanguage_Good_PHP(t *testing.T) {
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, "composer.json"), "{}").OK)
assert.Equal(t, "php", detectLanguage(dir))
}
func TestPrep_DetectLanguage_Good_TypeScript(t *testing.T) {
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, "package.json"), "{}").OK)
assert.Equal(t, "ts", detectLanguage(dir))
}
func TestPrep_DetectLanguage_Good_Rust(t *testing.T) {
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, "Cargo.toml"), "[package]").OK)
assert.Equal(t, "rust", detectLanguage(dir))
}
func TestPrep_DetectLanguage_Good_Python(t *testing.T) {
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, "requirements.txt"), "flask").OK)
assert.Equal(t, "py", detectLanguage(dir))
}
func TestPrep_DetectLanguage_Good_Cpp(t *testing.T) {
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, "CMakeLists.txt"), "cmake_minimum_required").OK)
assert.Equal(t, "cpp", detectLanguage(dir))
}
func TestPrep_DetectLanguage_Good_Docker(t *testing.T) {
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, "Dockerfile"), "FROM alpine").OK)
assert.Equal(t, "docker", detectLanguage(dir))
}
func TestPrep_DetectLanguage_Good_DefaultsToGo(t *testing.T) {
dir := t.TempDir()
assert.Equal(t, "go", detectLanguage(dir))
}
func TestPrep_DetectBuildCmd_Good(t *testing.T) {
tests := []struct {
file string
content string
expected string
}{
{"go.mod", "module test", "go build ./..."},
{"composer.json", "{}", "composer install"},
{"package.json", "{}", "npm run build"},
{"requirements.txt", "flask", "pip install -e ."},
{"Cargo.toml", "[package]", "cargo build"},
{"CMakeLists.txt", "cmake", "cmake --build ."},
}
for _, tt := range tests {
t.Run(tt.file, func(t *testing.T) {
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, tt.file), tt.content).OK)
assert.Equal(t, tt.expected, detectBuildCmd(dir))
})
}
}
func TestPrep_DetectBuildCmd_Good_DefaultsToGo(t *testing.T) {
dir := t.TempDir()
assert.Equal(t, "go build ./...", detectBuildCmd(dir))
}
func TestPrep_DetectTestCmd_Good(t *testing.T) {
tests := []struct {
file string
content string
expected string
}{
{"go.mod", "module test", "go test ./..."},
{"composer.json", "{}", "composer test"},
{"package.json", "{}", "npm test"},
{"requirements.txt", "flask", "pytest"},
{"Cargo.toml", "[package]", "cargo test"},
{"CMakeLists.txt", "cmake", "ctest"},
}
for _, tt := range tests {
t.Run(tt.file, func(t *testing.T) {
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, tt.file), tt.content).OK)
assert.Equal(t, tt.expected, detectTestCmd(dir))
})
}
}
func TestPrep_DetectTestCmd_Good_DefaultsToGo(t *testing.T) {
dir := t.TempDir()
assert.Equal(t, "go test ./...", detectTestCmd(dir))
}
func TestSanitise_SanitiseBranchSlug_Good(t *testing.T) {
assert.Equal(t, "fix-login-bug", sanitiseBranchSlug("Fix login bug!", 40))
assert.Equal(t, "trim-me", sanitiseBranchSlug("---Trim Me---", 40))
}
func TestSanitise_SanitiseBranchSlug_Good_Truncates(t *testing.T) {
assert.Equal(t, "feature", sanitiseBranchSlug("feature--extra", 7))
}
func TestSanitise_SanitiseFilename_Good(t *testing.T) {
assert.Equal(t, "Core---Agent-Notes", sanitiseFilename("Core / Agent:Notes"))
}
func TestPrep_NewPrep_Good_Defaults(t *testing.T) {
t.Setenv("FORGE_TOKEN", "")
t.Setenv("GITEA_TOKEN", "")
t.Setenv("CORE_BRAIN_KEY", "")
t.Setenv("FORGE_URL", "")
t.Setenv("CORE_BRAIN_URL", "")
t.Setenv("SPECS_PATH", "")
t.Setenv("CODE_PATH", "")
s := NewPrep()
assert.Equal(t, "https://forge.lthn.ai", s.forgeURL)
assert.Equal(t, "https://api.lthn.sh", s.brainURL)
assert.NotNil(t, s.client)
}
func TestPrep_NewPrep_Good_EnvOverrides(t *testing.T) {
t.Setenv("FORGE_URL", "https://custom-forge.example.com")
t.Setenv("FORGE_TOKEN", "test-token")
t.Setenv("CORE_BRAIN_URL", "https://custom-brain.example.com")
t.Setenv("CORE_BRAIN_KEY", "brain-key-123")
t.Setenv("SPECS_PATH", "/custom/specs")
t.Setenv("CODE_PATH", "/custom/code")
s := NewPrep()
assert.Equal(t, "https://custom-forge.example.com", s.forgeURL)
assert.Equal(t, "test-token", s.forgeToken)
assert.Equal(t, "https://custom-brain.example.com", s.brainURL)
assert.Equal(t, "brain-key-123", s.brainKey)
assert.Equal(t, "/custom/code", s.codePath)
}
func TestPrep_NewPrep_Good_GiteaTokenFallback(t *testing.T) {
t.Setenv("FORGE_TOKEN", "")
t.Setenv("GITEA_TOKEN", "gitea-fallback-token")
s := NewPrep()
assert.Equal(t, "gitea-fallback-token", s.forgeToken)
}
func TestPrepSubsystem_Good_Name(t *testing.T) {
s := &PrepSubsystem{}
assert.Equal(t, "agentic", s.Name())
}
func TestPrep_SetCore_Good(t *testing.T) {
s := &PrepSubsystem{}
assert.Nil(t, s.core)
c := core.New(core.WithOption("name", "test"))
s.SetCore(c)
assert.NotNil(t, s.core)
}
// --- sanitiseBranchSlug Bad/Ugly ---
func TestSanitise_SanitiseBranchSlug_Bad_EmptyString(t *testing.T) {
assert.Equal(t, "", sanitiseBranchSlug("", 40))
}
func TestSanitise_SanitiseBranchSlug_Bad_OnlySpecialChars(t *testing.T) {
assert.Equal(t, "", sanitiseBranchSlug("!@#$%^&*()", 40))
}
func TestSanitise_SanitiseBranchSlug_Bad_OnlyDashes(t *testing.T) {
assert.Equal(t, "", sanitiseBranchSlug("------", 40))
}
func TestSanitise_SanitiseBranchSlug_Ugly_VeryLongString(t *testing.T) {
long := strings.Repeat("abcdefghij", 100)
result := sanitiseBranchSlug(long, 50)
assert.LessOrEqual(t, len(result), 50)
}
func TestSanitise_SanitiseBranchSlug_Ugly_Unicode(t *testing.T) {
// Unicode chars should be replaced with dashes, then edges trimmed
result := sanitiseBranchSlug("\u00e9\u00e0\u00fc\u00f1\u00f0", 40)
assert.NotContains(t, result, "\u00e9")
// All replaced with dashes, then trimmed = empty
assert.Equal(t, "", result)
}
func TestSanitise_SanitiseBranchSlug_Ugly_ZeroMax(t *testing.T) {
// max=0 means no limit
result := sanitiseBranchSlug("hello-world", 0)
assert.Equal(t, "hello-world", result)
}
// --- sanitisePlanSlug Bad/Ugly ---
func TestSanitise_SanitisePlanSlug_Bad_EmptyString(t *testing.T) {
assert.Equal(t, "", sanitisePlanSlug(""))
}
func TestSanitise_SanitisePlanSlug_Bad_OnlySpecialChars(t *testing.T) {
assert.Equal(t, "", sanitisePlanSlug("!@#$%^&*()"))
}
func TestSanitise_SanitisePlanSlug_Bad_OnlySpaces(t *testing.T) {
// Spaces become dashes, then collapsed, then trimmed
assert.Equal(t, "", sanitisePlanSlug(" "))
}
func TestSanitise_SanitisePlanSlug_Ugly_VeryLongString(t *testing.T) {
long := strings.Repeat("abcdefghij ", 20)
result := sanitisePlanSlug(long)
assert.LessOrEqual(t, len(result), 30)
}
func TestSanitise_SanitisePlanSlug_Ugly_Unicode(t *testing.T) {
result := sanitisePlanSlug("\u00e9\u00e0\u00fc\u00f1\u00f0")
assert.Equal(t, "", result, "unicode chars should be stripped, leaving empty string")
}
func TestSanitise_SanitisePlanSlug_Ugly_AllDashInput(t *testing.T) {
assert.Equal(t, "", sanitisePlanSlug("---"))
}
// --- sanitiseFilename Bad/Ugly ---
func TestSanitise_SanitiseFilename_Bad_EmptyString(t *testing.T) {
assert.Equal(t, "", sanitiseFilename(""))
}
func TestSanitise_SanitiseFilename_Bad_OnlySpecialChars(t *testing.T) {
result := sanitiseFilename("!@#$%^&*()")
// All replaced with dashes
assert.Equal(t, "----------", result)
}
func TestSanitise_SanitiseFilename_Ugly_VeryLongString(t *testing.T) {
long := strings.Repeat("a", 1000)
result := sanitiseFilename(long)
assert.Equal(t, 1000, len(result))
}
func TestSanitise_SanitiseFilename_Ugly_Unicode(t *testing.T) {
result := sanitiseFilename("\u00e9\u00e0\u00fc\u00f1\u00f0")
// All replaced with dashes
for _, r := range result {
assert.Equal(t, '-', r)
}
}
func TestSanitise_SanitiseFilename_Ugly_PreservesDotsUnderscores(t *testing.T) {
assert.Equal(t, "my_file.test.txt", sanitiseFilename("my_file.test.txt"))
}
// --- collapseRepeatedRune Bad/Ugly ---
func TestSanitise_CollapseRepeatedRune_Bad_EmptyString(t *testing.T) {
assert.Equal(t, "", collapseRepeatedRune("", '-'))
}
func TestSanitise_CollapseRepeatedRune_Bad_AllTarget(t *testing.T) {
assert.Equal(t, "-", collapseRepeatedRune("-----", '-'))
}
func TestSanitise_CollapseRepeatedRune_Ugly_Unicode(t *testing.T) {
assert.Equal(t, "h\u00e9llo", collapseRepeatedRune("h\u00e9\u00e9\u00e9llo", '\u00e9'))
}
func TestSanitise_CollapseRepeatedRune_Ugly_VeryLong(t *testing.T) {
long := strings.Repeat("--a", 500)
result := collapseRepeatedRune(long, '-')
assert.NotContains(t, result, "--")
}
// --- trimRuneEdges Bad/Ugly ---
func TestSanitise_TrimRuneEdges_Bad_EmptyString(t *testing.T) {
assert.Equal(t, "", trimRuneEdges("", '-'))
}
func TestSanitise_TrimRuneEdges_Bad_AllTarget(t *testing.T) {
assert.Equal(t, "", trimRuneEdges("-----", '-'))
}
func TestSanitise_TrimRuneEdges_Ugly_Unicode(t *testing.T) {
assert.Equal(t, "hello", trimRuneEdges("\u00e9hello\u00e9\u00e9", '\u00e9'))
}
func TestSanitise_TrimRuneEdges_Ugly_NoMatch(t *testing.T) {
assert.Equal(t, "hello", trimRuneEdges("hello", '-'))
}
// --- PrepSubsystem Name Bad/Ugly ---
func TestPrep_Name_Bad(t *testing.T) {
s := &PrepSubsystem{}
name := s.Name()
assert.NotEmpty(t, name, "Name should never return empty")
assert.Equal(t, "agentic", name)
}
func TestPrep_Name_Ugly(t *testing.T) {
// Zero-value struct — Name() should still work
var s PrepSubsystem
assert.NotPanics(t, func() {
name := s.Name()
assert.Equal(t, "agentic", name)
})
}
// --- NewPrep Bad/Ugly ---
func TestPrep_NewPrep_Bad(t *testing.T) {
// Call without any env — verify doesn't panic, returns valid struct
t.Setenv("FORGE_TOKEN", "")
t.Setenv("GITEA_TOKEN", "")
t.Setenv("CORE_BRAIN_KEY", "")
t.Setenv("FORGE_URL", "")
t.Setenv("CORE_BRAIN_URL", "")
t.Setenv("SPECS_PATH", "")
t.Setenv("CODE_PATH", "")
assert.NotPanics(t, func() {
s := NewPrep()
assert.NotNil(t, s)
})
}
func TestPrep_NewPrep_Ugly(t *testing.T) {
// Verify returned struct has non-nil backoff/failCount maps
t.Setenv("FORGE_TOKEN", "")
t.Setenv("GITEA_TOKEN", "")
s := NewPrep()
assert.NotNil(t, s.backoff, "backoff map must not be nil")
assert.NotNil(t, s.failCount, "failCount map must not be nil")
assert.NotNil(t, s.client, "HTTP client must not be nil")
assert.NotNil(t, s.forge, "Forge client must not be nil")
}
// --- SetCore Bad/Ugly ---
func TestPrep_SetCore_Bad(t *testing.T) {
// SetCore with nil — should not panic
s := &PrepSubsystem{}
assert.NotPanics(t, func() {
s.SetCore(nil)
})
assert.Nil(t, s.core)
}
func TestPrep_SetCore_Ugly(t *testing.T) {
// SetCore twice — second overwrites first
s := &PrepSubsystem{}
c1 := core.New(core.WithOption("name", "first"))
c2 := core.New(core.WithOption("name", "second"))
s.SetCore(c1)
assert.Equal(t, c1, s.core)
s.SetCore(c2)
assert.Equal(t, c2, s.core, "second SetCore should overwrite first")
}
// --- OnStartup Bad/Ugly ---
func TestPrep_OnStartup_Bad(t *testing.T) {
// OnStartup without SetCore (nil core) — panics because registerCommands
// needs core.Command(). Verify the panic is from nil core, not a logic error.
s := &PrepSubsystem{
backoff: make(map[string]time.Time),
failCount: make(map[string]int),
}
assert.Panics(t, func() {
_ = s.OnStartup(context.Background())
}, "OnStartup without core should panic on registerCommands")
}
func TestPrep_OnStartup_Ugly(t *testing.T) {
// OnStartup called twice with valid core — second call should not panic
s := &PrepSubsystem{
backoff: make(map[string]time.Time),
failCount: make(map[string]int),
}
c := core.New(core.WithOption("name", "test"))
s.SetCore(c)
assert.NotPanics(t, func() {
_ = s.OnStartup(context.Background())
_ = s.OnStartup(context.Background())
})
}
// --- OnShutdown Bad ---
func TestPrep_OnShutdown_Bad(t *testing.T) {
// OnShutdown without Core
s := &PrepSubsystem{
backoff: make(map[string]time.Time),
failCount: make(map[string]int),
}
assert.NotPanics(t, func() {
err := s.OnShutdown(context.Background())
assert.NoError(t, err)
})
assert.True(t, s.frozen)
}
// --- Shutdown Bad/Ugly ---
func TestPrep_Shutdown_Bad(t *testing.T) {
// Shutdown always returns nil
s := &PrepSubsystem{
backoff: make(map[string]time.Time),
failCount: make(map[string]int),
}
err := s.Shutdown(context.Background())
assert.NoError(t, err)
assert.Nil(t, err)
}
func TestPrep_Shutdown_Ugly(t *testing.T) {
// Shutdown on zero-value struct
var s PrepSubsystem
assert.NotPanics(t, func() {
err := s.Shutdown(context.Background())
assert.NoError(t, err)
})
}
// --- EnvOr Bad/Ugly ---
func TestPrep_EnvOr_Bad(t *testing.T) {
// Both env empty and fallback empty
t.Setenv("TEST_ENVVAR_EMPTY_ALL", "")
assert.Equal(t, "", envOr("TEST_ENVVAR_EMPTY_ALL", ""))
}
func TestPrep_EnvOr_Ugly(t *testing.T) {
// Env set to whitespace — whitespace is non-empty, so returned as-is
t.Setenv("TEST_ENVVAR_WHITESPACE", " ")
assert.Equal(t, " ", envOr("TEST_ENVVAR_WHITESPACE", "fallback"))
}
// --- DetectLanguage Bad/Ugly ---
func TestPrep_DetectLanguage_Bad(t *testing.T) {
// Empty dir — defaults to go
dir := t.TempDir()
assert.Equal(t, "go", detectLanguage(dir))
}
func TestPrep_DetectLanguage_Ugly(t *testing.T) {
// Dir with multiple project files (go.mod + package.json) — go wins (first match)
dir := t.TempDir()
require.True(t, fs.Write(filepath.Join(dir, "go.mod"), "module test").OK)
require.True(t, fs.Write(filepath.Join(dir, "package.json"), "{}").OK)
assert.Equal(t, "go", detectLanguage(dir), "go.mod checked first, so go wins")
}
// --- DetectBuildCmd Bad/Ugly ---
func TestPrep_DetectBuildCmd_Bad(t *testing.T) {
// Unknown/non-existent path — defaults to go build
assert.Equal(t, "go build ./...", detectBuildCmd("/nonexistent/path/that/does/not/exist"))
}
func TestPrep_DetectBuildCmd_Ugly(t *testing.T) {
// Path that doesn't exist at all — defaults to go build
assert.NotPanics(t, func() {
result := detectBuildCmd("")
assert.Equal(t, "go build ./...", result)
})
}
// --- DetectTestCmd Bad/Ugly ---
func TestPrep_DetectTestCmd_Bad(t *testing.T) {
// Unknown path — defaults to go test
assert.Equal(t, "go test ./...", detectTestCmd("/nonexistent/path/that/does/not/exist"))
}
func TestPrep_DetectTestCmd_Ugly(t *testing.T) {
// Path that doesn't exist — defaults to go test
assert.NotPanics(t, func() {
result := detectTestCmd("")
assert.Equal(t, "go test ./...", result)
})
}