f83c753277
go-process:
- Register factory, Result lifecycle, 5 named Action handlers
- Start/Run/StartWithOptions/RunWithOptions all return core.Result
- core.ID() replaces fmt.Sprintf, core.As replaces errors.As
core/agent:
- PrepSubsystem + monitor.Subsystem + setup.Service embed ServiceRuntime[T]
- 22 named Actions + agent.completion Task pipeline in OnStartup
- ChannelNotifier removed — all IPC via c.ACTION(messages.X{})
- proc.go: all methods via s.Core().Process(), returns core.Result
- status.go: WriteAtomic + JSONMarshalString
- paths.go: Fs.NewUnrestricted() replaces unsafe.Pointer
- transport.go: ONE net/http file — HTTPGet/HTTPPost/HTTPDo/MCP transport
- All disallowed imports eliminated from source files (13 quality gates)
- String concat eliminated — core.Concat() throughout
- 1:1 _test.go + _example_test.go for every source file
- Reference docs synced from core/go v0.8.0
- RFC-025 updated with net/http, net/url, io/fs quality gates
- lib.go: io/fs eliminated via Data.ListNames, Array[T].Deduplicate
Co-Authored-By: Virgil <virgil@lethean.io>
110 lines
3.7 KiB
Go
110 lines
3.7 KiB
Go
// SPDX-License-Identifier: EUPL-1.2
|
|
|
|
// Tests for remote.go — dispatchRemote, resolveHost, remoteToken.
|
|
|
|
package agentic
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
|
|
core "dappco.re/go/core"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// --- dispatchRemote ---
|
|
|
|
func TestRemote_DispatchRemote_Good(t *testing.T) {
|
|
callCount := 0
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
callCount++
|
|
w.Header().Set("Mcp-Session-Id", "test-session")
|
|
w.Header().Set("Content-Type", "text/event-stream")
|
|
switch callCount {
|
|
case 1:
|
|
fmt.Fprintf(w, "data: {\"result\":{}}\n\n")
|
|
case 2:
|
|
w.WriteHeader(200)
|
|
case 3:
|
|
result := map[string]any{
|
|
"result": map[string]any{
|
|
"content": []map[string]any{
|
|
{"text": `{"success":true,"agent":"codex","repo":"go-io","workspace_dir":"/ws/go-io","pid":12345}`},
|
|
},
|
|
},
|
|
}
|
|
data, _ := json.Marshal(result)
|
|
fmt.Fprintf(w, "data: %s\n\n", data)
|
|
}
|
|
}))
|
|
t.Cleanup(srv.Close)
|
|
|
|
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
|
_, out, err := s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{
|
|
Host: srv.Listener.Addr().String(), Repo: "go-io", Task: "Fix tests",
|
|
})
|
|
require.NoError(t, err)
|
|
assert.True(t, out.Success)
|
|
assert.Equal(t, "go-io", out.Repo)
|
|
}
|
|
|
|
func TestRemote_DispatchRemote_Bad(t *testing.T) {
|
|
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
|
|
|
// Missing host
|
|
_, _, err := s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{Repo: "go-io", Task: "do"})
|
|
assert.Contains(t, err.Error(), "host is required")
|
|
|
|
// Missing repo
|
|
_, _, err = s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{Host: "charon", Task: "do"})
|
|
assert.Contains(t, err.Error(), "repo is required")
|
|
|
|
// Missing task
|
|
_, _, err = s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{Host: "charon", Repo: "go-io"})
|
|
assert.Contains(t, err.Error(), "task is required")
|
|
|
|
// Init fails (server error)
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(500) }))
|
|
t.Cleanup(srv.Close)
|
|
_, _, err = s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{
|
|
Host: srv.Listener.Addr().String(), Repo: "go-io", Task: "test",
|
|
})
|
|
assert.Contains(t, err.Error(), "MCP initialize failed")
|
|
}
|
|
|
|
func TestRemote_DispatchRemote_Ugly(t *testing.T) {
|
|
callCount := 0
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
callCount++
|
|
w.Header().Set("Mcp-Session-Id", "s")
|
|
w.Header().Set("Content-Type", "text/event-stream")
|
|
switch callCount {
|
|
case 1:
|
|
fmt.Fprintf(w, "data: {\"result\":{}}\n\n")
|
|
case 2:
|
|
w.WriteHeader(200)
|
|
case 3:
|
|
// JSON-RPC error response
|
|
result := map[string]any{"error": map[string]any{"message": "tool not found"}}
|
|
data, _ := json.Marshal(result)
|
|
fmt.Fprintf(w, "data: %s\n\n", data)
|
|
}
|
|
}))
|
|
t.Cleanup(srv.Close)
|
|
|
|
s := &PrepSubsystem{ServiceRuntime: core.NewServiceRuntime(testCore, AgentOptions{}), backoff: make(map[string]time.Time), failCount: make(map[string]int)}
|
|
_, out, err := s.dispatchRemote(context.Background(), nil, RemoteDispatchInput{
|
|
Host: srv.Listener.Addr().String(), Repo: "go-io", Task: "test",
|
|
Agent: "claude:opus", Org: "core", Template: "coding", Persona: "eng",
|
|
Variables: map[string]string{"key": "val"},
|
|
})
|
|
require.NoError(t, err)
|
|
assert.False(t, out.Success)
|
|
assert.Contains(t, out.Error, "tool not found")
|
|
}
|