3f5f4d15fe
AgentSession::addArtifact expects ?array $metadata in the third argument slot; the MCP tool was passing the optional description string directly, producing a TypeError whenever a caller supplied a non-null description. Wrap the description into a metadata array so the call matches the model signature, and add a feature test that exercises the MCP handler end-to-end to prevent regression. Closes tasks.lthn.sh/view.php?id=95 Co-authored-by: Codex <noreply@openai.com> Co-Authored-By: Virgil <virgil@lethean.io>
37 lines
1.3 KiB
PHP
37 lines
1.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Core\Mod\Agentic\Mcp\Tools\Agent\Session\SessionArtifact;
|
|
use Core\Mod\Agentic\Models\AgentSession;
|
|
|
|
it('records artifact descriptions as metadata without throwing a type error', function () {
|
|
$workspace = createWorkspace();
|
|
$session = AgentSession::start(null, AgentSession::AGENT_OPUS, $workspace);
|
|
$tool = new SessionArtifact;
|
|
|
|
$payload = [
|
|
'session_id' => $session->session_id,
|
|
'path' => 'docs/session-artifact.md',
|
|
'action' => 'modified',
|
|
'description' => 'some narrative text',
|
|
'metadata' => null,
|
|
];
|
|
|
|
$result = null;
|
|
|
|
expect(function () use ($tool, $payload, $session, &$result): void {
|
|
$result = $tool->handle($payload, ['session_id' => $session->session_id]);
|
|
})->not->toThrow(TypeError::class);
|
|
|
|
expect($result)->toBeArray()
|
|
->and($result['success'])->toBeTrue()
|
|
->and($result['artifact'])->toBe('docs/session-artifact.md');
|
|
|
|
$artifacts = $session->fresh()->artifacts;
|
|
|
|
expect($artifacts)->toHaveCount(1)
|
|
->and($artifacts[0]['path'])->toBe('docs/session-artifact.md')
|
|
->and($artifacts[0]['action'])->toBe('modified')
|
|
->and($artifacts[0]['metadata'])->toBe(['description' => 'some narrative text']);
|
|
});
|