fix(api): fail fast on sdk generator availability

Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Virgil 2026-04-02 09:19:19 +00:00
parent c4743a527e
commit 592cdd302e
2 changed files with 46 additions and 2 deletions

View file

@ -63,6 +63,10 @@ func (g *SDKGenerator) Generate(ctx context.Context, language string) error {
return coreerr.E("SDKGenerator.Generate", "spec file not found: "+g.SpecPath, nil)
}
if !g.Available() {
return coreerr.E("SDKGenerator.Generate", "openapi-generator-cli not installed", nil)
}
outputDir := filepath.Join(g.OutputDir, language)
if err := coreio.Local.EnsureDir(outputDir); err != nil {
return coreerr.E("SDKGenerator.Generate", "create output directory", err)

View file

@ -59,7 +59,47 @@ func TestSDKGenerator_Bad_MissingSpec(t *testing.T) {
}
}
func TestSDKGenerator_Bad_MissingGenerator(t *testing.T) {
t.Setenv("PATH", t.TempDir())
specDir := t.TempDir()
specPath := filepath.Join(specDir, "spec.json")
if err := os.WriteFile(specPath, []byte(`{"openapi":"3.1.0"}`), 0o644); err != nil {
t.Fatalf("failed to write spec file: %v", err)
}
outputDir := filepath.Join(t.TempDir(), "nested", "sdk")
gen := &api.SDKGenerator{
SpecPath: specPath,
OutputDir: outputDir,
}
err := gen.Generate(context.Background(), "go")
if err == nil {
t.Fatal("expected error when openapi-generator-cli is missing, got nil")
}
if !strings.Contains(err.Error(), "openapi-generator-cli not installed") {
t.Fatalf("expected missing-generator error, got: %v", err)
}
if _, statErr := os.Stat(filepath.Join(outputDir, "go")); !os.IsNotExist(statErr) {
t.Fatalf("expected output directory not to be created when generator is missing, got err=%v", statErr)
}
}
func TestSDKGenerator_Good_OutputDirCreated(t *testing.T) {
oldPath := os.Getenv("PATH")
// Provide a fake openapi-generator-cli so Generate reaches the exec step
// without depending on the host environment.
binDir := t.TempDir()
binPath := filepath.Join(binDir, "openapi-generator-cli")
script := []byte("#!/bin/sh\nexit 1\n")
if err := os.WriteFile(binPath, script, 0o755); err != nil {
t.Fatalf("failed to write fake generator: %v", err)
}
t.Setenv("PATH", binDir+string(os.PathListSeparator)+oldPath)
// Write a minimal spec file so we pass the file-exists check.
specDir := t.TempDir()
specPath := filepath.Join(specDir, "spec.json")
@ -73,8 +113,8 @@ func TestSDKGenerator_Good_OutputDirCreated(t *testing.T) {
OutputDir: outputDir,
}
// Generate will fail at the exec step (openapi-generator-cli likely not installed),
// but the output directory should have been created before that.
// Generate will fail at the exec step, but the output directory should have
// been created before the CLI returned its non-zero status.
_ = gen.Generate(context.Background(), "go")
expected := filepath.Join(outputDir, "go")