fix(api): preserve existing link headers in sunset middleware

Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Virgil 2026-04-01 23:29:12 +00:00
parent 0984c2f48a
commit 9449c195c3
2 changed files with 43 additions and 2 deletions

View file

@ -28,15 +28,16 @@ func ApiSunset(sunsetDate, replacement string) gin.HandlerFunc {
}
return func(c *gin.Context) {
c.Next()
c.Header("Deprecation", "true")
if formatted != "" {
c.Header("Sunset", formatted)
}
if replacement != "" {
c.Header("Link", "<"+replacement+">; rel=\"successor-version\"")
c.Writer.Header().Add("Link", "<"+replacement+">; rel=\"successor-version\"")
}
c.Header("X-API-Warn", warning)
c.Next()
}
}

View file

@ -22,6 +22,17 @@ func (sunsetStubGroup) RegisterRoutes(rg *gin.RouterGroup) {
})
}
type sunsetLinkStubGroup struct{}
func (sunsetLinkStubGroup) Name() string { return "legacy-link" }
func (sunsetLinkStubGroup) BasePath() string { return "/legacy-link" }
func (sunsetLinkStubGroup) RegisterRoutes(rg *gin.RouterGroup) {
rg.GET("/status", func(c *gin.Context) {
c.Header("Link", "<https://example.com/docs>; rel=\"help\"")
c.JSON(http.StatusOK, api.OK("ok"))
})
}
func TestWithSunset_Good_AddsDeprecationHeaders(t *testing.T) {
gin.SetMode(gin.TestMode)
@ -51,3 +62,32 @@ func TestWithSunset_Good_AddsDeprecationHeaders(t *testing.T) {
t.Fatalf("expected deprecation warning, got %q", got)
}
}
func TestWithSunset_Good_PreservesExistingLinkHeaders(t *testing.T) {
gin.SetMode(gin.TestMode)
e, err := api.New(api.WithSunset("2025-06-01", "/api/v2/status"))
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
e.Register(sunsetLinkStubGroup{})
w := httptest.NewRecorder()
req, _ := http.NewRequest(http.MethodGet, "/legacy-link/status", nil)
e.Handler().ServeHTTP(w, req)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", w.Code)
}
links := w.Header().Values("Link")
if len(links) != 2 {
t.Fatalf("expected 2 Link header values, got %v", links)
}
if links[0] != "<https://example.com/docs>; rel=\"help\"" {
t.Fatalf("expected existing Link header to be preserved first, got %q", links[0])
}
if links[1] != "</api/v2/status>; rel=\"successor-version\"" {
t.Fatalf("expected successor Link header to be appended, got %q", links[1])
}
}