2026-01-29 02:48:54 +00:00
|
|
|
package signing
|
|
|
|
|
|
|
|
|
|
import (
|
2026-01-29 14:28:23 +00:00
|
|
|
"context"
|
2026-01-29 02:48:54 +00:00
|
|
|
"runtime"
|
|
|
|
|
"testing"
|
2026-01-29 14:28:23 +00:00
|
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
2026-01-29 02:48:54 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func TestMacOSSigner_Good_Name(t *testing.T) {
|
|
|
|
|
s := NewMacOSSigner(MacOSConfig{Identity: "Developer ID Application: Test"})
|
2026-01-29 14:28:23 +00:00
|
|
|
assert.Equal(t, "codesign", s.Name())
|
2026-01-29 02:48:54 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMacOSSigner_Good_Available(t *testing.T) {
|
|
|
|
|
s := NewMacOSSigner(MacOSConfig{Identity: "Developer ID Application: Test"})
|
|
|
|
|
|
|
|
|
|
if runtime.GOOS == "darwin" {
|
2026-01-29 14:28:23 +00:00
|
|
|
// Just verify it doesn't panic
|
2026-01-29 02:48:54 +00:00
|
|
|
_ = s.Available()
|
|
|
|
|
} else {
|
2026-01-29 14:28:23 +00:00
|
|
|
assert.False(t, s.Available())
|
2026-01-29 02:48:54 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMacOSSigner_Bad_NoIdentity(t *testing.T) {
|
|
|
|
|
s := NewMacOSSigner(MacOSConfig{})
|
2026-01-29 14:28:23 +00:00
|
|
|
assert.False(t, s.Available())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMacOSSigner_Sign_Bad(t *testing.T) {
|
|
|
|
|
t.Run("fails when not available", func(t *testing.T) {
|
|
|
|
|
if runtime.GOOS == "darwin" {
|
|
|
|
|
t.Skip("skipping on macOS")
|
|
|
|
|
}
|
|
|
|
|
s := NewMacOSSigner(MacOSConfig{Identity: "test"})
|
|
|
|
|
err := s.Sign(context.Background(), "test")
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "not available")
|
|
|
|
|
})
|
2026-01-29 02:48:54 +00:00
|
|
|
}
|
2026-01-29 14:28:23 +00:00
|
|
|
|
|
|
|
|
func TestMacOSSigner_Notarize_Bad(t *testing.T) {
|
|
|
|
|
t.Run("fails with missing credentials", func(t *testing.T) {
|
|
|
|
|
s := NewMacOSSigner(MacOSConfig{})
|
|
|
|
|
err := s.Notarize(context.Background(), "test")
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "missing Apple credentials")
|
|
|
|
|
})
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMacOSSigner_ShouldNotarize(t *testing.T) {
|
|
|
|
|
s := NewMacOSSigner(MacOSConfig{Notarize: true})
|
|
|
|
|
assert.True(t, s.ShouldNotarize())
|
feat: git command, build improvements, and go fmt git-aware (#74)
* feat(go): make go fmt git-aware by default
- By default, only check changed Go files (modified, staged, untracked)
- Add --all flag to check all files (previous behaviour)
- Reduces noise when running fmt on large codebases
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(build): minimal output by default, add missing i18n
- Default output now shows single line: "Success Built N artifacts (dir)"
- Add --verbose/-v flag to show full detailed output
- Add all missing i18n translations for build commands
- Errors still show failure reason in minimal mode
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: add root-level `core git` command
- Create pkg/gitcmd with git workflow commands as root menu
- Export command builders from pkg/dev (AddCommitCommand, etc.)
- Commands available under both `core git` and `core dev` for compatibility
- Git commands: health, commit, push, pull, work, sync, apply
- GitHub orchestration stays in dev: issues, reviews, ci, impact
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(qa): add docblock coverage checking
Implement docblock/docstring coverage analysis for Go code:
- New `core qa docblock` command to check coverage
- Shows compact file:line list when under threshold
- Integrate with `core go qa` as a default check
- Add --docblock-threshold flag (default 80%)
The checker uses Go AST parsing to find exported symbols
(functions, types, consts, vars) without documentation.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- Fix doc comment: "status" → "health" in gitcmd package
- Implement --check flag for `core go fmt` (exits non-zero if files need formatting)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs: add docstrings for 100% coverage
Add documentation comments to all exported symbols:
- pkg/build: ProjectType constants
- pkg/cli: LogLevel, RenderStyle, TableStyle
- pkg/framework: ServiceFor, MustServiceFor, Core.Core
- pkg/git: GitError.Error, GitError.Unwrap
- pkg/i18n: Handler Match/Handle methods
- pkg/log: Level constants
- pkg/mcp: Tool input/output types
- pkg/php: Service constants, QA types, service methods
- pkg/process: ServiceError.Error
- pkg/repos: RepoType constants
- pkg/setup: ChangeType, ChangeCategory constants
- pkg/workspace: AddWorkspaceCommands
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* chore: standardize line endings to LF
Add .gitattributes to enforce LF line endings for all text files.
Normalize all existing files to use Unix-style line endings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr
- cmd_docblock.go: return error instead of os.Exit(1) for proper error handling
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback (round 2)
- linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit
- mcp.go: guard against empty old_string in editDiff to prevent runaway edits
- cmd_docblock.go: log parse errors instead of silently skipping
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 10:48:44 +00:00
|
|
|
|
2026-01-29 14:28:23 +00:00
|
|
|
s2 := NewMacOSSigner(MacOSConfig{Notarize: false})
|
|
|
|
|
assert.False(t, s2.ShouldNotarize())
|
feat: git command, build improvements, and go fmt git-aware (#74)
* feat(go): make go fmt git-aware by default
- By default, only check changed Go files (modified, staged, untracked)
- Add --all flag to check all files (previous behaviour)
- Reduces noise when running fmt on large codebases
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(build): minimal output by default, add missing i18n
- Default output now shows single line: "Success Built N artifacts (dir)"
- Add --verbose/-v flag to show full detailed output
- Add all missing i18n translations for build commands
- Errors still show failure reason in minimal mode
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: add root-level `core git` command
- Create pkg/gitcmd with git workflow commands as root menu
- Export command builders from pkg/dev (AddCommitCommand, etc.)
- Commands available under both `core git` and `core dev` for compatibility
- Git commands: health, commit, push, pull, work, sync, apply
- GitHub orchestration stays in dev: issues, reviews, ci, impact
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(qa): add docblock coverage checking
Implement docblock/docstring coverage analysis for Go code:
- New `core qa docblock` command to check coverage
- Shows compact file:line list when under threshold
- Integrate with `core go qa` as a default check
- Add --docblock-threshold flag (default 80%)
The checker uses Go AST parsing to find exported symbols
(functions, types, consts, vars) without documentation.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- Fix doc comment: "status" → "health" in gitcmd package
- Implement --check flag for `core go fmt` (exits non-zero if files need formatting)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs: add docstrings for 100% coverage
Add documentation comments to all exported symbols:
- pkg/build: ProjectType constants
- pkg/cli: LogLevel, RenderStyle, TableStyle
- pkg/framework: ServiceFor, MustServiceFor, Core.Core
- pkg/git: GitError.Error, GitError.Unwrap
- pkg/i18n: Handler Match/Handle methods
- pkg/log: Level constants
- pkg/mcp: Tool input/output types
- pkg/php: Service constants, QA types, service methods
- pkg/process: ServiceError.Error
- pkg/repos: RepoType constants
- pkg/setup: ChangeType, ChangeCategory constants
- pkg/workspace: AddWorkspaceCommands
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* chore: standardize line endings to LF
Add .gitattributes to enforce LF line endings for all text files.
Normalize all existing files to use Unix-style line endings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr
- cmd_docblock.go: return error instead of os.Exit(1) for proper error handling
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback (round 2)
- linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit
- mcp.go: guard against empty old_string in editDiff to prevent runaway edits
- cmd_docblock.go: log parse errors instead of silently skipping
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 10:48:44 +00:00
|
|
|
}
|