2026-01-29 01:11:15 +00:00
|
|
|
package sdk
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"os"
|
|
|
|
|
"path/filepath"
|
|
|
|
|
"testing"
|
2026-01-29 14:28:23 +00:00
|
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
|
"github.com/stretchr/testify/require"
|
2026-01-29 01:11:15 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func TestDetectSpec_Good_ConfigPath(t *testing.T) {
|
|
|
|
|
tmpDir := t.TempDir()
|
|
|
|
|
specPath := filepath.Join(tmpDir, "api", "spec.yaml")
|
2026-01-29 14:28:23 +00:00
|
|
|
err := os.MkdirAll(filepath.Dir(specPath), 0755)
|
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
err = os.WriteFile(specPath, []byte("openapi: 3.0.0"), 0644)
|
|
|
|
|
require.NoError(t, err)
|
2026-01-29 01:11:15 +00:00
|
|
|
|
|
|
|
|
sdk := New(tmpDir, &Config{Spec: "api/spec.yaml"})
|
|
|
|
|
got, err := sdk.DetectSpec()
|
2026-01-29 14:28:23 +00:00
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, specPath, got)
|
2026-01-29 01:11:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestDetectSpec_Good_CommonPath(t *testing.T) {
|
|
|
|
|
tmpDir := t.TempDir()
|
|
|
|
|
specPath := filepath.Join(tmpDir, "openapi.yaml")
|
2026-01-29 14:28:23 +00:00
|
|
|
err := os.WriteFile(specPath, []byte("openapi: 3.0.0"), 0644)
|
|
|
|
|
require.NoError(t, err)
|
2026-01-29 01:11:15 +00:00
|
|
|
|
|
|
|
|
sdk := New(tmpDir, nil)
|
|
|
|
|
got, err := sdk.DetectSpec()
|
2026-01-29 14:28:23 +00:00
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, specPath, got)
|
2026-01-29 01:11:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestDetectSpec_Bad_NotFound(t *testing.T) {
|
|
|
|
|
tmpDir := t.TempDir()
|
|
|
|
|
sdk := New(tmpDir, nil)
|
|
|
|
|
_, err := sdk.DetectSpec()
|
2026-01-29 14:28:23 +00:00
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "no OpenAPI spec found")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestDetectSpec_Bad_ConfigNotFound(t *testing.T) {
|
|
|
|
|
tmpDir := t.TempDir()
|
|
|
|
|
sdk := New(tmpDir, &Config{Spec: "non-existent.yaml"})
|
|
|
|
|
_, err := sdk.DetectSpec()
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "configured spec not found")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestContainsScramble(t *testing.T) {
|
|
|
|
|
tests := []struct {
|
|
|
|
|
data string
|
|
|
|
|
expected bool
|
|
|
|
|
}{
|
|
|
|
|
{`{"require": {"dedoc/scramble": "^0.1"}}`, true},
|
|
|
|
|
{`{"require": {"scramble": "^0.1"}}`, true},
|
|
|
|
|
{`{"require": {"laravel/framework": "^11.0"}}`, false},
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for _, tt := range tests {
|
|
|
|
|
assert.Equal(t, tt.expected, containsScramble([]byte(tt.data)))
|
2026-01-29 01:11:15 +00:00
|
|
|
}
|
|
|
|
|
}
|
2026-01-29 14:28:23 +00:00
|
|
|
|
|
|
|
|
func TestDetectScramble_Bad(t *testing.T) {
|
|
|
|
|
t.Run("no composer.json", func(t *testing.T) {
|
|
|
|
|
sdk := New(t.TempDir(), nil)
|
|
|
|
|
_, err := sdk.detectScramble()
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "no composer.json")
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
t.Run("no scramble in composer.json", func(t *testing.T) {
|
|
|
|
|
tmpDir := t.TempDir()
|
|
|
|
|
err := os.WriteFile(filepath.Join(tmpDir, "composer.json"), []byte(`{}`), 0644)
|
|
|
|
|
require.NoError(t, err)
|
feat: git command, build improvements, and go fmt git-aware (#74)
* feat(go): make go fmt git-aware by default
- By default, only check changed Go files (modified, staged, untracked)
- Add --all flag to check all files (previous behaviour)
- Reduces noise when running fmt on large codebases
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(build): minimal output by default, add missing i18n
- Default output now shows single line: "Success Built N artifacts (dir)"
- Add --verbose/-v flag to show full detailed output
- Add all missing i18n translations for build commands
- Errors still show failure reason in minimal mode
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: add root-level `core git` command
- Create pkg/gitcmd with git workflow commands as root menu
- Export command builders from pkg/dev (AddCommitCommand, etc.)
- Commands available under both `core git` and `core dev` for compatibility
- Git commands: health, commit, push, pull, work, sync, apply
- GitHub orchestration stays in dev: issues, reviews, ci, impact
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(qa): add docblock coverage checking
Implement docblock/docstring coverage analysis for Go code:
- New `core qa docblock` command to check coverage
- Shows compact file:line list when under threshold
- Integrate with `core go qa` as a default check
- Add --docblock-threshold flag (default 80%)
The checker uses Go AST parsing to find exported symbols
(functions, types, consts, vars) without documentation.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- Fix doc comment: "status" → "health" in gitcmd package
- Implement --check flag for `core go fmt` (exits non-zero if files need formatting)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs: add docstrings for 100% coverage
Add documentation comments to all exported symbols:
- pkg/build: ProjectType constants
- pkg/cli: LogLevel, RenderStyle, TableStyle
- pkg/framework: ServiceFor, MustServiceFor, Core.Core
- pkg/git: GitError.Error, GitError.Unwrap
- pkg/i18n: Handler Match/Handle methods
- pkg/log: Level constants
- pkg/mcp: Tool input/output types
- pkg/php: Service constants, QA types, service methods
- pkg/process: ServiceError.Error
- pkg/repos: RepoType constants
- pkg/setup: ChangeType, ChangeCategory constants
- pkg/workspace: AddWorkspaceCommands
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* chore: standardize line endings to LF
Add .gitattributes to enforce LF line endings for all text files.
Normalize all existing files to use Unix-style line endings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr
- cmd_docblock.go: return error instead of os.Exit(1) for proper error handling
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback (round 2)
- linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit
- mcp.go: guard against empty old_string in editDiff to prevent runaway edits
- cmd_docblock.go: log parse errors instead of silently skipping
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 10:48:44 +00:00
|
|
|
|
2026-01-29 14:28:23 +00:00
|
|
|
sdk := New(tmpDir, nil)
|
|
|
|
|
_, err = sdk.detectScramble()
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "scramble not found")
|
|
|
|
|
})
|
feat: git command, build improvements, and go fmt git-aware (#74)
* feat(go): make go fmt git-aware by default
- By default, only check changed Go files (modified, staged, untracked)
- Add --all flag to check all files (previous behaviour)
- Reduces noise when running fmt on large codebases
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(build): minimal output by default, add missing i18n
- Default output now shows single line: "Success Built N artifacts (dir)"
- Add --verbose/-v flag to show full detailed output
- Add all missing i18n translations for build commands
- Errors still show failure reason in minimal mode
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: add root-level `core git` command
- Create pkg/gitcmd with git workflow commands as root menu
- Export command builders from pkg/dev (AddCommitCommand, etc.)
- Commands available under both `core git` and `core dev` for compatibility
- Git commands: health, commit, push, pull, work, sync, apply
- GitHub orchestration stays in dev: issues, reviews, ci, impact
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(qa): add docblock coverage checking
Implement docblock/docstring coverage analysis for Go code:
- New `core qa docblock` command to check coverage
- Shows compact file:line list when under threshold
- Integrate with `core go qa` as a default check
- Add --docblock-threshold flag (default 80%)
The checker uses Go AST parsing to find exported symbols
(functions, types, consts, vars) without documentation.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- Fix doc comment: "status" → "health" in gitcmd package
- Implement --check flag for `core go fmt` (exits non-zero if files need formatting)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs: add docstrings for 100% coverage
Add documentation comments to all exported symbols:
- pkg/build: ProjectType constants
- pkg/cli: LogLevel, RenderStyle, TableStyle
- pkg/framework: ServiceFor, MustServiceFor, Core.Core
- pkg/git: GitError.Error, GitError.Unwrap
- pkg/i18n: Handler Match/Handle methods
- pkg/log: Level constants
- pkg/mcp: Tool input/output types
- pkg/php: Service constants, QA types, service methods
- pkg/process: ServiceError.Error
- pkg/repos: RepoType constants
- pkg/setup: ChangeType, ChangeCategory constants
- pkg/workspace: AddWorkspaceCommands
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* chore: standardize line endings to LF
Add .gitattributes to enforce LF line endings for all text files.
Normalize all existing files to use Unix-style line endings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr
- cmd_docblock.go: return error instead of os.Exit(1) for proper error handling
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback (round 2)
- linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit
- mcp.go: guard against empty old_string in editDiff to prevent runaway edits
- cmd_docblock.go: log parse errors instead of silently skipping
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 10:48:44 +00:00
|
|
|
}
|