refactor(cli): restructure cmd packages into subdirectories
- Move CLI commands into subdirectories matching command hierarchy:
dev/, go/, php/, build/, ci/, sdk/, pkg/, vm/, docs/, setup/, doctor/, test/, ai/
- Create shared/ package for common styles and utilities
- Add new `core ai` root command with claude subcommand
- Update package declarations and imports across all files
- Create commands.go entry points for each package
- Remove GUI-related files (moved to core-gui repo)
This makes the filesystem structure match the CLI command structure,
improving context capture and code organization.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-29 18:02:43 +00:00
|
|
|
package dev
|
2026-01-27 21:08:51 +00:00
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"encoding/json"
|
refactor(cli): move commands from cmd/ to pkg/ with self-registration
Implements defence in depth through build variants - only compiled code
exists in the binary. Commands now self-register via cli.RegisterCommands()
in their init() functions, mirroring the i18n.RegisterLocales() pattern.
Structure changes:
- cmd/{ai,build,ci,dev,docs,doctor,go,php,pkg,sdk,setup,test,vm}/ → pkg/*/cmd_*.go
- cmd/core_dev.go, cmd/core_ci.go → cmd/variants/{full,ci,php,minimal}.go
- Added pkg/cli/commands.go with RegisterCommands API
- Updated pkg/cli/runtime.go to attach registered commands
Build variants:
- go build → full (21MB, all 13 command groups)
- go build -tags ci → ci (18MB, build/ci/sdk/doctor)
- go build -tags php → php (14MB, php/doctor)
- go build -tags minimal → minimal (11MB, doctor only)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 21:55:55 +00:00
|
|
|
"errors"
|
2026-01-27 21:08:51 +00:00
|
|
|
"os/exec"
|
|
|
|
|
"sort"
|
|
|
|
|
"strings"
|
|
|
|
|
"time"
|
|
|
|
|
|
2026-01-30 10:32:05 +00:00
|
|
|
"github.com/host-uk/core/pkg/cli"
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
"github.com/host-uk/core/pkg/i18n"
|
2026-01-27 21:08:51 +00:00
|
|
|
)
|
|
|
|
|
|
2026-01-30 01:28:39 +00:00
|
|
|
// Issue-specific styles (aliases to shared)
|
2026-01-27 21:08:51 +00:00
|
|
|
var (
|
2026-01-30 10:32:05 +00:00
|
|
|
issueRepoStyle = cli.DimStyle
|
|
|
|
|
issueNumberStyle = cli.TitleStyle
|
|
|
|
|
issueTitleStyle = cli.ValueStyle
|
|
|
|
|
issueLabelStyle = cli.WarningStyle
|
2026-01-31 23:36:43 +00:00
|
|
|
issueAssigneeStyle = cli.SuccessStyle
|
2026-01-30 10:32:05 +00:00
|
|
|
issueAgeStyle = cli.DimStyle
|
2026-01-27 21:08:51 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
// GitHubIssue represents a GitHub issue from the API.
|
|
|
|
|
type GitHubIssue struct {
|
|
|
|
|
Number int `json:"number"`
|
|
|
|
|
Title string `json:"title"`
|
|
|
|
|
State string `json:"state"`
|
|
|
|
|
CreatedAt time.Time `json:"createdAt"`
|
|
|
|
|
Author struct {
|
|
|
|
|
Login string `json:"login"`
|
|
|
|
|
} `json:"author"`
|
|
|
|
|
Assignees struct {
|
|
|
|
|
Nodes []struct {
|
|
|
|
|
Login string `json:"login"`
|
|
|
|
|
} `json:"nodes"`
|
|
|
|
|
} `json:"assignees"`
|
|
|
|
|
Labels struct {
|
|
|
|
|
Nodes []struct {
|
|
|
|
|
Name string `json:"name"`
|
|
|
|
|
} `json:"nodes"`
|
|
|
|
|
} `json:"labels"`
|
|
|
|
|
URL string `json:"url"`
|
|
|
|
|
|
|
|
|
|
// Added by us
|
|
|
|
|
RepoName string `json:"-"`
|
|
|
|
|
}
|
|
|
|
|
|
2026-01-30 00:47:54 +00:00
|
|
|
// Issues command flags
|
|
|
|
|
var (
|
|
|
|
|
issuesRegistryPath string
|
|
|
|
|
issuesLimit int
|
|
|
|
|
issuesAssignee string
|
|
|
|
|
)
|
|
|
|
|
|
2026-01-30 00:22:47 +00:00
|
|
|
// addIssuesCommand adds the 'issues' command to the given parent command.
|
2026-01-31 11:39:19 +00:00
|
|
|
func addIssuesCommand(parent *cli.Command) {
|
|
|
|
|
issuesCmd := &cli.Command{
|
2026-01-30 00:47:54 +00:00
|
|
|
Use: "issues",
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
Short: i18n.T("cmd.dev.issues.short"),
|
|
|
|
|
Long: i18n.T("cmd.dev.issues.long"),
|
2026-01-31 11:39:19 +00:00
|
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
2026-01-30 00:47:54 +00:00
|
|
|
limit := issuesLimit
|
|
|
|
|
if limit == 0 {
|
|
|
|
|
limit = 10
|
|
|
|
|
}
|
|
|
|
|
return runIssues(issuesRegistryPath, limit, issuesAssignee)
|
|
|
|
|
},
|
|
|
|
|
}
|
|
|
|
|
|
refactor(i18n): consolidate duplicate translation keys into common section
Add common.* keys for reusable translations:
- common.label.* - UI labels (error, done, status, version, etc.)
- common.status.* - status words (running, stopped, dirty, synced)
- common.error.* - error messages (failed, not_found, working_dir)
- common.flag.* - CLI flag descriptions (registry, verbose, etc.)
- common.count.* - count templates (failed, passed, skipped)
- common.result.* - result messages (all_passed, no_issues)
- common.progress.* - progress messages (running, checking)
- common.hint.* - help hints (install_with, fix_deps)
Update all cmd/* files to use common keys instead of duplicated
command-specific keys. Reduces translation maintenance burden
and ensures consistency across the CLI.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 11:32:25 +00:00
|
|
|
issuesCmd.Flags().StringVar(&issuesRegistryPath, "registry", "", i18n.T("common.flag.registry"))
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
issuesCmd.Flags().IntVarP(&issuesLimit, "limit", "l", 10, i18n.T("cmd.dev.issues.flag.limit"))
|
|
|
|
|
issuesCmd.Flags().StringVarP(&issuesAssignee, "assignee", "a", "", i18n.T("cmd.dev.issues.flag.assignee"))
|
2026-01-30 00:47:54 +00:00
|
|
|
|
|
|
|
|
parent.AddCommand(issuesCmd)
|
2026-01-27 21:08:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func runIssues(registryPath string, limit int, assignee string) error {
|
|
|
|
|
// Check gh is available
|
|
|
|
|
if _, err := exec.LookPath("gh"); err != nil {
|
refactor(cli): move commands from cmd/ to pkg/ with self-registration
Implements defence in depth through build variants - only compiled code
exists in the binary. Commands now self-register via cli.RegisterCommands()
in their init() functions, mirroring the i18n.RegisterLocales() pattern.
Structure changes:
- cmd/{ai,build,ci,dev,docs,doctor,go,php,pkg,sdk,setup,test,vm}/ → pkg/*/cmd_*.go
- cmd/core_dev.go, cmd/core_ci.go → cmd/variants/{full,ci,php,minimal}.go
- Added pkg/cli/commands.go with RegisterCommands API
- Updated pkg/cli/runtime.go to attach registered commands
Build variants:
- go build → full (21MB, all 13 command groups)
- go build -tags ci → ci (18MB, build/ci/sdk/doctor)
- go build -tags php → php (14MB, php/doctor)
- go build -tags minimal → minimal (11MB, doctor only)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 21:55:55 +00:00
|
|
|
return errors.New(i18n.T("error.gh_not_found"))
|
2026-01-27 21:08:51 +00:00
|
|
|
}
|
|
|
|
|
|
2026-02-01 02:07:26 +00:00
|
|
|
// Find or use provided registry
|
|
|
|
|
reg, _, err := loadRegistryWithConfig(registryPath)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
2026-01-27 21:08:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Fetch issues sequentially (avoid GitHub rate limits)
|
|
|
|
|
var allIssues []GitHubIssue
|
|
|
|
|
var fetchErrors []error
|
|
|
|
|
|
|
|
|
|
repoList := reg.List()
|
|
|
|
|
for i, repo := range repoList {
|
2026-01-31 11:39:19 +00:00
|
|
|
repoFullName := cli.Sprintf("%s/%s", reg.Org, repo.Name)
|
|
|
|
|
cli.Print("\033[2K\r%s %d/%d %s", dimStyle.Render(i18n.T("i18n.progress.fetch")), i+1, len(repoList), repo.Name)
|
2026-01-27 21:08:51 +00:00
|
|
|
|
|
|
|
|
issues, err := fetchIssues(repoFullName, repo.Name, limit, assignee)
|
|
|
|
|
if err != nil {
|
2026-01-31 11:39:19 +00:00
|
|
|
fetchErrors = append(fetchErrors, cli.Wrap(err, repo.Name))
|
2026-01-27 21:08:51 +00:00
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
allIssues = append(allIssues, issues...)
|
|
|
|
|
}
|
2026-01-31 11:39:19 +00:00
|
|
|
cli.Print("\033[2K\r") // Clear progress line
|
2026-01-27 21:08:51 +00:00
|
|
|
|
|
|
|
|
// Sort by created date (newest first)
|
|
|
|
|
sort.Slice(allIssues, func(i, j int) bool {
|
|
|
|
|
return allIssues[i].CreatedAt.After(allIssues[j].CreatedAt)
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
// Print issues
|
|
|
|
|
if len(allIssues) == 0 {
|
feat: git command, build improvements, and go fmt git-aware (#74)
* feat(go): make go fmt git-aware by default
- By default, only check changed Go files (modified, staged, untracked)
- Add --all flag to check all files (previous behaviour)
- Reduces noise when running fmt on large codebases
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(build): minimal output by default, add missing i18n
- Default output now shows single line: "Success Built N artifacts (dir)"
- Add --verbose/-v flag to show full detailed output
- Add all missing i18n translations for build commands
- Errors still show failure reason in minimal mode
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: add root-level `core git` command
- Create pkg/gitcmd with git workflow commands as root menu
- Export command builders from pkg/dev (AddCommitCommand, etc.)
- Commands available under both `core git` and `core dev` for compatibility
- Git commands: health, commit, push, pull, work, sync, apply
- GitHub orchestration stays in dev: issues, reviews, ci, impact
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(qa): add docblock coverage checking
Implement docblock/docstring coverage analysis for Go code:
- New `core qa docblock` command to check coverage
- Shows compact file:line list when under threshold
- Integrate with `core go qa` as a default check
- Add --docblock-threshold flag (default 80%)
The checker uses Go AST parsing to find exported symbols
(functions, types, consts, vars) without documentation.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- Fix doc comment: "status" → "health" in gitcmd package
- Implement --check flag for `core go fmt` (exits non-zero if files need formatting)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs: add docstrings for 100% coverage
Add documentation comments to all exported symbols:
- pkg/build: ProjectType constants
- pkg/cli: LogLevel, RenderStyle, TableStyle
- pkg/framework: ServiceFor, MustServiceFor, Core.Core
- pkg/git: GitError.Error, GitError.Unwrap
- pkg/i18n: Handler Match/Handle methods
- pkg/log: Level constants
- pkg/mcp: Tool input/output types
- pkg/php: Service constants, QA types, service methods
- pkg/process: ServiceError.Error
- pkg/repos: RepoType constants
- pkg/setup: ChangeType, ChangeCategory constants
- pkg/workspace: AddWorkspaceCommands
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* chore: standardize line endings to LF
Add .gitattributes to enforce LF line endings for all text files.
Normalize all existing files to use Unix-style line endings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr
- cmd_docblock.go: return error instead of os.Exit(1) for proper error handling
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback (round 2)
- linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit
- mcp.go: guard against empty old_string in editDiff to prevent runaway edits
- cmd_docblock.go: log parse errors instead of silently skipping
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 10:48:44 +00:00
|
|
|
cli.Text(i18n.T("cmd.dev.issues.no_issues"))
|
2026-01-27 21:08:51 +00:00
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
2026-01-31 11:39:19 +00:00
|
|
|
cli.Print("\n%s\n\n", i18n.T("cmd.dev.issues.open_issues", map[string]interface{}{"Count": len(allIssues)}))
|
2026-01-27 21:08:51 +00:00
|
|
|
|
|
|
|
|
for _, issue := range allIssues {
|
|
|
|
|
printIssue(issue)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Print any errors
|
|
|
|
|
if len(fetchErrors) > 0 {
|
2026-01-31 23:36:43 +00:00
|
|
|
cli.Blank()
|
2026-01-27 21:08:51 +00:00
|
|
|
for _, err := range fetchErrors {
|
2026-01-31 11:39:19 +00:00
|
|
|
cli.Print("%s %s\n", errorStyle.Render(i18n.Label("error")), err)
|
2026-01-27 21:08:51 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func fetchIssues(repoFullName, repoName string, limit int, assignee string) ([]GitHubIssue, error) {
|
|
|
|
|
args := []string{
|
|
|
|
|
"issue", "list",
|
|
|
|
|
"--repo", repoFullName,
|
|
|
|
|
"--state", "open",
|
2026-01-31 11:39:19 +00:00
|
|
|
"--limit", cli.Sprintf("%d", limit),
|
2026-01-27 21:08:51 +00:00
|
|
|
"--json", "number,title,state,createdAt,author,assignees,labels,url",
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if assignee != "" {
|
|
|
|
|
args = append(args, "--assignee", assignee)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
cmd := exec.Command("gh", args...)
|
|
|
|
|
output, err := cmd.Output()
|
|
|
|
|
if err != nil {
|
|
|
|
|
// Check if it's just "no issues" vs actual error
|
|
|
|
|
if exitErr, ok := err.(*exec.ExitError); ok {
|
|
|
|
|
stderr := string(exitErr.Stderr)
|
|
|
|
|
if strings.Contains(stderr, "no issues") || strings.Contains(stderr, "Could not resolve") {
|
|
|
|
|
return nil, nil
|
|
|
|
|
}
|
2026-01-31 11:39:19 +00:00
|
|
|
return nil, cli.Err("%s", stderr)
|
2026-01-27 21:08:51 +00:00
|
|
|
}
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
var issues []GitHubIssue
|
|
|
|
|
if err := json.Unmarshal(output, &issues); err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Tag with repo name
|
|
|
|
|
for i := range issues {
|
|
|
|
|
issues[i].RepoName = repoName
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return issues, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func printIssue(issue GitHubIssue) {
|
|
|
|
|
// #42 [core-bio] Fix avatar upload
|
2026-01-31 11:39:19 +00:00
|
|
|
num := issueNumberStyle.Render(cli.Sprintf("#%d", issue.Number))
|
|
|
|
|
repo := issueRepoStyle.Render(cli.Sprintf("[%s]", issue.RepoName))
|
2026-01-30 10:32:05 +00:00
|
|
|
title := issueTitleStyle.Render(cli.Truncate(issue.Title, 60))
|
2026-01-27 21:08:51 +00:00
|
|
|
|
2026-01-31 11:39:19 +00:00
|
|
|
line := cli.Sprintf(" %s %s %s", num, repo, title)
|
2026-01-27 21:08:51 +00:00
|
|
|
|
|
|
|
|
// Add labels if any
|
|
|
|
|
if len(issue.Labels.Nodes) > 0 {
|
|
|
|
|
var labels []string
|
|
|
|
|
for _, l := range issue.Labels.Nodes {
|
|
|
|
|
labels = append(labels, l.Name)
|
|
|
|
|
}
|
|
|
|
|
line += " " + issueLabelStyle.Render("["+strings.Join(labels, ", ")+"]")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Add assignee if any
|
|
|
|
|
if len(issue.Assignees.Nodes) > 0 {
|
|
|
|
|
var assignees []string
|
|
|
|
|
for _, a := range issue.Assignees.Nodes {
|
|
|
|
|
assignees = append(assignees, "@"+a.Login)
|
|
|
|
|
}
|
|
|
|
|
line += " " + issueAssigneeStyle.Render(strings.Join(assignees, ", "))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Add age
|
2026-01-30 10:32:05 +00:00
|
|
|
age := cli.FormatAge(issue.CreatedAt)
|
2026-01-27 21:08:51 +00:00
|
|
|
line += " " + issueAgeStyle.Render(age)
|
|
|
|
|
|
feat: git command, build improvements, and go fmt git-aware (#74)
* feat(go): make go fmt git-aware by default
- By default, only check changed Go files (modified, staged, untracked)
- Add --all flag to check all files (previous behaviour)
- Reduces noise when running fmt on large codebases
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(build): minimal output by default, add missing i18n
- Default output now shows single line: "Success Built N artifacts (dir)"
- Add --verbose/-v flag to show full detailed output
- Add all missing i18n translations for build commands
- Errors still show failure reason in minimal mode
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: add root-level `core git` command
- Create pkg/gitcmd with git workflow commands as root menu
- Export command builders from pkg/dev (AddCommitCommand, etc.)
- Commands available under both `core git` and `core dev` for compatibility
- Git commands: health, commit, push, pull, work, sync, apply
- GitHub orchestration stays in dev: issues, reviews, ci, impact
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(qa): add docblock coverage checking
Implement docblock/docstring coverage analysis for Go code:
- New `core qa docblock` command to check coverage
- Shows compact file:line list when under threshold
- Integrate with `core go qa` as a default check
- Add --docblock-threshold flag (default 80%)
The checker uses Go AST parsing to find exported symbols
(functions, types, consts, vars) without documentation.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- Fix doc comment: "status" → "health" in gitcmd package
- Implement --check flag for `core go fmt` (exits non-zero if files need formatting)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs: add docstrings for 100% coverage
Add documentation comments to all exported symbols:
- pkg/build: ProjectType constants
- pkg/cli: LogLevel, RenderStyle, TableStyle
- pkg/framework: ServiceFor, MustServiceFor, Core.Core
- pkg/git: GitError.Error, GitError.Unwrap
- pkg/i18n: Handler Match/Handle methods
- pkg/log: Level constants
- pkg/mcp: Tool input/output types
- pkg/php: Service constants, QA types, service methods
- pkg/process: ServiceError.Error
- pkg/repos: RepoType constants
- pkg/setup: ChangeType, ChangeCategory constants
- pkg/workspace: AddWorkspaceCommands
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* chore: standardize line endings to LF
Add .gitattributes to enforce LF line endings for all text files.
Normalize all existing files to use Unix-style line endings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback
- cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr
- cmd_docblock.go: return error instead of os.Exit(1) for proper error handling
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: address CodeRabbit review feedback (round 2)
- linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit
- mcp.go: guard against empty old_string in editDiff to prevent runaway edits
- cmd_docblock.go: log parse errors instead of silently skipping
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 10:48:44 +00:00
|
|
|
cli.Text(line)
|
2026-01-27 21:08:51 +00:00
|
|
|
}
|