refactor(core): decompose Core into serviceManager + messageBus (#282)
* refactor(core): decompose Core into serviceManager + messageBus (#215)
Extract two focused, unexported components from the Core "god object":
- serviceManager: owns service registry, lifecycle tracking (startables/
stoppables), and service lock
- messageBus: owns IPC action dispatch, query handling, and task handling
All public API methods on Core become one-line delegation wrappers.
Zero consumer changes — no files outside pkg/framework/core/ modified.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(core): remove unused fields from test struct
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(core): address review feedback from Gemini and Copilot
- Move locked check inside mutex in registerService to fix TOCTOU race
- Add mutex guards to enableLock and applyLock methods
- Replace fmt.Errorf with errors.Join in action() for correct error
aggregation (consistent with queryAll and lifecycle methods)
- Add TestMessageBus_Action_Bad for error aggregation coverage
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(workflows): bump host-uk/build from v3 to v4
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(workflows): replace Wails build with Go CLI build
The build action doesn't yet support Wails v3. Comment out the GUI
build step and use host-uk/build/actions/setup/go for Go toolchain
setup with a plain `go build` for the CLI binary.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(container): check context before select in Stop to fix flaky test
Stop() now checks ctx.Err() before entering the select block. When a
pre-cancelled context is passed, the select could non-deterministically
choose <-done over <-ctx.Done() if the process had already exited,
causing TestLinuxKitManager_Stop_Good_ContextCancelled to fail on CI.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(ci): trim CodeQL matrix to valid languages
Remove javascript-typescript and actions from CodeQL matrix — this
repo contains only Go and Python. Invalid languages blocked SARIF
upload and prevented merge.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(go): add `core go fuzz` command and wire into QA
- New `core go fuzz` command discovers Fuzz* targets and runs them
with configurable --duration (default 10s per target)
- Fuzz added to default QA checks with 5s burst duration
- Seed fuzz targets for core package: FuzzE (error constructor),
FuzzServiceRegistration, FuzzMessageDispatch
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(codeql): add workflow_dispatch trigger for manual runs
Allows manual triggering of CodeQL when the automatic pull_request
trigger doesn't fire.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(codeql): remove workflow in favour of default setup
CodeQL default setup is now enabled via repo settings for go and
python. The workflow-based approach uploaded results as "code quality"
rather than "code scanning", which didn't satisfy the code_scanning
ruleset requirement. Default setup handles this natively.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(workflows): add explicit permissions to all workflows
- agent-verify: add issues: write (was missing, writes comments/labels)
- ci: add contents: read (explicit least-privilege)
- coverage: add contents: read (explicit least-privilege)
All workflows now declare permissions explicitly. Repo default is
read-only, so workflows without a block silently lacked write access.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(workflows): replace inline logic with org reusable workflow callers
agent-verify.yml and auto-project.yml now delegate to centralised
reusable workflows in host-uk/.github, reducing per-repo duplication.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 13:40:16 +00:00
|
|
|
package gocmd
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"fmt"
|
|
|
|
|
"os"
|
|
|
|
|
"os/exec"
|
|
|
|
|
"path/filepath"
|
|
|
|
|
"regexp"
|
|
|
|
|
"strings"
|
|
|
|
|
"time"
|
|
|
|
|
|
2026-02-16 14:24:37 +00:00
|
|
|
"forge.lthn.ai/core/go/pkg/cli"
|
|
|
|
|
"forge.lthn.ai/core/go/pkg/i18n"
|
refactor(core): decompose Core into serviceManager + messageBus (#282)
* refactor(core): decompose Core into serviceManager + messageBus (#215)
Extract two focused, unexported components from the Core "god object":
- serviceManager: owns service registry, lifecycle tracking (startables/
stoppables), and service lock
- messageBus: owns IPC action dispatch, query handling, and task handling
All public API methods on Core become one-line delegation wrappers.
Zero consumer changes — no files outside pkg/framework/core/ modified.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(core): remove unused fields from test struct
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(core): address review feedback from Gemini and Copilot
- Move locked check inside mutex in registerService to fix TOCTOU race
- Add mutex guards to enableLock and applyLock methods
- Replace fmt.Errorf with errors.Join in action() for correct error
aggregation (consistent with queryAll and lifecycle methods)
- Add TestMessageBus_Action_Bad for error aggregation coverage
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(workflows): bump host-uk/build from v3 to v4
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(workflows): replace Wails build with Go CLI build
The build action doesn't yet support Wails v3. Comment out the GUI
build step and use host-uk/build/actions/setup/go for Go toolchain
setup with a plain `go build` for the CLI binary.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(container): check context before select in Stop to fix flaky test
Stop() now checks ctx.Err() before entering the select block. When a
pre-cancelled context is passed, the select could non-deterministically
choose <-done over <-ctx.Done() if the process had already exited,
causing TestLinuxKitManager_Stop_Good_ContextCancelled to fail on CI.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(ci): trim CodeQL matrix to valid languages
Remove javascript-typescript and actions from CodeQL matrix — this
repo contains only Go and Python. Invalid languages blocked SARIF
upload and prevented merge.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(go): add `core go fuzz` command and wire into QA
- New `core go fuzz` command discovers Fuzz* targets and runs them
with configurable --duration (default 10s per target)
- Fuzz added to default QA checks with 5s burst duration
- Seed fuzz targets for core package: FuzzE (error constructor),
FuzzServiceRegistration, FuzzMessageDispatch
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(codeql): add workflow_dispatch trigger for manual runs
Allows manual triggering of CodeQL when the automatic pull_request
trigger doesn't fire.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(codeql): remove workflow in favour of default setup
CodeQL default setup is now enabled via repo settings for go and
python. The workflow-based approach uploaded results as "code quality"
rather than "code scanning", which didn't satisfy the code_scanning
ruleset requirement. Default setup handles this natively.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(workflows): add explicit permissions to all workflows
- agent-verify: add issues: write (was missing, writes comments/labels)
- ci: add contents: read (explicit least-privilege)
- coverage: add contents: read (explicit least-privilege)
All workflows now declare permissions explicitly. Repo default is
read-only, so workflows without a block silently lacked write access.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(workflows): replace inline logic with org reusable workflow callers
agent-verify.yml and auto-project.yml now delegate to centralised
reusable workflows in host-uk/.github, reducing per-repo duplication.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 13:40:16 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
var (
|
|
|
|
|
fuzzDuration time.Duration
|
|
|
|
|
fuzzPkg string
|
|
|
|
|
fuzzRun string
|
|
|
|
|
fuzzVerbose bool
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func addGoFuzzCommand(parent *cli.Command) {
|
|
|
|
|
fuzzCmd := &cli.Command{
|
|
|
|
|
Use: "fuzz",
|
|
|
|
|
Short: "Run Go fuzz tests",
|
|
|
|
|
Long: `Run Go fuzz tests with configurable duration.
|
|
|
|
|
|
|
|
|
|
Discovers Fuzz* functions across the project and runs each with go test -fuzz.
|
|
|
|
|
|
|
|
|
|
Examples:
|
|
|
|
|
core go fuzz # Run all fuzz targets for 10s each
|
|
|
|
|
core go fuzz --duration=30s # Run each target for 30s
|
|
|
|
|
core go fuzz --pkg=./pkg/... # Fuzz specific package
|
|
|
|
|
core go fuzz --run=FuzzE # Run only matching fuzz targets`,
|
|
|
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
|
|
|
return runGoFuzz(fuzzDuration, fuzzPkg, fuzzRun, fuzzVerbose)
|
|
|
|
|
},
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fuzzCmd.Flags().DurationVar(&fuzzDuration, "duration", 10*time.Second, "Duration per fuzz target")
|
|
|
|
|
fuzzCmd.Flags().StringVar(&fuzzPkg, "pkg", "", "Package to fuzz (default: auto-discover)")
|
|
|
|
|
fuzzCmd.Flags().StringVar(&fuzzRun, "run", "", "Only run fuzz targets matching pattern")
|
|
|
|
|
fuzzCmd.Flags().BoolVarP(&fuzzVerbose, "verbose", "v", false, "Verbose output")
|
|
|
|
|
|
|
|
|
|
parent.AddCommand(fuzzCmd)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// fuzzTarget represents a discovered fuzz function and its package.
|
|
|
|
|
type fuzzTarget struct {
|
|
|
|
|
Pkg string
|
|
|
|
|
Name string
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func runGoFuzz(duration time.Duration, pkg, run string, verbose bool) error {
|
|
|
|
|
cli.Print("%s %s\n", dimStyle.Render(i18n.Label("fuzz")), i18n.ProgressSubject("run", "fuzz tests"))
|
|
|
|
|
cli.Blank()
|
|
|
|
|
|
|
|
|
|
targets, err := discoverFuzzTargets(pkg, run)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return cli.Wrap(err, "discover fuzz targets")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if len(targets) == 0 {
|
|
|
|
|
cli.Print(" %s no fuzz targets found\n", dimStyle.Render("—"))
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
cli.Print(" %s %d target(s), %s each\n", dimStyle.Render(i18n.Label("targets")), len(targets), duration)
|
|
|
|
|
cli.Blank()
|
|
|
|
|
|
|
|
|
|
passed := 0
|
|
|
|
|
failed := 0
|
|
|
|
|
|
|
|
|
|
for _, t := range targets {
|
|
|
|
|
cli.Print(" %s %s in %s\n", dimStyle.Render("→"), t.Name, t.Pkg)
|
|
|
|
|
|
|
|
|
|
args := []string{
|
|
|
|
|
"test",
|
|
|
|
|
fmt.Sprintf("-fuzz=^%s$", t.Name),
|
|
|
|
|
fmt.Sprintf("-fuzztime=%s", duration),
|
|
|
|
|
"-run=^$", // Don't run unit tests
|
|
|
|
|
}
|
|
|
|
|
if verbose {
|
|
|
|
|
args = append(args, "-v")
|
|
|
|
|
}
|
|
|
|
|
args = append(args, t.Pkg)
|
|
|
|
|
|
|
|
|
|
cmd := exec.Command("go", args...)
|
|
|
|
|
cmd.Env = append(os.Environ(), "MACOSX_DEPLOYMENT_TARGET=26.0", "CGO_ENABLED=0")
|
|
|
|
|
cmd.Dir, _ = os.Getwd()
|
|
|
|
|
|
|
|
|
|
output, runErr := cmd.CombinedOutput()
|
|
|
|
|
outputStr := string(output)
|
|
|
|
|
|
|
|
|
|
if runErr != nil {
|
|
|
|
|
failed++
|
|
|
|
|
cli.Print(" %s %s\n", errorStyle.Render(cli.Glyph(":cross:")), runErr.Error())
|
|
|
|
|
if outputStr != "" {
|
|
|
|
|
cli.Text(outputStr)
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
passed++
|
|
|
|
|
cli.Print(" %s %s\n", successStyle.Render(cli.Glyph(":check:")), i18n.T("i18n.done.pass"))
|
|
|
|
|
if verbose && outputStr != "" {
|
|
|
|
|
cli.Text(outputStr)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
cli.Blank()
|
|
|
|
|
if failed > 0 {
|
|
|
|
|
cli.Print("%s %d passed, %d failed\n", errorStyle.Render(cli.Glyph(":cross:")), passed, failed)
|
|
|
|
|
return cli.Err("fuzz: %d target(s) failed", failed)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
cli.Print("%s %d passed\n", successStyle.Render(cli.Glyph(":check:")), passed)
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// discoverFuzzTargets scans for Fuzz* functions in test files.
|
|
|
|
|
func discoverFuzzTargets(pkg, pattern string) ([]fuzzTarget, error) {
|
|
|
|
|
root := "."
|
|
|
|
|
if pkg != "" {
|
|
|
|
|
// Convert Go package pattern to filesystem path
|
|
|
|
|
root = strings.TrimPrefix(pkg, "./")
|
|
|
|
|
root = strings.TrimSuffix(root, "/...")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fuzzRe := regexp.MustCompile(`^func\s+(Fuzz\w+)\s*\(\s*\w+\s+\*testing\.F\s*\)`)
|
|
|
|
|
var matchRe *regexp.Regexp
|
|
|
|
|
if pattern != "" {
|
|
|
|
|
var err error
|
|
|
|
|
matchRe, err = regexp.Compile(pattern)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, fmt.Errorf("invalid --run pattern: %w", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
var targets []fuzzTarget
|
|
|
|
|
err := filepath.Walk(root, func(path string, info os.FileInfo, err error) error {
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
if info.IsDir() || !strings.HasSuffix(info.Name(), "_test.go") {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
data, readErr := os.ReadFile(path)
|
|
|
|
|
if readErr != nil {
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
dir := "./" + filepath.Dir(path)
|
|
|
|
|
for line := range strings.SplitSeq(string(data), "\n") {
|
|
|
|
|
m := fuzzRe.FindStringSubmatch(line)
|
|
|
|
|
if m == nil {
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
name := m[1]
|
|
|
|
|
if matchRe != nil && !matchRe.MatchString(name) {
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
targets = append(targets, fuzzTarget{Pkg: dir, Name: name})
|
|
|
|
|
}
|
|
|
|
|
return nil
|
|
|
|
|
})
|
|
|
|
|
return targets, err
|
|
|
|
|
}
|