2026-01-15 15:30:43 +00:00
|
|
|
package updater_test
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"fmt"
|
|
|
|
|
"log"
|
|
|
|
|
|
feat(mcp): add workspace root validation to prevent path traversal (#100)
* feat(mcp): add workspace root validation to prevent path traversal
- Add workspaceRoot field to Service for restricting file operations
- Add WithWorkspaceRoot() option for configuring the workspace directory
- Add validatePath() helper to check paths are within workspace
- Apply validation to all file operation handlers
- Default to current working directory for security
- Add comprehensive tests for path validation
Closes #82
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor: move CLI commands from pkg/ to internal/cmd/
- Move 18 CLI command packages to internal/cmd/ (not externally importable)
- Keep 16 library packages in pkg/ (externally importable)
- Update all import paths throughout codebase
- Cleaner separation between CLI logic and reusable libraries
CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor,
php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace
Libraries remaining: agentic, build, cache, cli, container, devops,
errors, framework, git, i18n, io, log, mcp, process, release, repos
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(mcp): use pkg/io Medium for sandboxed file operations
Replace manual path validation with pkg/io.Medium for all file operations.
This delegates security (path traversal, symlink bypass) to the sandboxed
local.Medium implementation.
Changes:
- Add io.NewSandboxed() for creating sandboxed Medium instances
- Refactor MCP Service to use io.Medium instead of direct os.* calls
- Remove validatePath and resolvePathWithSymlinks functions
- Update tests to verify Medium-based behaviour
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: correct import path and workflow references
- Fix pkg/io/io.go import from core-gui to core
- Update CI workflows to use internal/cmd/updater path
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(security): address CodeRabbit review issues for path validation
- pkg/io/local: add symlink resolution and boundary-aware containment
- Reject absolute paths in sandboxed Medium
- Use filepath.EvalSymlinks to prevent symlink bypass attacks
- Fix prefix check to prevent /tmp/root matching /tmp/root2
- pkg/mcp: fix resolvePath to validate and return errors
- Changed resolvePath from (string) to (string, error)
- Update deleteFile, renameFile, listDirectory, fileExists to handle errors
- Changed New() to return (*Service, error) instead of *Service
- Properly propagate option errors instead of silently discarding
- pkg/io: wrap errors with E() helper for consistent context
- Copy() and MockMedium.Read() now use coreerr.E()
- tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines
- Fix hardcoded /tmp in TestPath to use t.TempDir()
- Add TestResolvePath_Bad_SymlinkTraversal test
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting across all files
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 21:59:34 +00:00
|
|
|
"github.com/host-uk/core/internal/cmd/updater"
|
2026-01-15 15:30:43 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func ExampleNewUpdateService() {
|
|
|
|
|
// Mock the update check functions to prevent actual updates during tests
|
|
|
|
|
updater.CheckForUpdates = func(owner, repo, channel string, forceSemVerPrefix bool, releaseURLFormat string) error {
|
|
|
|
|
fmt.Println("CheckForUpdates called")
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
defer func() {
|
|
|
|
|
updater.CheckForUpdates = nil // Restore original function
|
|
|
|
|
}()
|
|
|
|
|
|
|
|
|
|
config := updater.UpdateServiceConfig{
|
|
|
|
|
RepoURL: "https://github.com/owner/repo",
|
|
|
|
|
Channel: "stable",
|
|
|
|
|
CheckOnStartup: updater.CheckAndUpdateOnStartup,
|
|
|
|
|
}
|
|
|
|
|
updateService, err := updater.NewUpdateService(config)
|
|
|
|
|
if err != nil {
|
|
|
|
|
log.Fatalf("Failed to create update service: %v", err)
|
|
|
|
|
}
|
|
|
|
|
if err := updateService.Start(); err != nil {
|
|
|
|
|
log.Printf("Update check failed: %v", err)
|
|
|
|
|
}
|
|
|
|
|
// Output: CheckForUpdates called
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func ExampleParseRepoURL() {
|
|
|
|
|
owner, repo, err := updater.ParseRepoURL("https://github.com/owner/repo")
|
|
|
|
|
if err != nil {
|
|
|
|
|
log.Fatalf("Failed to parse repo URL: %v", err)
|
|
|
|
|
}
|
|
|
|
|
fmt.Printf("Owner: %s, Repo: %s", owner, repo)
|
|
|
|
|
// Output: Owner: owner, Repo: repo
|
|
|
|
|
}
|