refactor(cli): move commands from cmd/ to pkg/ with self-registration
Implements defence in depth through build variants - only compiled code
exists in the binary. Commands now self-register via cli.RegisterCommands()
in their init() functions, mirroring the i18n.RegisterLocales() pattern.
Structure changes:
- cmd/{ai,build,ci,dev,docs,doctor,go,php,pkg,sdk,setup,test,vm}/ → pkg/*/cmd_*.go
- cmd/core_dev.go, cmd/core_ci.go → cmd/variants/{full,ci,php,minimal}.go
- Added pkg/cli/commands.go with RegisterCommands API
- Updated pkg/cli/runtime.go to attach registered commands
Build variants:
- go build → full (21MB, all 13 command groups)
- go build -tags ci → ci (18MB, build/ci/sdk/doctor)
- go build -tags php → php (14MB, php/doctor)
- go build -tags minimal → minimal (11MB, doctor only)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 21:55:55 +00:00
|
|
|
// cmd_bootstrap.go implements bootstrap mode for new workspaces.
|
2026-01-30 00:22:47 +00:00
|
|
|
//
|
|
|
|
|
// Bootstrap mode is activated when no repos.yaml exists in the current
|
|
|
|
|
// directory or any parent. It clones core-devops first, then uses its
|
|
|
|
|
// repos.yaml to present the package wizard.
|
|
|
|
|
|
|
|
|
|
package setup
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"context"
|
|
|
|
|
"fmt"
|
|
|
|
|
"os"
|
|
|
|
|
"path/filepath"
|
2026-02-01 03:55:01 +00:00
|
|
|
"strings"
|
2026-01-30 00:22:47 +00:00
|
|
|
|
feat(mcp): add workspace root validation to prevent path traversal (#100)
* feat(mcp): add workspace root validation to prevent path traversal
- Add workspaceRoot field to Service for restricting file operations
- Add WithWorkspaceRoot() option for configuring the workspace directory
- Add validatePath() helper to check paths are within workspace
- Apply validation to all file operation handlers
- Default to current working directory for security
- Add comprehensive tests for path validation
Closes #82
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor: move CLI commands from pkg/ to internal/cmd/
- Move 18 CLI command packages to internal/cmd/ (not externally importable)
- Keep 16 library packages in pkg/ (externally importable)
- Update all import paths throughout codebase
- Cleaner separation between CLI logic and reusable libraries
CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor,
php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace
Libraries remaining: agentic, build, cache, cli, container, devops,
errors, framework, git, i18n, io, log, mcp, process, release, repos
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(mcp): use pkg/io Medium for sandboxed file operations
Replace manual path validation with pkg/io.Medium for all file operations.
This delegates security (path traversal, symlink bypass) to the sandboxed
local.Medium implementation.
Changes:
- Add io.NewSandboxed() for creating sandboxed Medium instances
- Refactor MCP Service to use io.Medium instead of direct os.* calls
- Remove validatePath and resolvePathWithSymlinks functions
- Update tests to verify Medium-based behaviour
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: correct import path and workflow references
- Fix pkg/io/io.go import from core-gui to core
- Update CI workflows to use internal/cmd/updater path
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(security): address CodeRabbit review issues for path validation
- pkg/io/local: add symlink resolution and boundary-aware containment
- Reject absolute paths in sandboxed Medium
- Use filepath.EvalSymlinks to prevent symlink bypass attacks
- Fix prefix check to prevent /tmp/root matching /tmp/root2
- pkg/mcp: fix resolvePath to validate and return errors
- Changed resolvePath from (string) to (string, error)
- Update deleteFile, renameFile, listDirectory, fileExists to handle errors
- Changed New() to return (*Service, error) instead of *Service
- Properly propagate option errors instead of silently discarding
- pkg/io: wrap errors with E() helper for consistent context
- Copy() and MockMedium.Read() now use coreerr.E()
- tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines
- Fix hardcoded /tmp in TestPath to use t.TempDir()
- Add TestResolvePath_Bad_SymlinkTraversal test
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting across all files
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 21:59:34 +00:00
|
|
|
"github.com/host-uk/core/internal/cmd/workspace"
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
"github.com/host-uk/core/pkg/i18n"
|
2026-01-30 00:22:47 +00:00
|
|
|
"github.com/host-uk/core/pkg/repos"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
// runSetupOrchestrator decides between registry mode and bootstrap mode.
|
|
|
|
|
func runSetupOrchestrator(registryPath, only string, dryRun, all bool, projectName string, runBuild bool) error {
|
|
|
|
|
ctx := context.Background()
|
|
|
|
|
|
|
|
|
|
// Try to find an existing registry
|
|
|
|
|
var foundRegistry string
|
|
|
|
|
var err error
|
|
|
|
|
|
|
|
|
|
if registryPath != "" {
|
|
|
|
|
foundRegistry = registryPath
|
|
|
|
|
} else {
|
|
|
|
|
foundRegistry, err = repos.FindRegistry()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// If registry exists, use registry mode
|
|
|
|
|
if err == nil && foundRegistry != "" {
|
|
|
|
|
return runRegistrySetup(ctx, foundRegistry, only, dryRun, all, runBuild)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// No registry found - enter bootstrap mode
|
|
|
|
|
return runBootstrap(ctx, only, dryRun, all, projectName, runBuild)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// runBootstrap handles the case where no repos.yaml exists.
|
|
|
|
|
func runBootstrap(ctx context.Context, only string, dryRun, all bool, projectName string, runBuild bool) error {
|
|
|
|
|
cwd, err := os.Getwd()
|
|
|
|
|
if err != nil {
|
|
|
|
|
return fmt.Errorf("failed to get working directory: %w", err)
|
|
|
|
|
}
|
|
|
|
|
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
fmt.Printf("%s %s\n", dimStyle.Render(">>"), i18n.T("cmd.setup.bootstrap_mode"))
|
2026-01-30 00:22:47 +00:00
|
|
|
|
|
|
|
|
var targetDir string
|
|
|
|
|
|
|
|
|
|
// Check if current directory is empty
|
|
|
|
|
empty, err := isDirEmpty(cwd)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return fmt.Errorf("failed to check directory: %w", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if empty {
|
|
|
|
|
// Clone into current directory
|
|
|
|
|
targetDir = cwd
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
fmt.Printf("%s %s\n", dimStyle.Render(">>"), i18n.T("cmd.setup.cloning_current_dir"))
|
2026-01-30 00:22:47 +00:00
|
|
|
} else {
|
|
|
|
|
// Directory has content - check if it's a git repo root
|
|
|
|
|
isRepo := isGitRepoRoot(cwd)
|
|
|
|
|
|
|
|
|
|
if isRepo && isTerminal() && !all {
|
|
|
|
|
// Offer choice: setup working directory or create package
|
|
|
|
|
choice, err := promptSetupChoice()
|
|
|
|
|
if err != nil {
|
|
|
|
|
return fmt.Errorf("failed to get choice: %w", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if choice == "setup" {
|
|
|
|
|
// Setup this working directory with .core/ config
|
|
|
|
|
return runRepoSetup(cwd, dryRun)
|
|
|
|
|
}
|
|
|
|
|
// Otherwise continue to "create package" flow
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Create package flow - need a project name
|
|
|
|
|
if projectName == "" {
|
|
|
|
|
if !isTerminal() || all {
|
|
|
|
|
projectName = defaultOrg
|
|
|
|
|
} else {
|
|
|
|
|
projectName, err = promptProjectName(defaultOrg)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return fmt.Errorf("failed to get project name: %w", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
targetDir = filepath.Join(cwd, projectName)
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
fmt.Printf("%s %s: %s\n", dimStyle.Render(">>"), i18n.T("cmd.setup.creating_project_dir"), projectName)
|
2026-01-30 00:22:47 +00:00
|
|
|
|
|
|
|
|
if !dryRun {
|
|
|
|
|
if err := os.MkdirAll(targetDir, 0755); err != nil {
|
|
|
|
|
return fmt.Errorf("failed to create directory: %w", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Clone core-devops first
|
|
|
|
|
devopsPath := filepath.Join(targetDir, devopsRepo)
|
|
|
|
|
if _, err := os.Stat(filepath.Join(devopsPath, ".git")); os.IsNotExist(err) {
|
refactor(i18n): consolidate duplicate translation keys into common section
Add common.* keys for reusable translations:
- common.label.* - UI labels (error, done, status, version, etc.)
- common.status.* - status words (running, stopped, dirty, synced)
- common.error.* - error messages (failed, not_found, working_dir)
- common.flag.* - CLI flag descriptions (registry, verbose, etc.)
- common.count.* - count templates (failed, passed, skipped)
- common.result.* - result messages (all_passed, no_issues)
- common.progress.* - progress messages (running, checking)
- common.hint.* - help hints (install_with, fix_deps)
Update all cmd/* files to use common keys instead of duplicated
command-specific keys. Reduces translation maintenance burden
and ensures consistency across the CLI.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 11:32:25 +00:00
|
|
|
fmt.Printf("%s %s %s...\n", dimStyle.Render(">>"), i18n.T("common.status.cloning"), devopsRepo)
|
2026-01-30 00:22:47 +00:00
|
|
|
|
|
|
|
|
if !dryRun {
|
|
|
|
|
if err := gitClone(ctx, defaultOrg, devopsRepo, devopsPath); err != nil {
|
|
|
|
|
return fmt.Errorf("failed to clone %s: %w", devopsRepo, err)
|
|
|
|
|
}
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
fmt.Printf("%s %s %s\n", successStyle.Render(">>"), devopsRepo, i18n.T("cmd.setup.cloned"))
|
2026-01-30 00:22:47 +00:00
|
|
|
} else {
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
fmt.Printf(" %s %s/%s to %s\n", i18n.T("cmd.setup.would_clone"), defaultOrg, devopsRepo, devopsPath)
|
2026-01-30 00:22:47 +00:00
|
|
|
}
|
|
|
|
|
} else {
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
fmt.Printf("%s %s %s\n", dimStyle.Render(">>"), devopsRepo, i18n.T("cmd.setup.already_exists"))
|
2026-01-30 00:22:47 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Load the repos.yaml from core-devops
|
|
|
|
|
registryPath := filepath.Join(devopsPath, devopsReposYaml)
|
|
|
|
|
|
|
|
|
|
if dryRun {
|
feat(i18n): add translation keys to all CLI commands
Replace hardcoded strings with i18n.T() calls across all cmd/* packages:
- ai, build, ci, dev, docs, doctor, go, php, pkg, sdk, setup, test, vm
Adds 500+ translation keys to en.json for command descriptions,
flag descriptions, labels, messages, and error strings.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 02:37:57 +00:00
|
|
|
fmt.Printf("\n%s %s %s\n", dimStyle.Render(">>"), i18n.T("cmd.setup.would_load_registry"), registryPath)
|
2026-01-30 00:22:47 +00:00
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
reg, err := repos.LoadRegistry(registryPath)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return fmt.Errorf("failed to load registry from %s: %w", devopsRepo, err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Override base path to target directory
|
|
|
|
|
reg.BasePath = targetDir
|
|
|
|
|
|
2026-02-01 03:55:01 +00:00
|
|
|
// Check workspace config for default_only if no filter specified
|
|
|
|
|
if only == "" {
|
|
|
|
|
if wsConfig, err := workspace.LoadConfig(devopsPath); err == nil && wsConfig != nil && len(wsConfig.DefaultOnly) > 0 {
|
|
|
|
|
only = strings.Join(wsConfig.DefaultOnly, ",")
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2026-01-30 00:22:47 +00:00
|
|
|
// Now run the regular setup with the loaded registry
|
|
|
|
|
return runRegistrySetupWithReg(ctx, reg, registryPath, only, dryRun, all, runBuild)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// isGitRepoRoot returns true if the directory is a git repository root.
|
|
|
|
|
func isGitRepoRoot(path string) bool {
|
|
|
|
|
_, err := os.Stat(filepath.Join(path, ".git"))
|
|
|
|
|
return err == nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// isDirEmpty returns true if the directory is empty or contains only hidden files.
|
|
|
|
|
func isDirEmpty(path string) (bool, error) {
|
|
|
|
|
entries, err := os.ReadDir(path)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return false, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for _, e := range entries {
|
|
|
|
|
name := e.Name()
|
|
|
|
|
// Ignore common hidden/metadata files
|
|
|
|
|
if name == ".DS_Store" || name == ".git" || name == ".gitignore" {
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
// Any other non-hidden file means directory is not empty
|
|
|
|
|
if len(name) > 0 && name[0] != '.' {
|
|
|
|
|
return false, nil
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return true, nil
|
|
|
|
|
}
|