cli/pkg/agentic/service.go

143 lines
3.2 KiB
Go
Raw Normal View History

package agentic
import (
"context"
"os"
"os/exec"
"strings"
"forge.lthn.ai/core/cli/pkg/framework"
"forge.lthn.ai/core/cli/pkg/log"
)
// Tasks for AI service
// TaskCommit requests Claude to create a commit.
type TaskCommit struct {
Path string
Name string
CanEdit bool // allow Write/Edit tools
}
// TaskPrompt sends a custom prompt to Claude.
type TaskPrompt struct {
Prompt string
WorkDir string
AllowedTools []string
Implement Background Goroutines for Long-Running Operations (#309) * feat: implement background goroutines for long-running operations Introduced `PerformAsync` in the Core framework to support non-blocking execution of long-running tasks. This mechanism uses the IPC system to broadcast `ActionTaskStarted` and `ActionTaskCompleted` events, ensuring the frontend remains responsive and informed. - Added `PerformAsync(Task) string` to `Core`. - Defined framework-level lifecycle actions: `ActionTaskStarted`, `ActionTaskProgress`, and `ActionTaskCompleted`. - Updated `internal/cmd/dev/service.go` to support `AutoPush` in `TaskWork`, removing interactive prompts during background execution. - Added comprehensive documentation for the background operations pattern in `docs/pkg/PACKAGE_STANDARDS.md`. - Added unit tests for the async task mechanism in `pkg/framework/core/ipc_test.go`. * feat: implement background goroutines for long-running operations Introduced `PerformAsync` in the Core framework to support non-blocking execution of long-running tasks. This mechanism uses the IPC system to broadcast `ActionTaskStarted` and `ActionTaskCompleted` events, ensuring the frontend remains responsive and informed. - Added `PerformAsync(Task) string` to `Core`. - Defined framework-level lifecycle actions: `ActionTaskStarted`, `ActionTaskProgress`, and `ActionTaskCompleted`. - Updated `internal/cmd/dev/service.go` to support `AutoPush` in `TaskWork`, removing interactive prompts during background execution. - Added comprehensive documentation for the background operations pattern in `docs/pkg/PACKAGE_STANDARDS.md`. - Added unit tests for the async task mechanism in `pkg/framework/core/ipc_test.go`. - Fixed formatting in `pkg/io/local/client.go`. * feat: implement background goroutines with progress reporting This version addresses feedback by providing a more complete implementation of the background task mechanism, including progress reporting and demonstrating actual usage in the AI service. - Added `TaskWithID` interface to support task ID injection. - Updated `PerformAsync` to inject IDs and provided `Core.Progress` helper. - Applied background processing pattern to `TaskPrompt` in `agentic` service. - Included a fix for the `auto-merge` CI failure by providing explicit repo context to the `gh` command in a local workflow implementation. - Fixed formatting in `pkg/io/local/client.go` and `pkg/agentic/service.go`. - Updated documentation with the new progress reporting pattern. * feat: implement non-blocking background tasks with progress reporting This submission provides a complete framework-level solution for running long-running operations in the background to prevent UI blocking, addressing previous review feedback. Key changes: - Introduced `PerformAsync(Task) string` in the `Core` framework. - Added `TaskWithID` interface to allow tasks to receive their unique ID. - Provided `Core.Progress` helper for services to report granular updates. - Applied the background pattern to the AI service (`agentic.TaskPrompt`). - Updated the dev service (`TaskWork`) to support an `AutoPush` flag, eliminating interactive prompts during background execution. - Added a local implementation for the `auto-merge` CI workflow to bypass repo context issues and fix the blocking CI failure. - Included comprehensive documentation in `docs/pkg/PACKAGE_STANDARDS.md`. - Resolved formatting discrepancies across the codebase. - Verified functionality with unit tests in `pkg/framework/core/ipc_test.go`. --------- Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 10:26:45 +00:00
taskID string
}
Implement Background Goroutines for Long-Running Operations (#309) * feat: implement background goroutines for long-running operations Introduced `PerformAsync` in the Core framework to support non-blocking execution of long-running tasks. This mechanism uses the IPC system to broadcast `ActionTaskStarted` and `ActionTaskCompleted` events, ensuring the frontend remains responsive and informed. - Added `PerformAsync(Task) string` to `Core`. - Defined framework-level lifecycle actions: `ActionTaskStarted`, `ActionTaskProgress`, and `ActionTaskCompleted`. - Updated `internal/cmd/dev/service.go` to support `AutoPush` in `TaskWork`, removing interactive prompts during background execution. - Added comprehensive documentation for the background operations pattern in `docs/pkg/PACKAGE_STANDARDS.md`. - Added unit tests for the async task mechanism in `pkg/framework/core/ipc_test.go`. * feat: implement background goroutines for long-running operations Introduced `PerformAsync` in the Core framework to support non-blocking execution of long-running tasks. This mechanism uses the IPC system to broadcast `ActionTaskStarted` and `ActionTaskCompleted` events, ensuring the frontend remains responsive and informed. - Added `PerformAsync(Task) string` to `Core`. - Defined framework-level lifecycle actions: `ActionTaskStarted`, `ActionTaskProgress`, and `ActionTaskCompleted`. - Updated `internal/cmd/dev/service.go` to support `AutoPush` in `TaskWork`, removing interactive prompts during background execution. - Added comprehensive documentation for the background operations pattern in `docs/pkg/PACKAGE_STANDARDS.md`. - Added unit tests for the async task mechanism in `pkg/framework/core/ipc_test.go`. - Fixed formatting in `pkg/io/local/client.go`. * feat: implement background goroutines with progress reporting This version addresses feedback by providing a more complete implementation of the background task mechanism, including progress reporting and demonstrating actual usage in the AI service. - Added `TaskWithID` interface to support task ID injection. - Updated `PerformAsync` to inject IDs and provided `Core.Progress` helper. - Applied background processing pattern to `TaskPrompt` in `agentic` service. - Included a fix for the `auto-merge` CI failure by providing explicit repo context to the `gh` command in a local workflow implementation. - Fixed formatting in `pkg/io/local/client.go` and `pkg/agentic/service.go`. - Updated documentation with the new progress reporting pattern. * feat: implement non-blocking background tasks with progress reporting This submission provides a complete framework-level solution for running long-running operations in the background to prevent UI blocking, addressing previous review feedback. Key changes: - Introduced `PerformAsync(Task) string` in the `Core` framework. - Added `TaskWithID` interface to allow tasks to receive their unique ID. - Provided `Core.Progress` helper for services to report granular updates. - Applied the background pattern to the AI service (`agentic.TaskPrompt`). - Updated the dev service (`TaskWork`) to support an `AutoPush` flag, eliminating interactive prompts during background execution. - Added a local implementation for the `auto-merge` CI workflow to bypass repo context issues and fix the blocking CI failure. - Included comprehensive documentation in `docs/pkg/PACKAGE_STANDARDS.md`. - Resolved formatting discrepancies across the codebase. - Verified functionality with unit tests in `pkg/framework/core/ipc_test.go`. --------- Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 10:26:45 +00:00
func (t *TaskPrompt) SetTaskID(id string) { t.taskID = id }
func (t *TaskPrompt) GetTaskID() string { return t.taskID }
// ServiceOptions for configuring the AI service.
type ServiceOptions struct {
DefaultTools []string
AllowEdit bool // global permission for Write/Edit tools
}
// DefaultServiceOptions returns sensible defaults.
func DefaultServiceOptions() ServiceOptions {
return ServiceOptions{
DefaultTools: []string{"Bash", "Read", "Glob", "Grep"},
AllowEdit: false,
}
}
// Service provides AI/Claude operations as a Core service.
type Service struct {
*framework.ServiceRuntime[ServiceOptions]
}
// NewService creates an AI service factory.
func NewService(opts ServiceOptions) func(*framework.Core) (any, error) {
return func(c *framework.Core) (any, error) {
return &Service{
ServiceRuntime: framework.NewServiceRuntime(c, opts),
}, nil
}
}
// OnStartup registers task handlers.
func (s *Service) OnStartup(ctx context.Context) error {
s.Core().RegisterTask(s.handleTask)
return nil
}
func (s *Service) handleTask(c *framework.Core, t framework.Task) (any, bool, error) {
switch m := t.(type) {
case TaskCommit:
err := s.doCommit(m)
feat: BugSETI app, WebSocket hub, browser automation, and MCP tools (#336) * feat: add security logging and fix framework regressions This commit implements comprehensive security event logging and resolves critical regressions in the core framework. Security Logging: - Enhanced `pkg/log` with a `Security` level and helper. - Added `log.Username()` to consistently identify the executing user. - Instrumented GitHub CLI auth, Agentic configuration, filesystem sandbox, MCP handlers, and MCP TCP transport with security logs. - Added `SecurityStyle` to the CLI for consistent visual representation of security events. UniFi Security (CodeQL): - Refactored `pkg/unifi` to remove hardcoded `InsecureSkipVerify`, resolving a high-severity alert. - Added a `--verify-tls` flag and configuration option to control TLS verification. - Updated command handlers to support the new verification parameter. Framework Fixes: - Restored original signatures for `MustServiceFor`, `Config()`, and `Display()` in `pkg/framework/core`, which had been corrupted during a merge. - Fixed `pkg/framework/framework.go` and `pkg/framework/core/runtime_pkg.go` to match the restored signatures. - These fixes resolve project-wide compilation errors caused by the signature mismatches. I encountered significant blockers due to a corrupted state of the `dev` branch after a merge, which introduced breaking changes in the core framework's DI system. I had to manually reconcile these signatures with the expected usage across the codebase to restore build stability. * feat(mcp): add RAG tools (query, ingest, collections) Add vector database tools to the MCP server for RAG operations: - rag_query: Search for relevant documentation using semantic similarity - rag_ingest: Ingest files or directories into the vector database - rag_collections: List available collections Uses existing internal/cmd/rag exports (QueryDocs, IngestDirectory, IngestFile) and pkg/rag for Qdrant client access. Default collection is "hostuk-docs" with topK=5 for queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add metrics tools (record, query) Add MCP tools for recording and querying AI/security metrics events. The metrics_record tool writes events to daily JSONL files, and the metrics_query tool provides aggregated statistics by type, repo, and agent. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add 'core mcp serve' command Add CLI command to start the MCP server for AI tool integration. - Create internal/cmd/mcpcmd package with serve subcommand - Support --workspace flag for directory restriction - Handle SIGINT/SIGTERM for clean shutdown - Register in full.go build variant Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(ws): add WebSocket hub package for real-time streaming Add pkg/ws package implementing a hub pattern for WebSocket connections: - Hub manages client connections, broadcasts, and channel subscriptions - Client struct represents connected WebSocket clients - Message types: process_output, process_status, event, error, ping/pong - Channel-based subscription system (subscribe/unsubscribe) - SendProcessOutput and SendProcessStatus for process streaming integration - Full test coverage including concurrency tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add process management and WebSocket MCP tools Add MCP tools for process management: - process_start: Start a new external process - process_stop: Gracefully stop a running process - process_kill: Force kill a process - process_list: List all managed processes - process_output: Get captured process output - process_input: Send input to process stdin Add MCP tools for WebSocket: - ws_start: Start WebSocket server for real-time streaming - ws_info: Get hub statistics (clients, channels) Update Service struct with optional process.Service and ws.Hub fields, new WithProcessService and WithWSHub options, getter methods, and Shutdown method for cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(webview): add browser automation package via Chrome DevTools Protocol Add pkg/webview package for browser automation: - webview.go: Main interface with Connect, Navigate, Click, Type, QuerySelector, Screenshot, Evaluate - cdp.go: Chrome DevTools Protocol WebSocket client implementation - actions.go: DOM action types (Click, Type, Hover, Scroll, etc.) and ActionSequence builder - console.go: Console message capture and filtering with ConsoleWatcher and ExceptionWatcher - angular.go: Angular-specific helpers for router navigation, component access, and Zone.js stability Add MCP tools for webview: - webview_connect/disconnect: Connection management - webview_navigate: Page navigation - webview_click/type/query/wait: DOM interaction - webview_console: Console output capture - webview_eval: JavaScript execution - webview_screenshot: Screenshot capture Add documentation: - docs/mcp/angular-testing.md: Guide for Angular application testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: document new packages and BugSETI application - Update CLAUDE.md with documentation for: - pkg/ws (WebSocket hub for real-time streaming) - pkg/webview (Browser automation via CDP) - pkg/mcp (MCP server tools: process, ws, webview) - BugSETI application overview - Add comprehensive README for BugSETI with: - Installation and configuration guide - Usage workflow documentation - Architecture overview - Contributing guidelines Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(bugseti): add BugSETI system tray app with auto-update BugSETI - Distributed Bug Fixing like SETI@home but for code Features: - System tray app with Wails v3 - GitHub issue fetching with label filters - Issue queue with priority management - AI context seeding via seed-agent-developer skill - Automated PR submission flow - Stats tracking and leaderboard - Cross-platform notifications - Self-updating with stable/beta/nightly channels Includes: - cmd/bugseti: Main application with Angular frontend - internal/bugseti: Core services (fetcher, queue, seeder, submit, config, stats, notify) - internal/bugseti/updater: Auto-update system (checker, downloader, installer) - .github/workflows/bugseti-release.yml: CI/CD for all platforms Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: resolve import cycle and code duplication - Remove pkg/log import from pkg/io/local to break import cycle (pkg/log/rotation.go imports pkg/io, creating circular dependency) - Use stderr logging for security events in sandbox escape detection - Remove unused sync/atomic import from core.go - Fix duplicate LogSecurity function declarations in cli/log.go - Update workspace/service.go Crypt() call to match interface Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: update tests for new function signatures and format code - Update core_test.go: Config(), Display() now panic instead of returning error - Update runtime_pkg_test.go: sr.Config() now panics instead of returning error - Update MustServiceFor tests to use assert.Panics - Format BugSETI, MCP tools, and webview packages with gofmt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Snider <631881+Snider@users.noreply.github.com> Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 17:22:05 +00:00
if err != nil {
log.Error("agentic: commit task failed", "err", err, "path", m.Path)
}
return nil, true, err
case TaskPrompt:
err := s.doPrompt(m)
feat: BugSETI app, WebSocket hub, browser automation, and MCP tools (#336) * feat: add security logging and fix framework regressions This commit implements comprehensive security event logging and resolves critical regressions in the core framework. Security Logging: - Enhanced `pkg/log` with a `Security` level and helper. - Added `log.Username()` to consistently identify the executing user. - Instrumented GitHub CLI auth, Agentic configuration, filesystem sandbox, MCP handlers, and MCP TCP transport with security logs. - Added `SecurityStyle` to the CLI for consistent visual representation of security events. UniFi Security (CodeQL): - Refactored `pkg/unifi` to remove hardcoded `InsecureSkipVerify`, resolving a high-severity alert. - Added a `--verify-tls` flag and configuration option to control TLS verification. - Updated command handlers to support the new verification parameter. Framework Fixes: - Restored original signatures for `MustServiceFor`, `Config()`, and `Display()` in `pkg/framework/core`, which had been corrupted during a merge. - Fixed `pkg/framework/framework.go` and `pkg/framework/core/runtime_pkg.go` to match the restored signatures. - These fixes resolve project-wide compilation errors caused by the signature mismatches. I encountered significant blockers due to a corrupted state of the `dev` branch after a merge, which introduced breaking changes in the core framework's DI system. I had to manually reconcile these signatures with the expected usage across the codebase to restore build stability. * feat(mcp): add RAG tools (query, ingest, collections) Add vector database tools to the MCP server for RAG operations: - rag_query: Search for relevant documentation using semantic similarity - rag_ingest: Ingest files or directories into the vector database - rag_collections: List available collections Uses existing internal/cmd/rag exports (QueryDocs, IngestDirectory, IngestFile) and pkg/rag for Qdrant client access. Default collection is "hostuk-docs" with topK=5 for queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add metrics tools (record, query) Add MCP tools for recording and querying AI/security metrics events. The metrics_record tool writes events to daily JSONL files, and the metrics_query tool provides aggregated statistics by type, repo, and agent. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add 'core mcp serve' command Add CLI command to start the MCP server for AI tool integration. - Create internal/cmd/mcpcmd package with serve subcommand - Support --workspace flag for directory restriction - Handle SIGINT/SIGTERM for clean shutdown - Register in full.go build variant Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(ws): add WebSocket hub package for real-time streaming Add pkg/ws package implementing a hub pattern for WebSocket connections: - Hub manages client connections, broadcasts, and channel subscriptions - Client struct represents connected WebSocket clients - Message types: process_output, process_status, event, error, ping/pong - Channel-based subscription system (subscribe/unsubscribe) - SendProcessOutput and SendProcessStatus for process streaming integration - Full test coverage including concurrency tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add process management and WebSocket MCP tools Add MCP tools for process management: - process_start: Start a new external process - process_stop: Gracefully stop a running process - process_kill: Force kill a process - process_list: List all managed processes - process_output: Get captured process output - process_input: Send input to process stdin Add MCP tools for WebSocket: - ws_start: Start WebSocket server for real-time streaming - ws_info: Get hub statistics (clients, channels) Update Service struct with optional process.Service and ws.Hub fields, new WithProcessService and WithWSHub options, getter methods, and Shutdown method for cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(webview): add browser automation package via Chrome DevTools Protocol Add pkg/webview package for browser automation: - webview.go: Main interface with Connect, Navigate, Click, Type, QuerySelector, Screenshot, Evaluate - cdp.go: Chrome DevTools Protocol WebSocket client implementation - actions.go: DOM action types (Click, Type, Hover, Scroll, etc.) and ActionSequence builder - console.go: Console message capture and filtering with ConsoleWatcher and ExceptionWatcher - angular.go: Angular-specific helpers for router navigation, component access, and Zone.js stability Add MCP tools for webview: - webview_connect/disconnect: Connection management - webview_navigate: Page navigation - webview_click/type/query/wait: DOM interaction - webview_console: Console output capture - webview_eval: JavaScript execution - webview_screenshot: Screenshot capture Add documentation: - docs/mcp/angular-testing.md: Guide for Angular application testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: document new packages and BugSETI application - Update CLAUDE.md with documentation for: - pkg/ws (WebSocket hub for real-time streaming) - pkg/webview (Browser automation via CDP) - pkg/mcp (MCP server tools: process, ws, webview) - BugSETI application overview - Add comprehensive README for BugSETI with: - Installation and configuration guide - Usage workflow documentation - Architecture overview - Contributing guidelines Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(bugseti): add BugSETI system tray app with auto-update BugSETI - Distributed Bug Fixing like SETI@home but for code Features: - System tray app with Wails v3 - GitHub issue fetching with label filters - Issue queue with priority management - AI context seeding via seed-agent-developer skill - Automated PR submission flow - Stats tracking and leaderboard - Cross-platform notifications - Self-updating with stable/beta/nightly channels Includes: - cmd/bugseti: Main application with Angular frontend - internal/bugseti: Core services (fetcher, queue, seeder, submit, config, stats, notify) - internal/bugseti/updater: Auto-update system (checker, downloader, installer) - .github/workflows/bugseti-release.yml: CI/CD for all platforms Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: resolve import cycle and code duplication - Remove pkg/log import from pkg/io/local to break import cycle (pkg/log/rotation.go imports pkg/io, creating circular dependency) - Use stderr logging for security events in sandbox escape detection - Remove unused sync/atomic import from core.go - Fix duplicate LogSecurity function declarations in cli/log.go - Update workspace/service.go Crypt() call to match interface Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: update tests for new function signatures and format code - Update core_test.go: Config(), Display() now panic instead of returning error - Update runtime_pkg_test.go: sr.Config() now panics instead of returning error - Update MustServiceFor tests to use assert.Panics - Format BugSETI, MCP tools, and webview packages with gofmt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Snider <631881+Snider@users.noreply.github.com> Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 17:22:05 +00:00
if err != nil {
log.Error("agentic: prompt task failed", "err", err)
}
return nil, true, err
}
return nil, false, nil
}
func (s *Service) doCommit(task TaskCommit) error {
prompt := Prompt("commit")
tools := []string{"Bash", "Read", "Glob", "Grep"}
if task.CanEdit {
tools = []string{"Bash", "Read", "Write", "Edit", "Glob", "Grep"}
}
cmd := exec.CommandContext(context.Background(), "claude", "-p", prompt, "--allowedTools", strings.Join(tools, ","))
cmd.Dir = task.Path
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
cmd.Stdin = os.Stdin
return cmd.Run()
}
func (s *Service) doPrompt(task TaskPrompt) error {
Implement Background Goroutines for Long-Running Operations (#309) * feat: implement background goroutines for long-running operations Introduced `PerformAsync` in the Core framework to support non-blocking execution of long-running tasks. This mechanism uses the IPC system to broadcast `ActionTaskStarted` and `ActionTaskCompleted` events, ensuring the frontend remains responsive and informed. - Added `PerformAsync(Task) string` to `Core`. - Defined framework-level lifecycle actions: `ActionTaskStarted`, `ActionTaskProgress`, and `ActionTaskCompleted`. - Updated `internal/cmd/dev/service.go` to support `AutoPush` in `TaskWork`, removing interactive prompts during background execution. - Added comprehensive documentation for the background operations pattern in `docs/pkg/PACKAGE_STANDARDS.md`. - Added unit tests for the async task mechanism in `pkg/framework/core/ipc_test.go`. * feat: implement background goroutines for long-running operations Introduced `PerformAsync` in the Core framework to support non-blocking execution of long-running tasks. This mechanism uses the IPC system to broadcast `ActionTaskStarted` and `ActionTaskCompleted` events, ensuring the frontend remains responsive and informed. - Added `PerformAsync(Task) string` to `Core`. - Defined framework-level lifecycle actions: `ActionTaskStarted`, `ActionTaskProgress`, and `ActionTaskCompleted`. - Updated `internal/cmd/dev/service.go` to support `AutoPush` in `TaskWork`, removing interactive prompts during background execution. - Added comprehensive documentation for the background operations pattern in `docs/pkg/PACKAGE_STANDARDS.md`. - Added unit tests for the async task mechanism in `pkg/framework/core/ipc_test.go`. - Fixed formatting in `pkg/io/local/client.go`. * feat: implement background goroutines with progress reporting This version addresses feedback by providing a more complete implementation of the background task mechanism, including progress reporting and demonstrating actual usage in the AI service. - Added `TaskWithID` interface to support task ID injection. - Updated `PerformAsync` to inject IDs and provided `Core.Progress` helper. - Applied background processing pattern to `TaskPrompt` in `agentic` service. - Included a fix for the `auto-merge` CI failure by providing explicit repo context to the `gh` command in a local workflow implementation. - Fixed formatting in `pkg/io/local/client.go` and `pkg/agentic/service.go`. - Updated documentation with the new progress reporting pattern. * feat: implement non-blocking background tasks with progress reporting This submission provides a complete framework-level solution for running long-running operations in the background to prevent UI blocking, addressing previous review feedback. Key changes: - Introduced `PerformAsync(Task) string` in the `Core` framework. - Added `TaskWithID` interface to allow tasks to receive their unique ID. - Provided `Core.Progress` helper for services to report granular updates. - Applied the background pattern to the AI service (`agentic.TaskPrompt`). - Updated the dev service (`TaskWork`) to support an `AutoPush` flag, eliminating interactive prompts during background execution. - Added a local implementation for the `auto-merge` CI workflow to bypass repo context issues and fix the blocking CI failure. - Included comprehensive documentation in `docs/pkg/PACKAGE_STANDARDS.md`. - Resolved formatting discrepancies across the codebase. - Verified functionality with unit tests in `pkg/framework/core/ipc_test.go`. --------- Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 10:26:45 +00:00
if task.taskID != "" {
s.Core().Progress(task.taskID, 0.1, "Starting Claude...", &task)
}
opts := s.Opts()
tools := opts.DefaultTools
if len(tools) == 0 {
tools = []string{"Bash", "Read", "Glob", "Grep"}
}
if len(task.AllowedTools) > 0 {
tools = task.AllowedTools
}
cmd := exec.CommandContext(context.Background(), "claude", "-p", task.Prompt, "--allowedTools", strings.Join(tools, ","))
if task.WorkDir != "" {
cmd.Dir = task.WorkDir
}
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
cmd.Stdin = os.Stdin
Implement Background Goroutines for Long-Running Operations (#309) * feat: implement background goroutines for long-running operations Introduced `PerformAsync` in the Core framework to support non-blocking execution of long-running tasks. This mechanism uses the IPC system to broadcast `ActionTaskStarted` and `ActionTaskCompleted` events, ensuring the frontend remains responsive and informed. - Added `PerformAsync(Task) string` to `Core`. - Defined framework-level lifecycle actions: `ActionTaskStarted`, `ActionTaskProgress`, and `ActionTaskCompleted`. - Updated `internal/cmd/dev/service.go` to support `AutoPush` in `TaskWork`, removing interactive prompts during background execution. - Added comprehensive documentation for the background operations pattern in `docs/pkg/PACKAGE_STANDARDS.md`. - Added unit tests for the async task mechanism in `pkg/framework/core/ipc_test.go`. * feat: implement background goroutines for long-running operations Introduced `PerformAsync` in the Core framework to support non-blocking execution of long-running tasks. This mechanism uses the IPC system to broadcast `ActionTaskStarted` and `ActionTaskCompleted` events, ensuring the frontend remains responsive and informed. - Added `PerformAsync(Task) string` to `Core`. - Defined framework-level lifecycle actions: `ActionTaskStarted`, `ActionTaskProgress`, and `ActionTaskCompleted`. - Updated `internal/cmd/dev/service.go` to support `AutoPush` in `TaskWork`, removing interactive prompts during background execution. - Added comprehensive documentation for the background operations pattern in `docs/pkg/PACKAGE_STANDARDS.md`. - Added unit tests for the async task mechanism in `pkg/framework/core/ipc_test.go`. - Fixed formatting in `pkg/io/local/client.go`. * feat: implement background goroutines with progress reporting This version addresses feedback by providing a more complete implementation of the background task mechanism, including progress reporting and demonstrating actual usage in the AI service. - Added `TaskWithID` interface to support task ID injection. - Updated `PerformAsync` to inject IDs and provided `Core.Progress` helper. - Applied background processing pattern to `TaskPrompt` in `agentic` service. - Included a fix for the `auto-merge` CI failure by providing explicit repo context to the `gh` command in a local workflow implementation. - Fixed formatting in `pkg/io/local/client.go` and `pkg/agentic/service.go`. - Updated documentation with the new progress reporting pattern. * feat: implement non-blocking background tasks with progress reporting This submission provides a complete framework-level solution for running long-running operations in the background to prevent UI blocking, addressing previous review feedback. Key changes: - Introduced `PerformAsync(Task) string` in the `Core` framework. - Added `TaskWithID` interface to allow tasks to receive their unique ID. - Provided `Core.Progress` helper for services to report granular updates. - Applied the background pattern to the AI service (`agentic.TaskPrompt`). - Updated the dev service (`TaskWork`) to support an `AutoPush` flag, eliminating interactive prompts during background execution. - Added a local implementation for the `auto-merge` CI workflow to bypass repo context issues and fix the blocking CI failure. - Included comprehensive documentation in `docs/pkg/PACKAGE_STANDARDS.md`. - Resolved formatting discrepancies across the codebase. - Verified functionality with unit tests in `pkg/framework/core/ipc_test.go`. --------- Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 10:26:45 +00:00
if task.taskID != "" {
s.Core().Progress(task.taskID, 0.5, "Running Claude prompt...", &task)
}
err := cmd.Run()
if task.taskID != "" {
if err != nil {
s.Core().Progress(task.taskID, 1.0, "Failed: "+err.Error(), &task)
} else {
s.Core().Progress(task.taskID, 1.0, "Completed", &task)
}
}
return err
}