feat: infrastructure packages and lint cleanup (#281)
* ci: consolidate duplicate workflows and merge CodeQL configs
Remove 17 duplicate workflow files that were split copies of the
combined originals. Each family (CI, CodeQL, Coverage, PR Build,
Alpha Release) had the same job duplicated across separate
push/pull_request/schedule/manual trigger files.
Merge codeql.yml and codescan.yml into a single codeql.yml with
a language matrix covering go, javascript-typescript, python,
and actions — matching the previous default setup coverage.
Remaining workflows (one per family):
- ci.yml (push + PR + manual)
- codeql.yml (push + PR + schedule, all languages)
- coverage.yml (push + PR + manual)
- alpha-release.yml (push + manual)
- pr-build.yml (PR + manual)
- release.yml (tag push)
- agent-verify.yml, auto-label.yml, auto-project.yml
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: add collect, config, crypt, plugin packages and fix all lint issues
Add four new infrastructure packages with CLI commands:
- pkg/config: layered configuration (defaults → file → env → flags)
- pkg/crypt: crypto primitives (Argon2id, AES-GCM, ChaCha20, HMAC, checksums)
- pkg/plugin: plugin system with GitHub-based install/update/remove
- pkg/collect: collection subsystem (GitHub, BitcoinTalk, market, papers, excavate)
Fix all golangci-lint issues across the entire codebase (~100 errcheck,
staticcheck SA1012/SA1019/ST1005, unused, ineffassign fixes) so that
`core go qa` passes with 0 issues.
Closes #167, #168, #170, #250, #251, #252, #253, #254, #255, #256
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 11:34:43 +00:00
|
|
|
package plugin
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"testing"
|
|
|
|
|
|
2026-02-16 00:30:41 +00:00
|
|
|
"forge.lthn.ai/core/cli/pkg/io"
|
feat: infrastructure packages and lint cleanup (#281)
* ci: consolidate duplicate workflows and merge CodeQL configs
Remove 17 duplicate workflow files that were split copies of the
combined originals. Each family (CI, CodeQL, Coverage, PR Build,
Alpha Release) had the same job duplicated across separate
push/pull_request/schedule/manual trigger files.
Merge codeql.yml and codescan.yml into a single codeql.yml with
a language matrix covering go, javascript-typescript, python,
and actions — matching the previous default setup coverage.
Remaining workflows (one per family):
- ci.yml (push + PR + manual)
- codeql.yml (push + PR + schedule, all languages)
- coverage.yml (push + PR + manual)
- alpha-release.yml (push + manual)
- pr-build.yml (PR + manual)
- release.yml (tag push)
- agent-verify.yml, auto-label.yml, auto-project.yml
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: add collect, config, crypt, plugin packages and fix all lint issues
Add four new infrastructure packages with CLI commands:
- pkg/config: layered configuration (defaults → file → env → flags)
- pkg/crypt: crypto primitives (Argon2id, AES-GCM, ChaCha20, HMAC, checksums)
- pkg/plugin: plugin system with GitHub-based install/update/remove
- pkg/collect: collection subsystem (GitHub, BitcoinTalk, market, papers, excavate)
Fix all golangci-lint issues across the entire codebase (~100 errcheck,
staticcheck SA1012/SA1019/ST1005, unused, ineffassign fixes) so that
`core go qa` passes with 0 issues.
Closes #167, #168, #170, #250, #251, #252, #253, #254, #255, #256
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 11:34:43 +00:00
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func TestLoadManifest_Good(t *testing.T) {
|
|
|
|
|
m := io.NewMockMedium()
|
|
|
|
|
m.Files["plugins/test/plugin.json"] = `{
|
|
|
|
|
"name": "test-plugin",
|
|
|
|
|
"version": "1.0.0",
|
|
|
|
|
"description": "A test plugin",
|
|
|
|
|
"author": "Test Author",
|
|
|
|
|
"entrypoint": "main.go",
|
|
|
|
|
"dependencies": ["dep-a", "dep-b"],
|
|
|
|
|
"min_version": "0.5.0"
|
|
|
|
|
}`
|
|
|
|
|
|
|
|
|
|
manifest, err := LoadManifest(m, "plugins/test/plugin.json")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "test-plugin", manifest.Name)
|
|
|
|
|
assert.Equal(t, "1.0.0", manifest.Version)
|
|
|
|
|
assert.Equal(t, "A test plugin", manifest.Description)
|
|
|
|
|
assert.Equal(t, "Test Author", manifest.Author)
|
|
|
|
|
assert.Equal(t, "main.go", manifest.Entrypoint)
|
|
|
|
|
assert.Equal(t, []string{"dep-a", "dep-b"}, manifest.Dependencies)
|
|
|
|
|
assert.Equal(t, "0.5.0", manifest.MinVersion)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestLoadManifest_Good_MinimalFields(t *testing.T) {
|
|
|
|
|
m := io.NewMockMedium()
|
|
|
|
|
m.Files["plugin.json"] = `{
|
|
|
|
|
"name": "minimal",
|
|
|
|
|
"version": "0.1.0",
|
|
|
|
|
"entrypoint": "run.sh"
|
|
|
|
|
}`
|
|
|
|
|
|
|
|
|
|
manifest, err := LoadManifest(m, "plugin.json")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "minimal", manifest.Name)
|
|
|
|
|
assert.Equal(t, "0.1.0", manifest.Version)
|
|
|
|
|
assert.Equal(t, "run.sh", manifest.Entrypoint)
|
|
|
|
|
assert.Empty(t, manifest.Dependencies)
|
|
|
|
|
assert.Empty(t, manifest.MinVersion)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestLoadManifest_Bad_FileNotFound(t *testing.T) {
|
|
|
|
|
m := io.NewMockMedium()
|
|
|
|
|
|
|
|
|
|
_, err := LoadManifest(m, "nonexistent/plugin.json")
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "failed to read manifest")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestLoadManifest_Bad_InvalidJSON(t *testing.T) {
|
|
|
|
|
m := io.NewMockMedium()
|
|
|
|
|
m.Files["plugin.json"] = `{invalid json}`
|
|
|
|
|
|
|
|
|
|
_, err := LoadManifest(m, "plugin.json")
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "failed to parse manifest JSON")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestManifest_Validate_Good(t *testing.T) {
|
|
|
|
|
manifest := &Manifest{
|
|
|
|
|
Name: "test-plugin",
|
|
|
|
|
Version: "1.0.0",
|
|
|
|
|
Entrypoint: "main.go",
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
err := manifest.Validate()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestManifest_Validate_Bad_MissingName(t *testing.T) {
|
|
|
|
|
manifest := &Manifest{
|
|
|
|
|
Version: "1.0.0",
|
|
|
|
|
Entrypoint: "main.go",
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
err := manifest.Validate()
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "name is required")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestManifest_Validate_Bad_MissingVersion(t *testing.T) {
|
|
|
|
|
manifest := &Manifest{
|
|
|
|
|
Name: "test-plugin",
|
|
|
|
|
Entrypoint: "main.go",
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
err := manifest.Validate()
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "version is required")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestManifest_Validate_Bad_MissingEntrypoint(t *testing.T) {
|
|
|
|
|
manifest := &Manifest{
|
|
|
|
|
Name: "test-plugin",
|
|
|
|
|
Version: "1.0.0",
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
err := manifest.Validate()
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.Contains(t, err.Error(), "entrypoint is required")
|
|
|
|
|
}
|