feat(mcp): add workspace root validation to prevent path traversal (#100)
* feat(mcp): add workspace root validation to prevent path traversal
- Add workspaceRoot field to Service for restricting file operations
- Add WithWorkspaceRoot() option for configuring the workspace directory
- Add validatePath() helper to check paths are within workspace
- Apply validation to all file operation handlers
- Default to current working directory for security
- Add comprehensive tests for path validation
Closes #82
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor: move CLI commands from pkg/ to internal/cmd/
- Move 18 CLI command packages to internal/cmd/ (not externally importable)
- Keep 16 library packages in pkg/ (externally importable)
- Update all import paths throughout codebase
- Cleaner separation between CLI logic and reusable libraries
CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor,
php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace
Libraries remaining: agentic, build, cache, cli, container, devops,
errors, framework, git, i18n, io, log, mcp, process, release, repos
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(mcp): use pkg/io Medium for sandboxed file operations
Replace manual path validation with pkg/io.Medium for all file operations.
This delegates security (path traversal, symlink bypass) to the sandboxed
local.Medium implementation.
Changes:
- Add io.NewSandboxed() for creating sandboxed Medium instances
- Refactor MCP Service to use io.Medium instead of direct os.* calls
- Remove validatePath and resolvePathWithSymlinks functions
- Update tests to verify Medium-based behaviour
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: correct import path and workflow references
- Fix pkg/io/io.go import from core-gui to core
- Update CI workflows to use internal/cmd/updater path
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(security): address CodeRabbit review issues for path validation
- pkg/io/local: add symlink resolution and boundary-aware containment
- Reject absolute paths in sandboxed Medium
- Use filepath.EvalSymlinks to prevent symlink bypass attacks
- Fix prefix check to prevent /tmp/root matching /tmp/root2
- pkg/mcp: fix resolvePath to validate and return errors
- Changed resolvePath from (string) to (string, error)
- Update deleteFile, renameFile, listDirectory, fileExists to handle errors
- Changed New() to return (*Service, error) instead of *Service
- Properly propagate option errors instead of silently discarding
- pkg/io: wrap errors with E() helper for consistent context
- Copy() and MockMedium.Read() now use coreerr.E()
- tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines
- Fix hardcoded /tmp in TestPath to use t.TempDir()
- Add TestResolvePath_Bad_SymlinkTraversal test
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting across all files
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 21:59:34 +00:00
|
|
|
package io
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
// --- MockMedium Tests ---
|
|
|
|
|
|
|
|
|
|
func TestNewMockMedium_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
assert.NotNil(t, m)
|
|
|
|
|
assert.NotNil(t, m.Files)
|
|
|
|
|
assert.NotNil(t, m.Dirs)
|
|
|
|
|
assert.Empty(t, m.Files)
|
|
|
|
|
assert.Empty(t, m.Dirs)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Read_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["test.txt"] = "hello world"
|
|
|
|
|
content, err := m.Read("test.txt")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "hello world", content)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Read_Bad(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
_, err := m.Read("nonexistent.txt")
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Write_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
err := m.Write("test.txt", "content")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "content", m.Files["test.txt"])
|
|
|
|
|
|
|
|
|
|
// Overwrite existing file
|
|
|
|
|
err = m.Write("test.txt", "new content")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "new content", m.Files["test.txt"])
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_EnsureDir_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
err := m.EnsureDir("/path/to/dir")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.True(t, m.Dirs["/path/to/dir"])
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_IsFile_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["exists.txt"] = "content"
|
|
|
|
|
|
|
|
|
|
assert.True(t, m.IsFile("exists.txt"))
|
|
|
|
|
assert.False(t, m.IsFile("nonexistent.txt"))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_FileGet_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["test.txt"] = "content"
|
|
|
|
|
content, err := m.FileGet("test.txt")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "content", content)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_FileSet_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
err := m.FileSet("test.txt", "content")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "content", m.Files["test.txt"])
|
|
|
|
|
}
|
|
|
|
|
|
2026-02-02 00:37:52 +00:00
|
|
|
func TestMockMedium_Delete_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["test.txt"] = "content"
|
|
|
|
|
|
|
|
|
|
err := m.Delete("test.txt")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.False(t, m.IsFile("test.txt"))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Delete_Bad_NotFound(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
err := m.Delete("nonexistent.txt")
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Delete_Bad_DirNotEmpty(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Dirs["mydir"] = true
|
|
|
|
|
m.Files["mydir/file.txt"] = "content"
|
|
|
|
|
|
|
|
|
|
err := m.Delete("mydir")
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_DeleteAll_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Dirs["mydir"] = true
|
|
|
|
|
m.Dirs["mydir/subdir"] = true
|
|
|
|
|
m.Files["mydir/file.txt"] = "content"
|
|
|
|
|
m.Files["mydir/subdir/nested.txt"] = "nested"
|
|
|
|
|
|
|
|
|
|
err := m.DeleteAll("mydir")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Empty(t, m.Dirs)
|
|
|
|
|
assert.Empty(t, m.Files)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Rename_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["old.txt"] = "content"
|
|
|
|
|
|
|
|
|
|
err := m.Rename("old.txt", "new.txt")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.False(t, m.IsFile("old.txt"))
|
|
|
|
|
assert.True(t, m.IsFile("new.txt"))
|
|
|
|
|
assert.Equal(t, "content", m.Files["new.txt"])
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Rename_Good_Dir(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Dirs["olddir"] = true
|
|
|
|
|
m.Files["olddir/file.txt"] = "content"
|
|
|
|
|
|
|
|
|
|
err := m.Rename("olddir", "newdir")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.False(t, m.Dirs["olddir"])
|
|
|
|
|
assert.True(t, m.Dirs["newdir"])
|
|
|
|
|
assert.Equal(t, "content", m.Files["newdir/file.txt"])
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_List_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Dirs["mydir"] = true
|
|
|
|
|
m.Files["mydir/file1.txt"] = "content1"
|
|
|
|
|
m.Files["mydir/file2.txt"] = "content2"
|
|
|
|
|
m.Dirs["mydir/subdir"] = true
|
|
|
|
|
|
|
|
|
|
entries, err := m.List("mydir")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Len(t, entries, 3)
|
|
|
|
|
|
|
|
|
|
names := make(map[string]bool)
|
|
|
|
|
for _, e := range entries {
|
|
|
|
|
names[e.Name()] = true
|
|
|
|
|
}
|
|
|
|
|
assert.True(t, names["file1.txt"])
|
|
|
|
|
assert.True(t, names["file2.txt"])
|
|
|
|
|
assert.True(t, names["subdir"])
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Stat_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["test.txt"] = "hello world"
|
|
|
|
|
|
|
|
|
|
info, err := m.Stat("test.txt")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "test.txt", info.Name())
|
|
|
|
|
assert.Equal(t, int64(11), info.Size())
|
|
|
|
|
assert.False(t, info.IsDir())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Stat_Good_Dir(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Dirs["mydir"] = true
|
|
|
|
|
|
|
|
|
|
info, err := m.Stat("mydir")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "mydir", info.Name())
|
|
|
|
|
assert.True(t, info.IsDir())
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_Exists_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["file.txt"] = "content"
|
|
|
|
|
m.Dirs["mydir"] = true
|
|
|
|
|
|
|
|
|
|
assert.True(t, m.Exists("file.txt"))
|
|
|
|
|
assert.True(t, m.Exists("mydir"))
|
|
|
|
|
assert.False(t, m.Exists("nonexistent"))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestMockMedium_IsDir_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["file.txt"] = "content"
|
|
|
|
|
m.Dirs["mydir"] = true
|
|
|
|
|
|
|
|
|
|
assert.False(t, m.IsDir("file.txt"))
|
|
|
|
|
assert.True(t, m.IsDir("mydir"))
|
|
|
|
|
assert.False(t, m.IsDir("nonexistent"))
|
|
|
|
|
}
|
|
|
|
|
|
feat(mcp): add workspace root validation to prevent path traversal (#100)
* feat(mcp): add workspace root validation to prevent path traversal
- Add workspaceRoot field to Service for restricting file operations
- Add WithWorkspaceRoot() option for configuring the workspace directory
- Add validatePath() helper to check paths are within workspace
- Apply validation to all file operation handlers
- Default to current working directory for security
- Add comprehensive tests for path validation
Closes #82
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor: move CLI commands from pkg/ to internal/cmd/
- Move 18 CLI command packages to internal/cmd/ (not externally importable)
- Keep 16 library packages in pkg/ (externally importable)
- Update all import paths throughout codebase
- Cleaner separation between CLI logic and reusable libraries
CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor,
php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace
Libraries remaining: agentic, build, cache, cli, container, devops,
errors, framework, git, i18n, io, log, mcp, process, release, repos
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(mcp): use pkg/io Medium for sandboxed file operations
Replace manual path validation with pkg/io.Medium for all file operations.
This delegates security (path traversal, symlink bypass) to the sandboxed
local.Medium implementation.
Changes:
- Add io.NewSandboxed() for creating sandboxed Medium instances
- Refactor MCP Service to use io.Medium instead of direct os.* calls
- Remove validatePath and resolvePathWithSymlinks functions
- Update tests to verify Medium-based behaviour
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: correct import path and workflow references
- Fix pkg/io/io.go import from core-gui to core
- Update CI workflows to use internal/cmd/updater path
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(security): address CodeRabbit review issues for path validation
- pkg/io/local: add symlink resolution and boundary-aware containment
- Reject absolute paths in sandboxed Medium
- Use filepath.EvalSymlinks to prevent symlink bypass attacks
- Fix prefix check to prevent /tmp/root matching /tmp/root2
- pkg/mcp: fix resolvePath to validate and return errors
- Changed resolvePath from (string) to (string, error)
- Update deleteFile, renameFile, listDirectory, fileExists to handle errors
- Changed New() to return (*Service, error) instead of *Service
- Properly propagate option errors instead of silently discarding
- pkg/io: wrap errors with E() helper for consistent context
- Copy() and MockMedium.Read() now use coreerr.E()
- tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines
- Fix hardcoded /tmp in TestPath to use t.TempDir()
- Add TestResolvePath_Bad_SymlinkTraversal test
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting across all files
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 21:59:34 +00:00
|
|
|
// --- Wrapper Function Tests ---
|
|
|
|
|
|
|
|
|
|
func TestRead_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["test.txt"] = "hello"
|
|
|
|
|
content, err := Read(m, "test.txt")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "hello", content)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestWrite_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
err := Write(m, "test.txt", "hello")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "hello", m.Files["test.txt"])
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestEnsureDir_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
err := EnsureDir(m, "/my/dir")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.True(t, m.Dirs["/my/dir"])
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestIsFile_Good(t *testing.T) {
|
|
|
|
|
m := NewMockMedium()
|
|
|
|
|
m.Files["exists.txt"] = "content"
|
|
|
|
|
|
|
|
|
|
assert.True(t, IsFile(m, "exists.txt"))
|
|
|
|
|
assert.False(t, IsFile(m, "nonexistent.txt"))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCopy_Good(t *testing.T) {
|
|
|
|
|
source := NewMockMedium()
|
|
|
|
|
dest := NewMockMedium()
|
|
|
|
|
source.Files["test.txt"] = "hello"
|
|
|
|
|
err := Copy(source, "test.txt", dest, "test.txt")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "hello", dest.Files["test.txt"])
|
|
|
|
|
|
|
|
|
|
// Copy to different path
|
|
|
|
|
source.Files["original.txt"] = "content"
|
|
|
|
|
err = Copy(source, "original.txt", dest, "copied.txt")
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Equal(t, "content", dest.Files["copied.txt"])
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCopy_Bad(t *testing.T) {
|
|
|
|
|
source := NewMockMedium()
|
|
|
|
|
dest := NewMockMedium()
|
|
|
|
|
err := Copy(source, "nonexistent.txt", dest, "dest.txt")
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// --- Local Global Tests ---
|
|
|
|
|
|
|
|
|
|
func TestLocalGlobal_Good(t *testing.T) {
|
|
|
|
|
// io.Local should be initialized by init()
|
|
|
|
|
assert.NotNil(t, Local, "io.Local should be initialized")
|
|
|
|
|
|
|
|
|
|
// Should be able to use it as a Medium
|
|
|
|
|
var m Medium = Local
|
|
|
|
|
assert.NotNil(t, m)
|
|
|
|
|
}
|