core/cli
8
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(test): use manual cleanup for TestDevOps_Boot_Good_Success

Browse source 
The test was flaky because t.TempDir() fails cleanup when files are
added asynchronously by the container manager. Using os.MkdirTemp with
manual os.RemoveAll cleanup handles this gracefully.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Snider 2026-02-01 11:55:10 +00:00
parent c409f25de4
commit 3423e48682
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/devops/devops_test.go
View file

@ -779,12 +779,14 @@ func TestDevOps_CheckUpdate_Delegates(t *testing.T) {
} }
func TestDevOps_Boot_Good_Success(t *testing.T) { func TestDevOps_Boot_Good_Success(t *testing.T) {
tempDir := t.TempDir() tempDir, err := os.MkdirTemp("", "devops-boot-success-*")
require.NoError(t, err)
t.Cleanup(func() { os.RemoveAll(tempDir) })
t.Setenv("CORE_IMAGES_DIR", tempDir) t.Setenv("CORE_IMAGES_DIR", tempDir)
// Create fake image // Create fake image
imagePath := filepath.Join(tempDir, ImageName()) imagePath := filepath.Join(tempDir, ImageName())
err := os.WriteFile(imagePath, []byte("fake"), 0644) err = os.WriteFile(imagePath, []byte("fake"), 0644)
require.NoError(t, err) require.NoError(t, err)
cfg := DefaultConfig() cfg := DefaultConfig()