From 8effbda7cb67c469da53d40b599629963c889062 Mon Sep 17 00:00:00 2001 From: Snider Date: Sun, 1 Feb 2026 11:55:10 +0000 Subject: [PATCH] fix(test): use manual cleanup for TestDevOps_Boot_Good_Success The test was flaky because t.TempDir() fails cleanup when files are added asynchronously by the container manager. Using os.MkdirTemp with manual os.RemoveAll cleanup handles this gracefully. Co-Authored-By: Claude Opus 4.5 --- pkg/devops/devops_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/devops/devops_test.go b/pkg/devops/devops_test.go index 2e456b98..edb57427 100644 --- a/pkg/devops/devops_test.go +++ b/pkg/devops/devops_test.go @@ -779,12 +779,14 @@ func TestDevOps_CheckUpdate_Delegates(t *testing.T) { } func TestDevOps_Boot_Good_Success(t *testing.T) { - tempDir := t.TempDir() + tempDir, err := os.MkdirTemp("", "devops-boot-success-*") + require.NoError(t, err) + t.Cleanup(func() { os.RemoveAll(tempDir) }) t.Setenv("CORE_IMAGES_DIR", tempDir) // Create fake image imagePath := filepath.Join(tempDir, ImageName()) - err := os.WriteFile(imagePath, []byte("fake"), 0644) + err = os.WriteFile(imagePath, []byte("fake"), 0644) require.NoError(t, err) cfg := DefaultConfig()