From a76f6167b4bf94616f7e2591f2ea867515b8a068 Mon Sep 17 00:00:00 2001 From: Snider Date: Sun, 1 Feb 2026 06:53:15 +0000 Subject: [PATCH] fix(devops): fix flaky test cleanup in TestDevOps_Boot_Good_FreshFlag Use os.MkdirTemp with explicit cleanup instead of t.TempDir() to avoid cleanup errors when subdirectories are created during test execution. Co-Authored-By: Claude Opus 4.5 --- pkg/devops/devops_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/devops/devops_test.go b/pkg/devops/devops_test.go index b305d384..c3b8a2e3 100644 --- a/pkg/devops/devops_test.go +++ b/pkg/devops/devops_test.go @@ -615,12 +615,14 @@ func TestDevOps_IsRunning_Bad_DifferentContainerName(t *testing.T) { } func TestDevOps_Boot_Good_FreshFlag(t *testing.T) { - tempDir := t.TempDir() + tempDir, err := os.MkdirTemp("", "devops-test-*") + require.NoError(t, err) + t.Cleanup(func() { os.RemoveAll(tempDir) }) t.Setenv("CORE_IMAGES_DIR", tempDir) // Create fake image imagePath := filepath.Join(tempDir, ImageName()) - err := os.WriteFile(imagePath, []byte("fake"), 0644) + err = os.WriteFile(imagePath, []byte("fake"), 0644) require.NoError(t, err) cfg := DefaultConfig()