Commit graph

15 commits

Author SHA1 Message Date
Snider
71e15236e2 feat(i18n): add RegisterLocales for package locale registration
- Add i18n.RegisterLocales(fsys, dir) for packages to register translations
- Locales are automatically loaded when i18n.Init() is called
- Fix gram.word.* loading bug (strings were in wrong switch case)
- Fix loadJSON to merge messages instead of replacing
- Add common.* keys to base locale (labels, flags, progress, etc.)
- Add pkg/php/locales with PHP-specific translations
- pkg/php/i18n.go registers locales via init()

This enables the idiomatic pattern where packages register their
locale files and they're automatically loaded by the i18n system.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 20:51:32 +00:00
Snider
f4e52417ef fix(i18n): address additional code review findings
- LoadFS: Use path.Join instead of filepath.Join for fs.FS compatibility
- AddHandler: Document handler chain lock behavior
- getEffectiveFormality: Support string values ("formal", "informal")

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 19:14:10 +00:00
Snider
7f4682ab17 fix(i18n): address remaining code review issues
- service.go: Simplify Default() to just call Init() (sync.Once handles idempotency)
- service.go: Add nil check to SetDefault() with panic
- service.go: Add documentation for ModeStrict panic behavior
- loader.go: Add LanguagesErr() to expose directory scan errors
- loader.go: Use path.Join instead of filepath.Join for fs.FS compatibility
- transform.go: Add uint, uint8-64, int8, int16 support to type converters
- grammar.go: Replace deprecated strings.Title with unicode-aware implementation
- i18n_test.go: Add comprehensive concurrency tests with race detector

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 19:10:28 +00:00
Snider
285a4582b0 fix(i18n): address thread-safety issues from code review
- hooks.go: Use atomic.Value for missingKeyHandler global
- loader.go: Use sync.Once for FSLoader.Languages() caching
- service.go: Use atomic.Pointer[Service] for defaultService

All globals that could race between goroutines now use proper
synchronization primitives.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 19:02:30 +00:00
Snider
3daa0c34db feat(i18n): wire TranslationContext into formality resolution
- getEffectiveFormality() now checks *TranslationContext for formality
- Priority: TranslationContext > Subject > map["Formality"] > Service
- Add tests for context formality override behavior
- Update FUTURE_PROOFING.md: Context Integration now IMPLEMENTED
- Update REVIEW.md: Context wiring recommendation addressed

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 18:56:09 +00:00
Snider
945db09966 feat(i18n): add options pattern and NewWithLoader constructor
- Add NewWithLoader(loader, opts...) for custom storage backends
- Add Option type with WithFallback, WithFormality, WithHandlers,
  WithDefaultHandlers, WithMode, WithDebug options
- Update New() and NewWithFS() to accept options
- Add loader field to Service struct
- Remove NewSubject() alias (use S() instead)
- Add tests for new options and NewWithLoader

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 18:47:11 +00:00
Snider
67e7e552f3 refactor(i18n): implement extensible handler chain architecture
Refactor the i18n package for extensibility without breaking changes:

- Add KeyHandler interface for pluggable namespace handlers
- Add Loader interface for format-agnostic translation loading
- Add TranslationContext for translation disambiguation
- Implement 6 built-in handlers (Label, Progress, Count, Done, Fail, Numeric)
- Update T() to use handler chain instead of hardcoded logic
- Add handler management methods (AddHandler, PrependHandler, ClearHandlers)

File reorganisation:
- types.go: all type definitions
- loader.go: Loader interface + FSLoader (from mutate.go, checks.go)
- handler.go: KeyHandler interface + built-in handlers
- context.go: TranslationContext + C() builder
- hooks.go: renamed from actions.go
- service.go: merged interfaces.go content

Deleted: interfaces.go, mode.go, mutate.go, checks.go

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 18:42:41 +00:00
Snider
c47c2905a8 refactor(i18n): consistent empty input handling and add doc comment
- Article("") now returns "" for consistency with other grammar
  functions (PastTense, Gerund, PluralForm, Label all return "")
- Add doc comment to getMessage() for consistency with other
  internal helpers

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 18:15:28 +00:00
Snider
e59f7f8cfd refactor(i18n): final code standards cleanup
- Add explicit nil checks to toInt, toInt64, toFloat64 for consistency
- Standardize error messages to use %q for user-provided strings
- Export GetGrammarData for symmetry with SetGrammarData
- Standardize String() doc comments to "the TypeName" pattern

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 18:08:33 +00:00
Snider
f10a2b4bdb refactor(i18n): remove legacy i18n.{format} shortcuts
Use i18n.numeric.* namespace consistently:
- i18n.numeric.number
- i18n.numeric.decimal
- i18n.numeric.percent
- i18n.numeric.bytes
- i18n.numeric.ordinal
- i18n.numeric.ago

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 17:34:45 +00:00
Snider
8f977ed635 feat(i18n): add N() helper for numeric formatting
N(format, value) wraps T("i18n.numeric.{format}", value).

Supported formats:
- N("number", 1234567)  → "1,234,567"
- N("decimal", 1234.5)  → "1,234.5"
- N("percent", 0.85)    → "85%"
- N("bytes", 1536000)   → "1.5 MB"
- N("ordinal", 1)       → "1st"

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 17:33:18 +00:00
Snider
650c7b1c5a refactor(i18n): consolidate types into interfaces.go
Move all exported types to interfaces.go for consistent organisation.
Rename interface.go → interfaces.go.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 17:24:24 +00:00
Snider
b04b2a70dc feat(i18n): implement formality-based message selection
Add support for formal/informal translation variants using suffix convention:
- key._formal for formal address (Sie, vous, usted)
- key._informal for informal address (du, tu, tú)

Formality priority: Subject.Formal() > Service.SetFormality() > neutral

Example locale file:
  "greeting": "Hello",
  "greeting._formal": "Good morning, sir",
  "greeting._informal": "Hey there"

Usage:
  svc.SetFormality(FormalityFormal)
  svc.T("greeting")  // "Good morning, sir"

  svc.T("greeting", S("user", name).Informal())  // "Hey there"

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 17:13:12 +00:00
Snider
04d8772cba refactor(i18n): remove C() and move intents to test-only
Breaking change: Remove C() semantic intent composition API.

- Remove C() global function and Service.C() method
- Remove IntentBuilder fluent API (I(), For(), Compose(), etc.)
- Move coreIntents from intents.go to intents_test.go (test data only)
- Remove C() from Translator interface

Replace intent-based CLI helpers with grammar composition:
- ConfirmIntent → ConfirmAction(verb, subject)
- ConfirmDangerous → ConfirmDangerousAction(verb, subject)
- QuestionIntent → QuestionAction(verb, subject)
- ChooseIntent → ChooseAction(verb, subject, items)
- ChooseMultiIntent → ChooseMultiAction(verb, subject, items)

The intent definitions now serve purely as test data to verify
the grammar engine can compose identical strings.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 16:50:08 +00:00
Snider
2d1dbcc473 refactor(i18n): extract Service to service.go
Move Service struct, methods, constructors, and singleton management
to dedicated file for better code organization.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-30 14:50:25 +00:00