* feat(go): make go fmt git-aware by default - By default, only check changed Go files (modified, staged, untracked) - Add --all flag to check all files (previous behaviour) - Reduces noise when running fmt on large codebases Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(build): minimal output by default, add missing i18n - Default output now shows single line: "Success Built N artifacts (dir)" - Add --verbose/-v flag to show full detailed output - Add all missing i18n translations for build commands - Errors still show failure reason in minimal mode Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add root-level `core git` command - Create pkg/gitcmd with git workflow commands as root menu - Export command builders from pkg/dev (AddCommitCommand, etc.) - Commands available under both `core git` and `core dev` for compatibility - Git commands: health, commit, push, pull, work, sync, apply - GitHub orchestration stays in dev: issues, reviews, ci, impact Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(qa): add docblock coverage checking Implement docblock/docstring coverage analysis for Go code: - New `core qa docblock` command to check coverage - Shows compact file:line list when under threshold - Integrate with `core go qa` as a default check - Add --docblock-threshold flag (default 80%) The checker uses Go AST parsing to find exported symbols (functions, types, consts, vars) without documentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - Fix doc comment: "status" → "health" in gitcmd package - Implement --check flag for `core go fmt` (exits non-zero if files need formatting) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: add docstrings for 100% coverage Add documentation comments to all exported symbols: - pkg/build: ProjectType constants - pkg/cli: LogLevel, RenderStyle, TableStyle - pkg/framework: ServiceFor, MustServiceFor, Core.Core - pkg/git: GitError.Error, GitError.Unwrap - pkg/i18n: Handler Match/Handle methods - pkg/log: Level constants - pkg/mcp: Tool input/output types - pkg/php: Service constants, QA types, service methods - pkg/process: ServiceError.Error - pkg/repos: RepoType constants - pkg/setup: ChangeType, ChangeCategory constants - pkg/workspace: AddWorkspaceCommands Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: standardize line endings to LF Add .gitattributes to enforce LF line endings for all text files. Normalize all existing files to use Unix-style line endings. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr - cmd_docblock.go: return error instead of os.Exit(1) for proper error handling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback (round 2) - linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit - mcp.go: guard against empty old_string in editDiff to prevent runaway edits - cmd_docblock.go: log parse errors instead of silently skipping Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
203 lines
5.6 KiB
Go
203 lines
5.6 KiB
Go
package testcmd
|
|
|
|
import (
|
|
"bufio"
|
|
"fmt"
|
|
"path/filepath"
|
|
"regexp"
|
|
"sort"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/host-uk/core/pkg/i18n"
|
|
)
|
|
|
|
type packageCoverage struct {
|
|
name string
|
|
coverage float64
|
|
hasCov bool
|
|
}
|
|
|
|
type testResults struct {
|
|
packages []packageCoverage
|
|
passed int
|
|
failed int
|
|
skipped int
|
|
totalCov float64
|
|
covCount int
|
|
failedPkgs []string
|
|
}
|
|
|
|
func parseTestOutput(output string) testResults {
|
|
results := testResults{}
|
|
|
|
// Regex patterns - handle both timed and cached test results
|
|
// Example: ok github.com/host-uk/core/pkg/crypt 0.015s coverage: 91.2% of statements
|
|
// Example: ok github.com/host-uk/core/pkg/crypt (cached) coverage: 91.2% of statements
|
|
okPattern := regexp.MustCompile(`^ok\s+(\S+)\s+(?:[\d.]+s|\(cached\))(?:\s+coverage:\s+([\d.]+)%)?`)
|
|
failPattern := regexp.MustCompile(`^FAIL\s+(\S+)`)
|
|
skipPattern := regexp.MustCompile(`^\?\s+(\S+)\s+\[no test files\]`)
|
|
coverPattern := regexp.MustCompile(`coverage:\s+([\d.]+)%`)
|
|
|
|
scanner := bufio.NewScanner(strings.NewReader(output))
|
|
for scanner.Scan() {
|
|
line := scanner.Text()
|
|
|
|
if matches := okPattern.FindStringSubmatch(line); matches != nil {
|
|
pkg := packageCoverage{name: matches[1]}
|
|
if len(matches) > 2 && matches[2] != "" {
|
|
cov, _ := strconv.ParseFloat(matches[2], 64)
|
|
pkg.coverage = cov
|
|
pkg.hasCov = true
|
|
results.totalCov += cov
|
|
results.covCount++
|
|
}
|
|
results.packages = append(results.packages, pkg)
|
|
results.passed++
|
|
} else if matches := failPattern.FindStringSubmatch(line); matches != nil {
|
|
results.failed++
|
|
results.failedPkgs = append(results.failedPkgs, matches[1])
|
|
} else if matches := skipPattern.FindStringSubmatch(line); matches != nil {
|
|
results.skipped++
|
|
} else if matches := coverPattern.FindStringSubmatch(line); matches != nil {
|
|
// Catch any additional coverage lines
|
|
cov, _ := strconv.ParseFloat(matches[1], 64)
|
|
if cov > 0 {
|
|
// Find the last package without coverage and update it
|
|
for i := len(results.packages) - 1; i >= 0; i-- {
|
|
if !results.packages[i].hasCov {
|
|
results.packages[i].coverage = cov
|
|
results.packages[i].hasCov = true
|
|
results.totalCov += cov
|
|
results.covCount++
|
|
break
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return results
|
|
}
|
|
|
|
func printTestSummary(results testResults, showCoverage bool) {
|
|
// Print pass/fail summary
|
|
total := results.passed + results.failed
|
|
if total > 0 {
|
|
fmt.Printf(" %s %s", testPassStyle.Render("✓"), i18n.T("i18n.count.passed", results.passed))
|
|
if results.failed > 0 {
|
|
fmt.Printf(" %s %s", testFailStyle.Render("✗"), i18n.T("i18n.count.failed", results.failed))
|
|
}
|
|
if results.skipped > 0 {
|
|
fmt.Printf(" %s %s", testSkipStyle.Render("○"), i18n.T("i18n.count.skipped", results.skipped))
|
|
}
|
|
fmt.Println()
|
|
}
|
|
|
|
// Print failed packages
|
|
if len(results.failedPkgs) > 0 {
|
|
fmt.Printf("\n %s\n", i18n.T("cmd.test.failed_packages"))
|
|
for _, pkg := range results.failedPkgs {
|
|
fmt.Printf(" %s %s\n", testFailStyle.Render("✗"), pkg)
|
|
}
|
|
}
|
|
|
|
// Print coverage
|
|
if showCoverage {
|
|
printCoverageSummary(results)
|
|
} else if results.covCount > 0 {
|
|
avgCov := results.totalCov / float64(results.covCount)
|
|
fmt.Printf("\n %s %s\n", i18n.Label("coverage"), formatCoverage(avgCov))
|
|
}
|
|
}
|
|
|
|
func printCoverageSummary(results testResults) {
|
|
if len(results.packages) == 0 {
|
|
return
|
|
}
|
|
|
|
fmt.Printf("\n %s\n", testHeaderStyle.Render(i18n.T("cmd.test.coverage_by_package")))
|
|
|
|
// Sort packages by name
|
|
sort.Slice(results.packages, func(i, j int) bool {
|
|
return results.packages[i].name < results.packages[j].name
|
|
})
|
|
|
|
// Find max package name length for alignment
|
|
maxLen := 0
|
|
for _, pkg := range results.packages {
|
|
name := shortenPackageName(pkg.name)
|
|
if len(name) > maxLen {
|
|
maxLen = len(name)
|
|
}
|
|
}
|
|
|
|
// Print each package
|
|
for _, pkg := range results.packages {
|
|
if !pkg.hasCov {
|
|
continue
|
|
}
|
|
name := shortenPackageName(pkg.name)
|
|
padding := strings.Repeat(" ", maxLen-len(name)+2)
|
|
fmt.Printf(" %s%s%s\n", name, padding, formatCoverage(pkg.coverage))
|
|
}
|
|
|
|
// Print average
|
|
if results.covCount > 0 {
|
|
avgCov := results.totalCov / float64(results.covCount)
|
|
avgLabel := i18n.T("cmd.test.label.average")
|
|
padding := strings.Repeat(" ", maxLen-len(avgLabel)+2)
|
|
fmt.Printf("\n %s%s%s\n", testHeaderStyle.Render(avgLabel), padding, formatCoverage(avgCov))
|
|
}
|
|
}
|
|
|
|
func formatCoverage(cov float64) string {
|
|
s := fmt.Sprintf("%.1f%%", cov)
|
|
if cov >= 80 {
|
|
return testCovHighStyle.Render(s)
|
|
} else if cov >= 50 {
|
|
return testCovMedStyle.Render(s)
|
|
}
|
|
return testCovLowStyle.Render(s)
|
|
}
|
|
|
|
func shortenPackageName(name string) string {
|
|
// Remove common prefixes
|
|
prefixes := []string{
|
|
"github.com/host-uk/core/",
|
|
"github.com/host-uk/",
|
|
}
|
|
for _, prefix := range prefixes {
|
|
if strings.HasPrefix(name, prefix) {
|
|
return strings.TrimPrefix(name, prefix)
|
|
}
|
|
}
|
|
return filepath.Base(name)
|
|
}
|
|
|
|
func printJSONResults(results testResults, exitCode int) {
|
|
// Simple JSON output for agents
|
|
fmt.Printf("{\n")
|
|
fmt.Printf(" \"passed\": %d,\n", results.passed)
|
|
fmt.Printf(" \"failed\": %d,\n", results.failed)
|
|
fmt.Printf(" \"skipped\": %d,\n", results.skipped)
|
|
if results.covCount > 0 {
|
|
avgCov := results.totalCov / float64(results.covCount)
|
|
fmt.Printf(" \"coverage\": %.1f,\n", avgCov)
|
|
}
|
|
fmt.Printf(" \"exit_code\": %d,\n", exitCode)
|
|
if len(results.failedPkgs) > 0 {
|
|
fmt.Printf(" \"failed_packages\": [\n")
|
|
for i, pkg := range results.failedPkgs {
|
|
comma := ","
|
|
if i == len(results.failedPkgs)-1 {
|
|
comma = ""
|
|
}
|
|
fmt.Printf(" %q%s\n", pkg, comma)
|
|
}
|
|
fmt.Printf(" ]\n")
|
|
} else {
|
|
fmt.Printf(" \"failed_packages\": []\n")
|
|
}
|
|
fmt.Printf("}\n")
|
|
}
|