* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
172 lines
4.8 KiB
Go
172 lines
4.8 KiB
Go
package php
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestGetSSLDir_Good(t *testing.T) {
|
|
t.Run("uses provided directory", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
customDir := filepath.Join(dir, "custom-ssl")
|
|
|
|
result, err := GetSSLDir(SSLOptions{Dir: customDir})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, customDir, result)
|
|
|
|
// Verify directory was created
|
|
info, err := os.Stat(result)
|
|
assert.NoError(t, err)
|
|
assert.True(t, info.IsDir())
|
|
})
|
|
|
|
t.Run("uses default directory when not specified", func(t *testing.T) {
|
|
// Skip if we can't get home dir
|
|
home, err := os.UserHomeDir()
|
|
if err != nil {
|
|
t.Skip("cannot get home directory")
|
|
}
|
|
|
|
result, err := GetSSLDir(SSLOptions{})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, filepath.Join(home, DefaultSSLDir), result)
|
|
})
|
|
}
|
|
|
|
func TestCertPaths_Good(t *testing.T) {
|
|
t.Run("returns correct paths for domain", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
certFile, keyFile, err := CertPaths("example.test", SSLOptions{Dir: dir})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, filepath.Join(dir, "example.test.pem"), certFile)
|
|
assert.Equal(t, filepath.Join(dir, "example.test-key.pem"), keyFile)
|
|
})
|
|
|
|
t.Run("handles domain with subdomain", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
|
|
certFile, keyFile, err := CertPaths("app.example.test", SSLOptions{Dir: dir})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, filepath.Join(dir, "app.example.test.pem"), certFile)
|
|
assert.Equal(t, filepath.Join(dir, "app.example.test-key.pem"), keyFile)
|
|
})
|
|
}
|
|
|
|
func TestCertsExist_Good(t *testing.T) {
|
|
t.Run("returns true when both files exist", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
domain := "myapp.test"
|
|
|
|
// Create cert and key files
|
|
certFile := filepath.Join(dir, domain+".pem")
|
|
keyFile := filepath.Join(dir, domain+"-key.pem")
|
|
|
|
err := os.WriteFile(certFile, []byte("cert content"), 0644)
|
|
require.NoError(t, err)
|
|
err = os.WriteFile(keyFile, []byte("key content"), 0644)
|
|
require.NoError(t, err)
|
|
|
|
assert.True(t, CertsExist(domain, SSLOptions{Dir: dir}))
|
|
})
|
|
}
|
|
|
|
func TestCertsExist_Bad(t *testing.T) {
|
|
t.Run("returns false when cert missing", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
domain := "myapp.test"
|
|
|
|
// Create only key file
|
|
keyFile := filepath.Join(dir, domain+"-key.pem")
|
|
err := os.WriteFile(keyFile, []byte("key content"), 0644)
|
|
require.NoError(t, err)
|
|
|
|
assert.False(t, CertsExist(domain, SSLOptions{Dir: dir}))
|
|
})
|
|
|
|
t.Run("returns false when key missing", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
domain := "myapp.test"
|
|
|
|
// Create only cert file
|
|
certFile := filepath.Join(dir, domain+".pem")
|
|
err := os.WriteFile(certFile, []byte("cert content"), 0644)
|
|
require.NoError(t, err)
|
|
|
|
assert.False(t, CertsExist(domain, SSLOptions{Dir: dir}))
|
|
})
|
|
|
|
t.Run("returns false when neither exists", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
domain := "myapp.test"
|
|
|
|
assert.False(t, CertsExist(domain, SSLOptions{Dir: dir}))
|
|
})
|
|
|
|
t.Run("returns false for invalid directory", func(t *testing.T) {
|
|
// Use invalid directory path
|
|
assert.False(t, CertsExist("domain.test", SSLOptions{Dir: "/nonexistent/path/that/does/not/exist"}))
|
|
})
|
|
}
|
|
|
|
func TestSetupSSL_Bad(t *testing.T) {
|
|
t.Run("returns error when mkcert not installed", func(t *testing.T) {
|
|
// This test assumes mkcert might not be installed
|
|
// If it is installed, we skip this test
|
|
if IsMkcertInstalled() {
|
|
t.Skip("mkcert is installed, skipping error test")
|
|
}
|
|
|
|
err := SetupSSL("example.test", SSLOptions{})
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "mkcert is not installed")
|
|
})
|
|
}
|
|
|
|
func TestSetupSSLIfNeeded_Good(t *testing.T) {
|
|
t.Run("returns existing certs without regenerating", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
domain := "existing.test"
|
|
|
|
// Create existing cert files
|
|
certFile := filepath.Join(dir, domain+".pem")
|
|
keyFile := filepath.Join(dir, domain+"-key.pem")
|
|
|
|
err := os.WriteFile(certFile, []byte("existing cert"), 0644)
|
|
require.NoError(t, err)
|
|
err = os.WriteFile(keyFile, []byte("existing key"), 0644)
|
|
require.NoError(t, err)
|
|
|
|
resultCert, resultKey, err := SetupSSLIfNeeded(domain, SSLOptions{Dir: dir})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, certFile, resultCert)
|
|
assert.Equal(t, keyFile, resultKey)
|
|
|
|
// Verify files weren't modified
|
|
data, err := os.ReadFile(certFile)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "existing cert", string(data))
|
|
})
|
|
}
|
|
|
|
func TestIsMkcertInstalled_Good(t *testing.T) {
|
|
// This test just verifies the function runs without error
|
|
// The actual result depends on whether mkcert is installed
|
|
result := IsMkcertInstalled()
|
|
t.Logf("mkcert installed: %v", result)
|
|
}
|
|
|
|
func TestDefaultSSLDir_Good(t *testing.T) {
|
|
t.Run("constant has expected value", func(t *testing.T) {
|
|
assert.Equal(t, ".core/ssl", DefaultSSLDir)
|
|
})
|
|
}
|