* refactor(core): decompose Core into serviceManager + messageBus (#215) Extract two focused, unexported components from the Core "god object": - serviceManager: owns service registry, lifecycle tracking (startables/ stoppables), and service lock - messageBus: owns IPC action dispatch, query handling, and task handling All public API methods on Core become one-line delegation wrappers. Zero consumer changes — no files outside pkg/framework/core/ modified. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(core): remove unused fields from test struct Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(core): address review feedback from Gemini and Copilot - Move locked check inside mutex in registerService to fix TOCTOU race - Add mutex guards to enableLock and applyLock methods - Replace fmt.Errorf with errors.Join in action() for correct error aggregation (consistent with queryAll and lifecycle methods) - Add TestMessageBus_Action_Bad for error aggregation coverage Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci(workflows): bump host-uk/build from v3 to v4 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci(workflows): replace Wails build with Go CLI build The build action doesn't yet support Wails v3. Comment out the GUI build step and use host-uk/build/actions/setup/go for Go toolchain setup with a plain `go build` for the CLI binary. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(container): check context before select in Stop to fix flaky test Stop() now checks ctx.Err() before entering the select block. When a pre-cancelled context is passed, the select could non-deterministically choose <-done over <-ctx.Done() if the process had already exited, causing TestLinuxKitManager_Stop_Good_ContextCancelled to fail on CI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(ci): trim CodeQL matrix to valid languages Remove javascript-typescript and actions from CodeQL matrix — this repo contains only Go and Python. Invalid languages blocked SARIF upload and prevented merge. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(go): add `core go fuzz` command and wire into QA - New `core go fuzz` command discovers Fuzz* targets and runs them with configurable --duration (default 10s per target) - Fuzz added to default QA checks with 5s burst duration - Seed fuzz targets for core package: FuzzE (error constructor), FuzzServiceRegistration, FuzzMessageDispatch Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci(codeql): add workflow_dispatch trigger for manual runs Allows manual triggering of CodeQL when the automatic pull_request trigger doesn't fire. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci(codeql): remove workflow in favour of default setup CodeQL default setup is now enabled via repo settings for go and python. The workflow-based approach uploaded results as "code quality" rather than "code scanning", which didn't satisfy the code_scanning ruleset requirement. Default setup handles this natively. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci(workflows): add explicit permissions to all workflows - agent-verify: add issues: write (was missing, writes comments/labels) - ci: add contents: read (explicit least-privilege) - coverage: add contents: read (explicit least-privilege) All workflows now declare permissions explicitly. Repo default is read-only, so workflows without a block silently lacked write access. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci(workflows): replace inline logic with org reusable workflow callers agent-verify.yml and auto-project.yml now delegate to centralised reusable workflows in host-uk/.github, reducing per-repo duplication. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
107 lines
3.6 KiB
Go
107 lines
3.6 KiB
Go
package core
|
|
|
|
import (
|
|
"context"
|
|
"embed"
|
|
)
|
|
|
|
// This file defines the public API contracts (interfaces) for the services
|
|
// in the Core framework. Services depend on these interfaces, not on
|
|
// concrete implementations.
|
|
|
|
// Contract specifies the operational guarantees that the Core and its services must adhere to.
|
|
// This is used for configuring panic handling and other resilience features.
|
|
type Contract struct {
|
|
// DontPanic, if true, instructs the Core to recover from panics and return an error instead.
|
|
DontPanic bool
|
|
// DisableLogging, if true, disables all logging from the Core and its services.
|
|
DisableLogging bool
|
|
}
|
|
|
|
// Features provides a way to check if a feature is enabled.
|
|
// This is used for feature flagging and conditional logic.
|
|
type Features struct {
|
|
// Flags is a list of enabled feature flags.
|
|
Flags []string
|
|
}
|
|
|
|
// IsEnabled returns true if the given feature is enabled.
|
|
func (f *Features) IsEnabled(feature string) bool {
|
|
for _, flag := range f.Flags {
|
|
if flag == feature {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// Option is a function that configures the Core.
|
|
// This is used to apply settings and register services during initialization.
|
|
type Option func(*Core) error
|
|
|
|
// Message is the interface for all messages that can be sent through the Core's IPC system.
|
|
// Any struct can be a message, allowing for structured data to be passed between services.
|
|
// Used with ACTION for fire-and-forget broadcasts.
|
|
type Message interface{}
|
|
|
|
// Query is the interface for read-only requests that return data.
|
|
// Used with QUERY (first responder) or QUERYALL (all responders).
|
|
type Query interface{}
|
|
|
|
// Task is the interface for requests that perform side effects.
|
|
// Used with PERFORM (first responder executes).
|
|
type Task interface{}
|
|
|
|
// QueryHandler handles Query requests. Returns (result, handled, error).
|
|
// If handled is false, the query will be passed to the next handler.
|
|
type QueryHandler func(*Core, Query) (any, bool, error)
|
|
|
|
// TaskHandler handles Task requests. Returns (result, handled, error).
|
|
// If handled is false, the task will be passed to the next handler.
|
|
type TaskHandler func(*Core, Task) (any, bool, error)
|
|
|
|
// Startable is an interface for services that need to perform initialization.
|
|
type Startable interface {
|
|
OnStartup(ctx context.Context) error
|
|
}
|
|
|
|
// Stoppable is an interface for services that need to perform cleanup.
|
|
type Stoppable interface {
|
|
OnShutdown(ctx context.Context) error
|
|
}
|
|
|
|
// Core is the central application object that manages services, assets, and communication.
|
|
type Core struct {
|
|
App any // GUI runtime (e.g., Wails App) - set by WithApp option
|
|
assets embed.FS
|
|
Features *Features
|
|
svc *serviceManager
|
|
bus *messageBus
|
|
}
|
|
|
|
// Config provides access to application configuration.
|
|
type Config interface {
|
|
// Get retrieves a configuration value by key and stores it in the 'out' variable.
|
|
Get(key string, out any) error
|
|
// Set stores a configuration value by key.
|
|
Set(key string, v any) error
|
|
}
|
|
|
|
// WindowOption is an interface for applying configuration options to a window.
|
|
type WindowOption interface {
|
|
Apply(any)
|
|
}
|
|
|
|
// Display provides access to windowing and visual elements.
|
|
type Display interface {
|
|
// OpenWindow creates a new window with the given options.
|
|
OpenWindow(opts ...WindowOption) error
|
|
}
|
|
|
|
// ActionServiceStartup is a message sent when the application's services are starting up.
|
|
// This provides a hook for services to perform initialization tasks.
|
|
type ActionServiceStartup struct{}
|
|
|
|
// ActionServiceShutdown is a message sent when the application is shutting down.
|
|
// This allows services to perform cleanup tasks, such as saving state or closing resources.
|
|
type ActionServiceShutdown struct{}
|