* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
152 lines
3.9 KiB
Go
152 lines
3.9 KiB
Go
// github_labels.go implements GitHub label synchronization.
|
|
//
|
|
// Uses the gh CLI for label operations:
|
|
// - gh label list --repo {repo} --json name,color,description
|
|
// - gh label create --repo {repo} {name} --color {color} --description {desc}
|
|
// - gh label edit --repo {repo} {name} --color {color} --description {desc}
|
|
|
|
package setup
|
|
|
|
import (
|
|
"encoding/json"
|
|
"os/exec"
|
|
"strings"
|
|
|
|
"github.com/host-uk/core/pkg/cli"
|
|
)
|
|
|
|
// GitHubLabel represents a label as returned by the GitHub API.
|
|
type GitHubLabel struct {
|
|
Name string `json:"name"`
|
|
Color string `json:"color"`
|
|
Description string `json:"description"`
|
|
}
|
|
|
|
// ListLabels fetches all labels for a repository.
|
|
func ListLabels(repoFullName string) ([]GitHubLabel, error) {
|
|
args := []string{
|
|
"label", "list",
|
|
"--repo", repoFullName,
|
|
"--json", "name,color,description",
|
|
"--limit", "200",
|
|
}
|
|
|
|
cmd := exec.Command("gh", args...)
|
|
output, err := cmd.Output()
|
|
if err != nil {
|
|
if exitErr, ok := err.(*exec.ExitError); ok {
|
|
return nil, cli.Err("%s", strings.TrimSpace(string(exitErr.Stderr)))
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
var labels []GitHubLabel
|
|
if err := json.Unmarshal(output, &labels); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return labels, nil
|
|
}
|
|
|
|
// CreateLabel creates a new label in a repository.
|
|
func CreateLabel(repoFullName string, label LabelConfig) error {
|
|
args := []string{
|
|
"label", "create",
|
|
"--repo", repoFullName,
|
|
label.Name,
|
|
"--color", label.Color,
|
|
}
|
|
|
|
if label.Description != "" {
|
|
args = append(args, "--description", label.Description)
|
|
}
|
|
|
|
cmd := exec.Command("gh", args...)
|
|
output, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
return cli.Err("%s", strings.TrimSpace(string(output)))
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// EditLabel updates an existing label in a repository.
|
|
func EditLabel(repoFullName string, label LabelConfig) error {
|
|
args := []string{
|
|
"label", "edit",
|
|
"--repo", repoFullName,
|
|
label.Name,
|
|
"--color", label.Color,
|
|
}
|
|
|
|
if label.Description != "" {
|
|
args = append(args, "--description", label.Description)
|
|
}
|
|
|
|
cmd := exec.Command("gh", args...)
|
|
output, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
return cli.Err("%s", strings.TrimSpace(string(output)))
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// SyncLabels synchronizes labels for a repository.
|
|
// Returns a ChangeSet describing what was changed (or would be changed in dry-run mode).
|
|
func SyncLabels(repoFullName string, config *GitHubConfig, dryRun bool) (*ChangeSet, error) {
|
|
changes := NewChangeSet(repoFullName)
|
|
|
|
// Get existing labels
|
|
existing, err := ListLabels(repoFullName)
|
|
if err != nil {
|
|
return nil, cli.Wrap(err, "failed to list labels")
|
|
}
|
|
|
|
// Build lookup map
|
|
existingMap := make(map[string]GitHubLabel)
|
|
for _, label := range existing {
|
|
existingMap[strings.ToLower(label.Name)] = label
|
|
}
|
|
|
|
// Process each configured label
|
|
for _, wantLabel := range config.Labels {
|
|
key := strings.ToLower(wantLabel.Name)
|
|
existing, exists := existingMap[key]
|
|
|
|
if !exists {
|
|
// Create new label
|
|
changes.Add(CategoryLabel, ChangeCreate, wantLabel.Name, wantLabel.Description)
|
|
if !dryRun {
|
|
if err := CreateLabel(repoFullName, wantLabel); err != nil {
|
|
return changes, cli.Wrap(err, "failed to create label "+wantLabel.Name)
|
|
}
|
|
}
|
|
continue
|
|
}
|
|
|
|
// Check if update is needed
|
|
needsUpdate := false
|
|
details := make(map[string]string)
|
|
|
|
if !strings.EqualFold(existing.Color, wantLabel.Color) {
|
|
needsUpdate = true
|
|
details["color"] = existing.Color + " -> " + wantLabel.Color
|
|
}
|
|
if existing.Description != wantLabel.Description {
|
|
needsUpdate = true
|
|
details["description"] = "updated"
|
|
}
|
|
|
|
if needsUpdate {
|
|
changes.AddWithDetails(CategoryLabel, ChangeUpdate, wantLabel.Name, "", details)
|
|
if !dryRun {
|
|
if err := EditLabel(repoFullName, wantLabel); err != nil {
|
|
return changes, cli.Wrap(err, "failed to update label "+wantLabel.Name)
|
|
}
|
|
}
|
|
} else {
|
|
changes.Add(CategoryLabel, ChangeSkip, wantLabel.Name, "up to date")
|
|
}
|
|
}
|
|
|
|
return changes, nil
|
|
}
|