32f1d0ab5d
* feat: Add TDD tests for core package Adds a new `tdd/` directory for TDD-style contract tests. Implements a comprehensive test suite for the `pkg/core` package, covering: - `New()` - `WithService()` - `WithName()` - `WithWails()` - `WithAssets()` - `WithServiceLock()` - `RegisterService()` - `Service()` - `ServiceFor()` - `MustServiceFor()` - `ACTION()` - `RegisterAction()` - `RegisterActions()` To support testing, a public `Assets()` method was added to the `Core` struct. * feat: Add TDD tests for e, io, runtime, and config packages Adds comprehensive TDD tests to the `tdd/` directory for the following packages: - `pkg/e` - `pkg/io` - `pkg/runtime` - `pkg/config` This significantly improves the test coverage of the project. To support testing the `runtime` package, the `newWithFactories` function was exported as `NewWithFactories`. The existing tests for the `config` package were moved from the `internal` package to the `tdd/` directory and adapted to use the public API. * fix: Update tdd tests for config, core, and runtime Updates the TDD tests for the `config`, `core`, and `runtime` packages to improve their coverage and correctness. - In `tdd/config_test.go`, the `TestIsFeatureEnabled` test is updated to use `s.Set` to modify the `features` slice, ensuring that the persistence logic is exercised. - In `tdd/core_test.go`, the `TestCore_WithAssets_Good` test is updated to use a real embedded filesystem with `//go:embed` to verify the contents of a test file. - In `tdd/runtime_test.go`, the `TestNew_Good` test is converted to a table-driven test to cover the happy path, error cases, and a case with a non-nil `application.App`. * fix: Fix build and improve test coverage This commit fixes a build failure in the `pkg/runtime` tests and significantly improves the test coverage for several packages. - Fixes a build failure in `pkg/runtime/runtime_test.go` by updating a call to an exported function. - Moves TDD tests for `config` and `e` packages into their respective package directories to ensure accurate coverage reporting. - Adds a new test suite for the `pkg/i18n` package, including a test helper to inject a mock i18n bundle. - Moves and updates tests for the `pkg/crypt` package to use its public API. - The coverage for `config` and `e` is now 100%. - The coverage for `crypt` and `i18n` has been significantly improved. --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
114 lines
3.8 KiB
Go
114 lines
3.8 KiB
Go
package tdd
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/Snider/Core/pkg/config"
|
|
"github.com/Snider/Core/pkg/crypt"
|
|
"github.com/Snider/Core/pkg/display"
|
|
"github.com/Snider/Core/pkg/help"
|
|
"github.com/Snider/Core/pkg/i18n"
|
|
"github.com/Snider/Core/pkg/runtime"
|
|
"github.com/Snider/Core/pkg/workspace"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/wailsapp/wails/v3/pkg/application"
|
|
)
|
|
|
|
func TestNew(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
app *application.App
|
|
factories map[string]runtime.ServiceFactory
|
|
expectErr bool
|
|
expectErrStr string
|
|
checkRuntime func(*testing.T, *runtime.Runtime)
|
|
}{
|
|
{
|
|
name: "Good path",
|
|
app: nil,
|
|
factories: map[string]runtime.ServiceFactory{
|
|
"config": func() (any, error) { return &config.Service{}, nil },
|
|
"display": func() (any, error) { return &display.Service{}, nil },
|
|
"help": func() (any, error) { return &help.Service{}, nil },
|
|
"crypt": func() (any, error) { return &crypt.Service{}, nil },
|
|
"i18n": func() (any, error) { return &i18n.Service{}, nil },
|
|
"workspace": func() (any, error) { return &workspace.Service{}, nil },
|
|
},
|
|
expectErr: false,
|
|
checkRuntime: func(t *testing.T, rt *runtime.Runtime) {
|
|
assert.NotNil(t, rt)
|
|
assert.NotNil(t, rt.Core)
|
|
assert.NotNil(t, rt.Config)
|
|
assert.NotNil(t, rt.Display)
|
|
assert.NotNil(t, rt.Help)
|
|
assert.NotNil(t, rt.Crypt)
|
|
assert.NotNil(t, rt.I18n)
|
|
assert.NotNil(t, rt.Workspace)
|
|
},
|
|
},
|
|
{
|
|
name: "Factory returns an error",
|
|
app: nil,
|
|
factories: map[string]runtime.ServiceFactory{
|
|
"config": func() (any, error) { return &config.Service{}, nil },
|
|
"display": func() (any, error) { return &display.Service{}, nil },
|
|
"help": func() (any, error) { return &help.Service{}, nil },
|
|
"crypt": func() (any, error) { return nil, errors.New("crypt service failed") },
|
|
"i18n": func() (any, error) { return &i18n.Service{}, nil },
|
|
"workspace": func() (any, error) { return &workspace.Service{}, nil },
|
|
},
|
|
expectErr: true,
|
|
expectErrStr: "failed to create service crypt: crypt service failed",
|
|
},
|
|
{
|
|
name: "Factory returns wrong type",
|
|
app: nil,
|
|
factories: map[string]runtime.ServiceFactory{
|
|
"config": func() (any, error) { return &config.Service{}, nil },
|
|
"display": func() (any, error) { return "not a display service", nil },
|
|
"help": func() (any, error) { return &help.Service{}, nil },
|
|
"crypt": func() (any, error) { return &crypt.Service{}, nil },
|
|
"i18n": func() (any, error) { return &i18n.Service{}, nil },
|
|
"workspace": func() (any, error) { return &workspace.Service{}, nil },
|
|
},
|
|
expectErr: true,
|
|
expectErrStr: "display service has unexpected type",
|
|
},
|
|
{
|
|
name: "With non-nil app",
|
|
app: &application.App{},
|
|
factories: map[string]runtime.ServiceFactory{
|
|
"config": func() (any, error) { return &config.Service{}, nil },
|
|
"display": func() (any, error) { return &display.Service{}, nil },
|
|
"help": func() (any, error) { return &help.Service{}, nil },
|
|
"crypt": func() (any, error) { return &crypt.Service{}, nil },
|
|
"i18n": func() (any, error) { return &i18n.Service{}, nil },
|
|
"workspace": func() (any, error) { return &workspace.Service{}, nil },
|
|
},
|
|
expectErr: false,
|
|
checkRuntime: func(t *testing.T, rt *runtime.Runtime) {
|
|
assert.NotNil(t, rt)
|
|
assert.NotNil(t, rt.Core)
|
|
assert.NotNil(t, rt.Core.App)
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
rt, err := runtime.NewWithFactories(tc.app, tc.factories)
|
|
|
|
if tc.expectErr {
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), tc.expectErrStr)
|
|
assert.Nil(t, rt)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
if tc.checkRuntime != nil {
|
|
tc.checkRuntime(t, rt)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|