f47e8211fb
* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
77 lines
1.5 KiB
Go
77 lines
1.5 KiB
Go
package sdk
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestSDK_Good_SetVersion(t *testing.T) {
|
|
s := New("/tmp", nil)
|
|
s.SetVersion("v1.2.3")
|
|
|
|
assert.Equal(t, "v1.2.3", s.version)
|
|
}
|
|
|
|
func TestSDK_Good_VersionPassedToGenerator(t *testing.T) {
|
|
config := &Config{
|
|
Languages: []string{"typescript"},
|
|
Output: "sdk",
|
|
Package: PackageConfig{
|
|
Name: "test-sdk",
|
|
},
|
|
}
|
|
s := New("/tmp", config)
|
|
s.SetVersion("v2.0.0")
|
|
|
|
assert.Equal(t, "v2.0.0", s.config.Package.Version)
|
|
}
|
|
|
|
func TestDefaultConfig(t *testing.T) {
|
|
cfg := DefaultConfig()
|
|
assert.Contains(t, cfg.Languages, "typescript")
|
|
assert.Equal(t, "sdk", cfg.Output)
|
|
assert.True(t, cfg.Diff.Enabled)
|
|
}
|
|
|
|
func TestSDK_New(t *testing.T) {
|
|
t.Run("with nil config", func(t *testing.T) {
|
|
s := New("/tmp", nil)
|
|
assert.NotNil(t, s.config)
|
|
assert.Equal(t, "sdk", s.config.Output)
|
|
})
|
|
|
|
t.Run("with custom config", func(t *testing.T) {
|
|
cfg := &Config{Output: "custom"}
|
|
s := New("/tmp", cfg)
|
|
assert.Equal(t, "custom", s.config.Output)
|
|
})
|
|
}
|
|
|
|
func TestSDK_GenerateLanguage_Bad(t *testing.T) {
|
|
|
|
t.Run("unknown language", func(t *testing.T) {
|
|
|
|
tmpDir := t.TempDir()
|
|
|
|
specPath := filepath.Join(tmpDir, "openapi.yaml")
|
|
|
|
err := os.WriteFile(specPath, []byte("openapi: 3.0.0"), 0644)
|
|
|
|
require.NoError(t, err)
|
|
|
|
s := New(tmpDir, nil)
|
|
|
|
err = s.GenerateLanguage(context.Background(), "invalid-lang")
|
|
|
|
assert.Error(t, err)
|
|
|
|
assert.Contains(t, err.Error(), "unknown language")
|
|
|
|
})
|
|
|
|
}
|