* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
123 lines
3.5 KiB
Go
123 lines
3.5 KiB
Go
// cmd_updates.go implements task update and completion commands.
|
|
|
|
package ai
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/host-uk/core/pkg/agentic"
|
|
"github.com/host-uk/core/pkg/cli"
|
|
"github.com/host-uk/core/pkg/i18n"
|
|
)
|
|
|
|
// task:update command flags
|
|
var (
|
|
taskUpdateStatus string
|
|
taskUpdateProgress int
|
|
taskUpdateNotes string
|
|
)
|
|
|
|
// task:complete command flags
|
|
var (
|
|
taskCompleteOutput string
|
|
taskCompleteFailed bool
|
|
taskCompleteErrorMsg string
|
|
)
|
|
|
|
var taskUpdateCmd = &cli.Command{
|
|
Use: "task:update [task-id]",
|
|
Short: i18n.T("cmd.ai.task_update.short"),
|
|
Long: i18n.T("cmd.ai.task_update.long"),
|
|
Args: cli.ExactArgs(1),
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
taskID := args[0]
|
|
|
|
if taskUpdateStatus == "" && taskUpdateProgress == 0 && taskUpdateNotes == "" {
|
|
return cli.Err("%s", i18n.T("cmd.ai.task_update.flag_required"))
|
|
}
|
|
|
|
cfg, err := agentic.LoadConfig("")
|
|
if err != nil {
|
|
return cli.WrapVerb(err, "load", "config")
|
|
}
|
|
|
|
client := agentic.NewClientFromConfig(cfg)
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
|
|
update := agentic.TaskUpdate{
|
|
Progress: taskUpdateProgress,
|
|
Notes: taskUpdateNotes,
|
|
}
|
|
if taskUpdateStatus != "" {
|
|
update.Status = agentic.TaskStatus(taskUpdateStatus)
|
|
}
|
|
|
|
if err := client.UpdateTask(ctx, taskID, update); err != nil {
|
|
return cli.WrapVerb(err, "update", "task")
|
|
}
|
|
|
|
cli.Print("%s %s\n", successStyle.Render(">>"), i18n.T("i18n.done.update", "task"))
|
|
return nil
|
|
},
|
|
}
|
|
|
|
var taskCompleteCmd = &cli.Command{
|
|
Use: "task:complete [task-id]",
|
|
Short: i18n.T("cmd.ai.task_complete.short"),
|
|
Long: i18n.T("cmd.ai.task_complete.long"),
|
|
Args: cli.ExactArgs(1),
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
taskID := args[0]
|
|
|
|
cfg, err := agentic.LoadConfig("")
|
|
if err != nil {
|
|
return cli.WrapVerb(err, "load", "config")
|
|
}
|
|
|
|
client := agentic.NewClientFromConfig(cfg)
|
|
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
|
|
result := agentic.TaskResult{
|
|
Success: !taskCompleteFailed,
|
|
Output: taskCompleteOutput,
|
|
ErrorMessage: taskCompleteErrorMsg,
|
|
}
|
|
|
|
if err := client.CompleteTask(ctx, taskID, result); err != nil {
|
|
return cli.WrapVerb(err, "complete", "task")
|
|
}
|
|
|
|
if taskCompleteFailed {
|
|
cli.Print("%s %s\n", errorStyle.Render(">>"), i18n.T("cmd.ai.task_complete.failed", map[string]interface{}{"ID": taskID}))
|
|
} else {
|
|
cli.Print("%s %s\n", successStyle.Render(">>"), i18n.T("i18n.done.complete", "task"))
|
|
}
|
|
return nil
|
|
},
|
|
}
|
|
|
|
func initUpdatesFlags() {
|
|
// task:update command flags
|
|
taskUpdateCmd.Flags().StringVar(&taskUpdateStatus, "status", "", i18n.T("cmd.ai.task_update.flag.status"))
|
|
taskUpdateCmd.Flags().IntVar(&taskUpdateProgress, "progress", 0, i18n.T("cmd.ai.task_update.flag.progress"))
|
|
taskUpdateCmd.Flags().StringVar(&taskUpdateNotes, "notes", "", i18n.T("cmd.ai.task_update.flag.notes"))
|
|
|
|
// task:complete command flags
|
|
taskCompleteCmd.Flags().StringVar(&taskCompleteOutput, "output", "", i18n.T("cmd.ai.task_complete.flag.output"))
|
|
taskCompleteCmd.Flags().BoolVar(&taskCompleteFailed, "failed", false, i18n.T("cmd.ai.task_complete.flag.failed"))
|
|
taskCompleteCmd.Flags().StringVar(&taskCompleteErrorMsg, "error", "", i18n.T("cmd.ai.task_complete.flag.error"))
|
|
}
|
|
|
|
func addTaskUpdateCommand(parent *cli.Command) {
|
|
initUpdatesFlags()
|
|
parent.AddCommand(taskUpdateCmd)
|
|
}
|
|
|
|
func addTaskCompleteCommand(parent *cli.Command) {
|
|
parent.AddCommand(taskCompleteCmd)
|
|
}
|