* feat: add security logging and fix framework regressions This commit implements comprehensive security event logging and resolves critical regressions in the core framework. Security Logging: - Enhanced `pkg/log` with a `Security` level and helper. - Added `log.Username()` to consistently identify the executing user. - Instrumented GitHub CLI auth, Agentic configuration, filesystem sandbox, MCP handlers, and MCP TCP transport with security logs. - Added `SecurityStyle` to the CLI for consistent visual representation of security events. UniFi Security (CodeQL): - Refactored `pkg/unifi` to remove hardcoded `InsecureSkipVerify`, resolving a high-severity alert. - Added a `--verify-tls` flag and configuration option to control TLS verification. - Updated command handlers to support the new verification parameter. Framework Fixes: - Restored original signatures for `MustServiceFor`, `Config()`, and `Display()` in `pkg/framework/core`, which had been corrupted during a merge. - Fixed `pkg/framework/framework.go` and `pkg/framework/core/runtime_pkg.go` to match the restored signatures. - These fixes resolve project-wide compilation errors caused by the signature mismatches. I encountered significant blockers due to a corrupted state of the `dev` branch after a merge, which introduced breaking changes in the core framework's DI system. I had to manually reconcile these signatures with the expected usage across the codebase to restore build stability. * feat(mcp): add RAG tools (query, ingest, collections) Add vector database tools to the MCP server for RAG operations: - rag_query: Search for relevant documentation using semantic similarity - rag_ingest: Ingest files or directories into the vector database - rag_collections: List available collections Uses existing internal/cmd/rag exports (QueryDocs, IngestDirectory, IngestFile) and pkg/rag for Qdrant client access. Default collection is "hostuk-docs" with topK=5 for queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add metrics tools (record, query) Add MCP tools for recording and querying AI/security metrics events. The metrics_record tool writes events to daily JSONL files, and the metrics_query tool provides aggregated statistics by type, repo, and agent. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add 'core mcp serve' command Add CLI command to start the MCP server for AI tool integration. - Create internal/cmd/mcpcmd package with serve subcommand - Support --workspace flag for directory restriction - Handle SIGINT/SIGTERM for clean shutdown - Register in full.go build variant Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(ws): add WebSocket hub package for real-time streaming Add pkg/ws package implementing a hub pattern for WebSocket connections: - Hub manages client connections, broadcasts, and channel subscriptions - Client struct represents connected WebSocket clients - Message types: process_output, process_status, event, error, ping/pong - Channel-based subscription system (subscribe/unsubscribe) - SendProcessOutput and SendProcessStatus for process streaming integration - Full test coverage including concurrency tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add process management and WebSocket MCP tools Add MCP tools for process management: - process_start: Start a new external process - process_stop: Gracefully stop a running process - process_kill: Force kill a process - process_list: List all managed processes - process_output: Get captured process output - process_input: Send input to process stdin Add MCP tools for WebSocket: - ws_start: Start WebSocket server for real-time streaming - ws_info: Get hub statistics (clients, channels) Update Service struct with optional process.Service and ws.Hub fields, new WithProcessService and WithWSHub options, getter methods, and Shutdown method for cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(webview): add browser automation package via Chrome DevTools Protocol Add pkg/webview package for browser automation: - webview.go: Main interface with Connect, Navigate, Click, Type, QuerySelector, Screenshot, Evaluate - cdp.go: Chrome DevTools Protocol WebSocket client implementation - actions.go: DOM action types (Click, Type, Hover, Scroll, etc.) and ActionSequence builder - console.go: Console message capture and filtering with ConsoleWatcher and ExceptionWatcher - angular.go: Angular-specific helpers for router navigation, component access, and Zone.js stability Add MCP tools for webview: - webview_connect/disconnect: Connection management - webview_navigate: Page navigation - webview_click/type/query/wait: DOM interaction - webview_console: Console output capture - webview_eval: JavaScript execution - webview_screenshot: Screenshot capture Add documentation: - docs/mcp/angular-testing.md: Guide for Angular application testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: document new packages and BugSETI application - Update CLAUDE.md with documentation for: - pkg/ws (WebSocket hub for real-time streaming) - pkg/webview (Browser automation via CDP) - pkg/mcp (MCP server tools: process, ws, webview) - BugSETI application overview - Add comprehensive README for BugSETI with: - Installation and configuration guide - Usage workflow documentation - Architecture overview - Contributing guidelines Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(bugseti): add BugSETI system tray app with auto-update BugSETI - Distributed Bug Fixing like SETI@home but for code Features: - System tray app with Wails v3 - GitHub issue fetching with label filters - Issue queue with priority management - AI context seeding via seed-agent-developer skill - Automated PR submission flow - Stats tracking and leaderboard - Cross-platform notifications - Self-updating with stable/beta/nightly channels Includes: - cmd/bugseti: Main application with Angular frontend - internal/bugseti: Core services (fetcher, queue, seeder, submit, config, stats, notify) - internal/bugseti/updater: Auto-update system (checker, downloader, installer) - .github/workflows/bugseti-release.yml: CI/CD for all platforms Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: resolve import cycle and code duplication - Remove pkg/log import from pkg/io/local to break import cycle (pkg/log/rotation.go imports pkg/io, creating circular dependency) - Use stderr logging for security events in sandbox escape detection - Remove unused sync/atomic import from core.go - Fix duplicate LogSecurity function declarations in cli/log.go - Update workspace/service.go Crypt() call to match interface Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: update tests for new function signatures and format code - Update core_test.go: Config(), Display() now panic instead of returning error - Update runtime_pkg_test.go: sr.Config() now panics instead of returning error - Update MustServiceFor tests to use assert.Panics - Format BugSETI, MCP tools, and webview packages with gofmt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Snider <631881+Snider@users.noreply.github.com> Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
290 lines
7.3 KiB
Go
290 lines
7.3 KiB
Go
package mcp
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// TestProcessToolsRegistered_Good verifies that process tools are registered when process service is available.
|
|
func TestProcessToolsRegistered_Good(t *testing.T) {
|
|
// Create a new MCP service without process service - tools should not be registered
|
|
s, err := New()
|
|
if err != nil {
|
|
t.Fatalf("Failed to create service: %v", err)
|
|
}
|
|
|
|
if s.processService != nil {
|
|
t.Error("Process service should be nil by default")
|
|
}
|
|
|
|
if s.server == nil {
|
|
t.Fatal("Server should not be nil")
|
|
}
|
|
}
|
|
|
|
// TestProcessStartInput_Good verifies the ProcessStartInput struct has expected fields.
|
|
func TestProcessStartInput_Good(t *testing.T) {
|
|
input := ProcessStartInput{
|
|
Command: "echo",
|
|
Args: []string{"hello", "world"},
|
|
Dir: "/tmp",
|
|
Env: []string{"FOO=bar"},
|
|
}
|
|
|
|
if input.Command != "echo" {
|
|
t.Errorf("Expected command 'echo', got %q", input.Command)
|
|
}
|
|
if len(input.Args) != 2 {
|
|
t.Errorf("Expected 2 args, got %d", len(input.Args))
|
|
}
|
|
if input.Dir != "/tmp" {
|
|
t.Errorf("Expected dir '/tmp', got %q", input.Dir)
|
|
}
|
|
if len(input.Env) != 1 {
|
|
t.Errorf("Expected 1 env var, got %d", len(input.Env))
|
|
}
|
|
}
|
|
|
|
// TestProcessStartOutput_Good verifies the ProcessStartOutput struct has expected fields.
|
|
func TestProcessStartOutput_Good(t *testing.T) {
|
|
now := time.Now()
|
|
output := ProcessStartOutput{
|
|
ID: "proc-1",
|
|
PID: 12345,
|
|
Command: "echo",
|
|
Args: []string{"hello"},
|
|
StartedAt: now,
|
|
}
|
|
|
|
if output.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", output.ID)
|
|
}
|
|
if output.PID != 12345 {
|
|
t.Errorf("Expected PID 12345, got %d", output.PID)
|
|
}
|
|
if output.Command != "echo" {
|
|
t.Errorf("Expected command 'echo', got %q", output.Command)
|
|
}
|
|
if !output.StartedAt.Equal(now) {
|
|
t.Errorf("Expected StartedAt %v, got %v", now, output.StartedAt)
|
|
}
|
|
}
|
|
|
|
// TestProcessStopInput_Good verifies the ProcessStopInput struct has expected fields.
|
|
func TestProcessStopInput_Good(t *testing.T) {
|
|
input := ProcessStopInput{
|
|
ID: "proc-1",
|
|
}
|
|
|
|
if input.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", input.ID)
|
|
}
|
|
}
|
|
|
|
// TestProcessStopOutput_Good verifies the ProcessStopOutput struct has expected fields.
|
|
func TestProcessStopOutput_Good(t *testing.T) {
|
|
output := ProcessStopOutput{
|
|
ID: "proc-1",
|
|
Success: true,
|
|
Message: "Process stopped",
|
|
}
|
|
|
|
if output.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", output.ID)
|
|
}
|
|
if !output.Success {
|
|
t.Error("Expected Success to be true")
|
|
}
|
|
if output.Message != "Process stopped" {
|
|
t.Errorf("Expected message 'Process stopped', got %q", output.Message)
|
|
}
|
|
}
|
|
|
|
// TestProcessKillInput_Good verifies the ProcessKillInput struct has expected fields.
|
|
func TestProcessKillInput_Good(t *testing.T) {
|
|
input := ProcessKillInput{
|
|
ID: "proc-1",
|
|
}
|
|
|
|
if input.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", input.ID)
|
|
}
|
|
}
|
|
|
|
// TestProcessKillOutput_Good verifies the ProcessKillOutput struct has expected fields.
|
|
func TestProcessKillOutput_Good(t *testing.T) {
|
|
output := ProcessKillOutput{
|
|
ID: "proc-1",
|
|
Success: true,
|
|
Message: "Process killed",
|
|
}
|
|
|
|
if output.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", output.ID)
|
|
}
|
|
if !output.Success {
|
|
t.Error("Expected Success to be true")
|
|
}
|
|
}
|
|
|
|
// TestProcessListInput_Good verifies the ProcessListInput struct has expected fields.
|
|
func TestProcessListInput_Good(t *testing.T) {
|
|
input := ProcessListInput{
|
|
RunningOnly: true,
|
|
}
|
|
|
|
if !input.RunningOnly {
|
|
t.Error("Expected RunningOnly to be true")
|
|
}
|
|
}
|
|
|
|
// TestProcessListInput_Defaults verifies default values.
|
|
func TestProcessListInput_Defaults(t *testing.T) {
|
|
input := ProcessListInput{}
|
|
|
|
if input.RunningOnly {
|
|
t.Error("Expected RunningOnly to default to false")
|
|
}
|
|
}
|
|
|
|
// TestProcessListOutput_Good verifies the ProcessListOutput struct has expected fields.
|
|
func TestProcessListOutput_Good(t *testing.T) {
|
|
now := time.Now()
|
|
output := ProcessListOutput{
|
|
Processes: []ProcessInfo{
|
|
{
|
|
ID: "proc-1",
|
|
Command: "echo",
|
|
Args: []string{"hello"},
|
|
Dir: "/tmp",
|
|
Status: "running",
|
|
PID: 12345,
|
|
ExitCode: 0,
|
|
StartedAt: now,
|
|
Duration: 5 * time.Second,
|
|
},
|
|
},
|
|
Total: 1,
|
|
}
|
|
|
|
if len(output.Processes) != 1 {
|
|
t.Fatalf("Expected 1 process, got %d", len(output.Processes))
|
|
}
|
|
if output.Total != 1 {
|
|
t.Errorf("Expected total 1, got %d", output.Total)
|
|
}
|
|
|
|
proc := output.Processes[0]
|
|
if proc.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", proc.ID)
|
|
}
|
|
if proc.Status != "running" {
|
|
t.Errorf("Expected status 'running', got %q", proc.Status)
|
|
}
|
|
if proc.PID != 12345 {
|
|
t.Errorf("Expected PID 12345, got %d", proc.PID)
|
|
}
|
|
}
|
|
|
|
// TestProcessOutputInput_Good verifies the ProcessOutputInput struct has expected fields.
|
|
func TestProcessOutputInput_Good(t *testing.T) {
|
|
input := ProcessOutputInput{
|
|
ID: "proc-1",
|
|
}
|
|
|
|
if input.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", input.ID)
|
|
}
|
|
}
|
|
|
|
// TestProcessOutputOutput_Good verifies the ProcessOutputOutput struct has expected fields.
|
|
func TestProcessOutputOutput_Good(t *testing.T) {
|
|
output := ProcessOutputOutput{
|
|
ID: "proc-1",
|
|
Output: "hello world\n",
|
|
}
|
|
|
|
if output.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", output.ID)
|
|
}
|
|
if output.Output != "hello world\n" {
|
|
t.Errorf("Expected output 'hello world\\n', got %q", output.Output)
|
|
}
|
|
}
|
|
|
|
// TestProcessInputInput_Good verifies the ProcessInputInput struct has expected fields.
|
|
func TestProcessInputInput_Good(t *testing.T) {
|
|
input := ProcessInputInput{
|
|
ID: "proc-1",
|
|
Input: "test input\n",
|
|
}
|
|
|
|
if input.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", input.ID)
|
|
}
|
|
if input.Input != "test input\n" {
|
|
t.Errorf("Expected input 'test input\\n', got %q", input.Input)
|
|
}
|
|
}
|
|
|
|
// TestProcessInputOutput_Good verifies the ProcessInputOutput struct has expected fields.
|
|
func TestProcessInputOutput_Good(t *testing.T) {
|
|
output := ProcessInputOutput{
|
|
ID: "proc-1",
|
|
Success: true,
|
|
Message: "Input sent",
|
|
}
|
|
|
|
if output.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", output.ID)
|
|
}
|
|
if !output.Success {
|
|
t.Error("Expected Success to be true")
|
|
}
|
|
}
|
|
|
|
// TestProcessInfo_Good verifies the ProcessInfo struct has expected fields.
|
|
func TestProcessInfo_Good(t *testing.T) {
|
|
now := time.Now()
|
|
info := ProcessInfo{
|
|
ID: "proc-1",
|
|
Command: "echo",
|
|
Args: []string{"hello"},
|
|
Dir: "/tmp",
|
|
Status: "exited",
|
|
PID: 12345,
|
|
ExitCode: 0,
|
|
StartedAt: now,
|
|
Duration: 2 * time.Second,
|
|
}
|
|
|
|
if info.ID != "proc-1" {
|
|
t.Errorf("Expected ID 'proc-1', got %q", info.ID)
|
|
}
|
|
if info.Command != "echo" {
|
|
t.Errorf("Expected command 'echo', got %q", info.Command)
|
|
}
|
|
if info.Status != "exited" {
|
|
t.Errorf("Expected status 'exited', got %q", info.Status)
|
|
}
|
|
if info.ExitCode != 0 {
|
|
t.Errorf("Expected exit code 0, got %d", info.ExitCode)
|
|
}
|
|
if info.Duration != 2*time.Second {
|
|
t.Errorf("Expected duration 2s, got %v", info.Duration)
|
|
}
|
|
}
|
|
|
|
// TestWithProcessService_Good verifies the WithProcessService option.
|
|
func TestWithProcessService_Good(t *testing.T) {
|
|
// Note: We can't easily create a real process.Service here without Core,
|
|
// so we just verify the option doesn't panic with nil.
|
|
s, err := New(WithProcessService(nil))
|
|
if err != nil {
|
|
t.Fatalf("Failed to create service: %v", err)
|
|
}
|
|
|
|
if s.processService != nil {
|
|
t.Error("Expected processService to be nil when passed nil")
|
|
}
|
|
}
|