f47e8211fb
* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
100 lines
2.6 KiB
Go
100 lines
2.6 KiB
Go
package php
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestNewFrankenPHPService_Good(t *testing.T) {
|
|
t.Run("default options", func(t *testing.T) {
|
|
dir := "/tmp/test"
|
|
service := NewFrankenPHPService(dir, FrankenPHPOptions{})
|
|
|
|
assert.Equal(t, "FrankenPHP", service.Name())
|
|
assert.Equal(t, 8000, service.port)
|
|
assert.Equal(t, 443, service.httpsPort)
|
|
assert.False(t, service.https)
|
|
})
|
|
|
|
t.Run("custom options", func(t *testing.T) {
|
|
dir := "/tmp/test"
|
|
opts := FrankenPHPOptions{
|
|
Port: 9000,
|
|
HTTPSPort: 8443,
|
|
HTTPS: true,
|
|
CertFile: "cert.pem",
|
|
KeyFile: "key.pem",
|
|
}
|
|
service := NewFrankenPHPService(dir, opts)
|
|
|
|
assert.Equal(t, 9000, service.port)
|
|
assert.Equal(t, 8443, service.httpsPort)
|
|
assert.True(t, service.https)
|
|
assert.Equal(t, "cert.pem", service.certFile)
|
|
assert.Equal(t, "key.pem", service.keyFile)
|
|
})
|
|
}
|
|
|
|
func TestNewViteService_Good(t *testing.T) {
|
|
t.Run("default options", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
service := NewViteService(dir, ViteOptions{})
|
|
|
|
assert.Equal(t, "Vite", service.Name())
|
|
assert.Equal(t, 5173, service.port)
|
|
assert.Equal(t, "npm", service.packageManager) // default when no lock file
|
|
})
|
|
|
|
t.Run("custom package manager", func(t *testing.T) {
|
|
dir := t.TempDir()
|
|
service := NewViteService(dir, ViteOptions{PackageManager: "pnpm"})
|
|
|
|
assert.Equal(t, "pnpm", service.packageManager)
|
|
})
|
|
}
|
|
|
|
func TestNewHorizonService_Good(t *testing.T) {
|
|
service := NewHorizonService("/tmp/test")
|
|
assert.Equal(t, "Horizon", service.Name())
|
|
assert.Equal(t, 0, service.port)
|
|
}
|
|
|
|
func TestNewReverbService_Good(t *testing.T) {
|
|
t.Run("default options", func(t *testing.T) {
|
|
service := NewReverbService("/tmp/test", ReverbOptions{})
|
|
assert.Equal(t, "Reverb", service.Name())
|
|
assert.Equal(t, 8080, service.port)
|
|
})
|
|
|
|
t.Run("custom port", func(t *testing.T) {
|
|
service := NewReverbService("/tmp/test", ReverbOptions{Port: 9090})
|
|
assert.Equal(t, 9090, service.port)
|
|
})
|
|
}
|
|
|
|
func TestNewRedisService_Good(t *testing.T) {
|
|
t.Run("default options", func(t *testing.T) {
|
|
service := NewRedisService("/tmp/test", RedisOptions{})
|
|
assert.Equal(t, "Redis", service.Name())
|
|
assert.Equal(t, 6379, service.port)
|
|
})
|
|
|
|
t.Run("custom config", func(t *testing.T) {
|
|
service := NewRedisService("/tmp/test", RedisOptions{ConfigFile: "redis.conf"})
|
|
assert.Equal(t, "redis.conf", service.configFile)
|
|
})
|
|
}
|
|
|
|
func TestBaseService_Status(t *testing.T) {
|
|
s := &baseService{
|
|
name: "TestService",
|
|
port: 1234,
|
|
running: true,
|
|
}
|
|
|
|
status := s.Status()
|
|
assert.Equal(t, "TestService", status.Name)
|
|
assert.Equal(t, 1234, status.Port)
|
|
assert.True(t, status.Running)
|
|
}
|