552feb9d45
* chore(io): Migrate pkg/build to Medium abstraction - Updated io.Medium interface with Open() and Create() methods to support streaming. - Migrated pkg/build, pkg/build/builders, and pkg/build/signing to use io.Medium. - Added FS field to build.Config and updated build.Builder interface. - Refactored checksum and archive logic to use io.Medium streaming. - Updated pkg/release and pkg/build/buildcmd to use io.Local. - Updated unit tests to match new signatures. * chore(io): Migrate pkg/build to Medium abstraction (fix CI) - Fixed formatting in pkg/build/builders/wails.go. - Fixed TestLoadConfig_Testdata and TestDiscover_Testdata to use absolute paths with io.Local to ensure compatibility with GitHub CI. - Verified that all build and release tests pass. * chore(io): Migrate pkg/build to Medium abstraction (fix CI paths) - Ensured that outputDir and configPath are absolute in runProjectBuild. - Fixed TestLoadConfig_Testdata and TestDiscover_Testdata to use absolute paths correctly. - Verified that all build and release tests pass locally. * chore(io): Migrate pkg/build to Medium abstraction (final fix) - Improved io.Local to handle relative paths relative to CWD when rooted at "/". - This makes io.Local a drop-in replacement for the 'os' package for most use cases. - Ensured absolute paths are used in build logic and tests where appropriate. - Fixed formatting and cleaned up debug prints. * chore(io): address code review and fix CI - Fix MockFile.Read to return io.EOF - Use filepath.Match in TaskfileBuilder for precise globbing - Stream xz data in createTarXzArchive to avoid in-memory string conversion - Fix TestPath_RootFilesystem in local medium tests - Fix formatting in pkg/build/buildcmd/cmd_project.go * chore(io): resolve merge conflicts and final migration of pkg/build - Resolved merge conflicts in pkg/io/io.go, pkg/io/local/client.go, and pkg/release/release.go. - Reconciled io.Medium interface with upstream changes (unifying to fs.File for Open). - Integrated upstream validatePath logic into the local medium. - Completed migration of pkg/build and related packages to io.Medium. - Addressed previous code review feedback on MockMedium and TaskfileBuilder. * chore(io): resolve merge conflicts and finalize migration - Resolved merge conflicts with dev branch. - Unified io.Medium interface (Open returns fs.File, Create returns io.WriteCloser). - Integrated upstream validatePath logic. - Ensured all tests pass across pkg/io, pkg/build, and pkg/release. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
62 lines
1.6 KiB
Go
62 lines
1.6 KiB
Go
package signing
|
|
|
|
import (
|
|
"context"
|
|
"runtime"
|
|
"testing"
|
|
|
|
"github.com/host-uk/core/pkg/io"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestMacOSSigner_Good_Name(t *testing.T) {
|
|
s := NewMacOSSigner(MacOSConfig{Identity: "Developer ID Application: Test"})
|
|
assert.Equal(t, "codesign", s.Name())
|
|
}
|
|
|
|
func TestMacOSSigner_Good_Available(t *testing.T) {
|
|
s := NewMacOSSigner(MacOSConfig{Identity: "Developer ID Application: Test"})
|
|
|
|
if runtime.GOOS == "darwin" {
|
|
// Just verify it doesn't panic
|
|
_ = s.Available()
|
|
} else {
|
|
assert.False(t, s.Available())
|
|
}
|
|
}
|
|
|
|
func TestMacOSSigner_Bad_NoIdentity(t *testing.T) {
|
|
s := NewMacOSSigner(MacOSConfig{})
|
|
assert.False(t, s.Available())
|
|
}
|
|
|
|
func TestMacOSSigner_Sign_Bad(t *testing.T) {
|
|
t.Run("fails when not available", func(t *testing.T) {
|
|
if runtime.GOOS == "darwin" {
|
|
t.Skip("skipping on macOS")
|
|
}
|
|
fs := io.Local
|
|
s := NewMacOSSigner(MacOSConfig{Identity: "test"})
|
|
err := s.Sign(context.Background(), fs, "test")
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "not available")
|
|
})
|
|
}
|
|
|
|
func TestMacOSSigner_Notarize_Bad(t *testing.T) {
|
|
fs := io.Local
|
|
t.Run("fails with missing credentials", func(t *testing.T) {
|
|
s := NewMacOSSigner(MacOSConfig{})
|
|
err := s.Notarize(context.Background(), fs, "test")
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "missing Apple credentials")
|
|
})
|
|
}
|
|
|
|
func TestMacOSSigner_ShouldNotarize(t *testing.T) {
|
|
s := NewMacOSSigner(MacOSConfig{Notarize: true})
|
|
assert.True(t, s.ShouldNotarize())
|
|
|
|
s2 := NewMacOSSigner(MacOSConfig{Notarize: false})
|
|
assert.False(t, s2.ShouldNotarize())
|
|
}
|