* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
93 lines
2.7 KiB
Go
93 lines
2.7 KiB
Go
// cmd_wizard.go implements the interactive package selection wizard.
|
|
package setup
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"sort"
|
|
|
|
"github.com/host-uk/core/pkg/cli"
|
|
"github.com/host-uk/core/pkg/i18n"
|
|
"github.com/host-uk/core/pkg/repos"
|
|
"golang.org/x/term"
|
|
)
|
|
|
|
// isTerminal returns true if stdin is a terminal.
|
|
func isTerminal() bool {
|
|
return term.IsTerminal(int(os.Stdin.Fd()))
|
|
}
|
|
|
|
// promptSetupChoice asks the user whether to setup the working directory or create a package.
|
|
func promptSetupChoice() (string, error) {
|
|
fmt.Println(cli.TitleStyle.Render(i18n.T("cmd.setup.wizard.git_repo_title")))
|
|
fmt.Println(i18n.T("cmd.setup.wizard.what_to_do"))
|
|
|
|
choice, err := cli.Select("Choose action", []string{"setup", "package"})
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return choice, nil
|
|
}
|
|
|
|
// promptProjectName asks the user for a project directory name.
|
|
func promptProjectName(defaultName string) (string, error) {
|
|
fmt.Println(cli.TitleStyle.Render(i18n.T("cmd.setup.wizard.project_name_title")))
|
|
return cli.Prompt(i18n.T("cmd.setup.wizard.project_name_desc"), defaultName)
|
|
}
|
|
|
|
// runPackageWizard presents an interactive multi-select UI for package selection.
|
|
func runPackageWizard(reg *repos.Registry, preselectedTypes []string) ([]string, error) {
|
|
allRepos := reg.List()
|
|
|
|
// Build options
|
|
var options []string
|
|
|
|
// Sort by name
|
|
sort.Slice(allRepos, func(i, j int) bool {
|
|
return allRepos[i].Name < allRepos[j].Name
|
|
})
|
|
|
|
for _, repo := range allRepos {
|
|
if repo.Clone != nil && !*repo.Clone {
|
|
continue
|
|
}
|
|
// Format: name (type)
|
|
label := fmt.Sprintf("%s (%s)", repo.Name, repo.Type)
|
|
options = append(options, label)
|
|
}
|
|
|
|
fmt.Println(cli.TitleStyle.Render(i18n.T("cmd.setup.wizard.package_selection")))
|
|
fmt.Println(i18n.T("cmd.setup.wizard.selection_hint"))
|
|
|
|
selectedLabels, err := cli.MultiSelect(i18n.T("cmd.setup.wizard.select_packages"), options)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Extract names from labels
|
|
var selected []string
|
|
for _, label := range selectedLabels {
|
|
// Basic parsing assuming "name (type)" format
|
|
// Find last space
|
|
var name string
|
|
// Since we constructed it, we know it ends with (type)
|
|
// but repo name might have spaces? Repos usually don't.
|
|
// Let's iterate repos to find match
|
|
for _, repo := range allRepos {
|
|
if label == fmt.Sprintf("%s (%s)", repo.Name, repo.Type) {
|
|
name = repo.Name
|
|
break
|
|
}
|
|
}
|
|
if name != "" {
|
|
selected = append(selected, name)
|
|
}
|
|
}
|
|
return selected, nil
|
|
}
|
|
|
|
// confirmClone asks for confirmation before cloning.
|
|
func confirmClone(count int, target string) (bool, error) {
|
|
confirmed := cli.Confirm(i18n.T("cmd.setup.wizard.confirm_clone", map[string]interface{}{"Count": count, "Target": target}))
|
|
return confirmed, nil
|
|
}
|