cli/internal/bugseti/updater/service.go
Vi 4debdc1449 feat: BugSETI app, WebSocket hub, browser automation, and MCP tools (#336)
* feat: add security logging and fix framework regressions

This commit implements comprehensive security event logging and resolves critical regressions in the core framework.

Security Logging:
- Enhanced `pkg/log` with a `Security` level and helper.
- Added `log.Username()` to consistently identify the executing user.
- Instrumented GitHub CLI auth, Agentic configuration, filesystem sandbox, MCP handlers, and MCP TCP transport with security logs.
- Added `SecurityStyle` to the CLI for consistent visual representation of security events.

UniFi Security (CodeQL):
- Refactored `pkg/unifi` to remove hardcoded `InsecureSkipVerify`, resolving a high-severity alert.
- Added a `--verify-tls` flag and configuration option to control TLS verification.
- Updated command handlers to support the new verification parameter.

Framework Fixes:
- Restored original signatures for `MustServiceFor`, `Config()`, and `Display()` in `pkg/framework/core`, which had been corrupted during a merge.
- Fixed `pkg/framework/framework.go` and `pkg/framework/core/runtime_pkg.go` to match the restored signatures.
- These fixes resolve project-wide compilation errors caused by the signature mismatches.

I encountered significant blockers due to a corrupted state of the `dev` branch after a merge, which introduced breaking changes in the core framework's DI system. I had to manually reconcile these signatures with the expected usage across the codebase to restore build stability.

* feat(mcp): add RAG tools (query, ingest, collections)

Add vector database tools to the MCP server for RAG operations:
- rag_query: Search for relevant documentation using semantic similarity
- rag_ingest: Ingest files or directories into the vector database
- rag_collections: List available collections

Uses existing internal/cmd/rag exports (QueryDocs, IngestDirectory, IngestFile)
and pkg/rag for Qdrant client access. Default collection is "hostuk-docs"
with topK=5 for queries.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(mcp): add metrics tools (record, query)

Add MCP tools for recording and querying AI/security metrics events.
The metrics_record tool writes events to daily JSONL files, and the
metrics_query tool provides aggregated statistics by type, repo, and agent.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: add 'core mcp serve' command

Add CLI command to start the MCP server for AI tool integration.

- Create internal/cmd/mcpcmd package with serve subcommand
- Support --workspace flag for directory restriction
- Handle SIGINT/SIGTERM for clean shutdown
- Register in full.go build variant

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(ws): add WebSocket hub package for real-time streaming

Add pkg/ws package implementing a hub pattern for WebSocket connections:
- Hub manages client connections, broadcasts, and channel subscriptions
- Client struct represents connected WebSocket clients
- Message types: process_output, process_status, event, error, ping/pong
- Channel-based subscription system (subscribe/unsubscribe)
- SendProcessOutput and SendProcessStatus for process streaming integration
- Full test coverage including concurrency tests

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(mcp): add process management and WebSocket MCP tools

Add MCP tools for process management:
- process_start: Start a new external process
- process_stop: Gracefully stop a running process
- process_kill: Force kill a process
- process_list: List all managed processes
- process_output: Get captured process output
- process_input: Send input to process stdin

Add MCP tools for WebSocket:
- ws_start: Start WebSocket server for real-time streaming
- ws_info: Get hub statistics (clients, channels)

Update Service struct with optional process.Service and ws.Hub fields,
new WithProcessService and WithWSHub options, getter methods, and
Shutdown method for cleanup.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(webview): add browser automation package via Chrome DevTools Protocol

Add pkg/webview package for browser automation:
- webview.go: Main interface with Connect, Navigate, Click, Type, QuerySelector, Screenshot, Evaluate
- cdp.go: Chrome DevTools Protocol WebSocket client implementation
- actions.go: DOM action types (Click, Type, Hover, Scroll, etc.) and ActionSequence builder
- console.go: Console message capture and filtering with ConsoleWatcher and ExceptionWatcher
- angular.go: Angular-specific helpers for router navigation, component access, and Zone.js stability

Add MCP tools for webview:
- webview_connect/disconnect: Connection management
- webview_navigate: Page navigation
- webview_click/type/query/wait: DOM interaction
- webview_console: Console output capture
- webview_eval: JavaScript execution
- webview_screenshot: Screenshot capture

Add documentation:
- docs/mcp/angular-testing.md: Guide for Angular application testing

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* docs: document new packages and BugSETI application

- Update CLAUDE.md with documentation for:
  - pkg/ws (WebSocket hub for real-time streaming)
  - pkg/webview (Browser automation via CDP)
  - pkg/mcp (MCP server tools: process, ws, webview)
  - BugSETI application overview
- Add comprehensive README for BugSETI with:
  - Installation and configuration guide
  - Usage workflow documentation
  - Architecture overview
  - Contributing guidelines

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(bugseti): add BugSETI system tray app with auto-update

BugSETI - Distributed Bug Fixing like SETI@home but for code

Features:
- System tray app with Wails v3
- GitHub issue fetching with label filters
- Issue queue with priority management
- AI context seeding via seed-agent-developer skill
- Automated PR submission flow
- Stats tracking and leaderboard
- Cross-platform notifications
- Self-updating with stable/beta/nightly channels

Includes:
- cmd/bugseti: Main application with Angular frontend
- internal/bugseti: Core services (fetcher, queue, seeder, submit, config, stats, notify)
- internal/bugseti/updater: Auto-update system (checker, downloader, installer)
- .github/workflows/bugseti-release.yml: CI/CD for all platforms

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: resolve import cycle and code duplication

- Remove pkg/log import from pkg/io/local to break import cycle
  (pkg/log/rotation.go imports pkg/io, creating circular dependency)
- Use stderr logging for security events in sandbox escape detection
- Remove unused sync/atomic import from core.go
- Fix duplicate LogSecurity function declarations in cli/log.go
- Update workspace/service.go Crypt() call to match interface

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: update tests for new function signatures and format code

- Update core_test.go: Config(), Display() now panic instead of returning error
- Update runtime_pkg_test.go: sr.Config() now panics instead of returning error
- Update MustServiceFor tests to use assert.Panics
- Format BugSETI, MCP tools, and webview packages with gofmt

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Snider <631881+Snider@users.noreply.github.com>
Co-authored-by: Claude <developers@lethean.io>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 17:22:05 +00:00

322 lines
6.9 KiB
Go

// Package updater provides auto-update functionality for BugSETI.
package updater
import (
"context"
"log"
"sync"
"time"
"github.com/host-uk/core/internal/bugseti"
)
// Service provides update functionality and Wails bindings.
type Service struct {
config *bugseti.ConfigService
checker *Checker
downloader *Downloader
installer *Installer
mu sync.RWMutex
lastResult *UpdateCheckResult
pendingUpdate *DownloadResult
// Background check
stopCh chan struct{}
running bool
}
// NewService creates a new update service.
func NewService(config *bugseti.ConfigService) (*Service, error) {
downloader, err := NewDownloader()
if err != nil {
return nil, err
}
installer, err := NewInstaller()
if err != nil {
return nil, err
}
return &Service{
config: config,
checker: NewChecker(),
downloader: downloader,
installer: installer,
}, nil
}
// ServiceName returns the service name for Wails.
func (s *Service) ServiceName() string {
return "UpdateService"
}
// Start begins the background update checker.
func (s *Service) Start() {
s.mu.Lock()
if s.running {
s.mu.Unlock()
return
}
s.running = true
s.stopCh = make(chan struct{})
s.mu.Unlock()
go s.runBackgroundChecker()
}
// Stop stops the background update checker.
func (s *Service) Stop() {
s.mu.Lock()
defer s.mu.Unlock()
if !s.running {
return
}
s.running = false
close(s.stopCh)
}
// runBackgroundChecker runs periodic update checks.
func (s *Service) runBackgroundChecker() {
// Initial check after a short delay
time.Sleep(30 * time.Second)
for {
select {
case <-s.stopCh:
return
default:
}
if s.config.ShouldCheckForUpdates() {
log.Println("Checking for updates...")
_, err := s.CheckForUpdate()
if err != nil {
log.Printf("Update check failed: %v", err)
}
}
// Check interval from config (minimum 1 hour)
interval := time.Duration(s.config.GetUpdateCheckInterval()) * time.Hour
if interval < time.Hour {
interval = time.Hour
}
select {
case <-s.stopCh:
return
case <-time.After(interval):
}
}
}
// GetSettings returns the update settings.
func (s *Service) GetSettings() bugseti.UpdateSettings {
return s.config.GetUpdateSettings()
}
// SetSettings updates the update settings.
func (s *Service) SetSettings(settings bugseti.UpdateSettings) error {
return s.config.SetUpdateSettings(settings)
}
// GetVersionInfo returns the current version information.
func (s *Service) GetVersionInfo() bugseti.VersionInfo {
return bugseti.GetVersionInfo()
}
// GetChannels returns all available update channels.
func (s *Service) GetChannels() []ChannelInfo {
return GetAllChannelInfo()
}
// CheckForUpdate checks if an update is available.
func (s *Service) CheckForUpdate() (*UpdateCheckResult, error) {
currentVersion := bugseti.GetVersion()
channelStr := s.config.GetUpdateChannel()
channel, err := ParseChannel(channelStr)
if err != nil {
channel = ChannelStable
}
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()
result, err := s.checker.CheckForUpdate(ctx, currentVersion, channel)
if err != nil {
return result, err
}
// Update last check time
s.config.SetLastUpdateCheck(time.Now())
// Store result
s.mu.Lock()
s.lastResult = result
s.mu.Unlock()
// If auto-update is enabled and an update is available, download it
if result.Available && s.config.IsAutoUpdateEnabled() {
go s.downloadUpdate(result.Release)
}
return result, nil
}
// GetLastCheckResult returns the last update check result.
func (s *Service) GetLastCheckResult() *UpdateCheckResult {
s.mu.RLock()
defer s.mu.RUnlock()
return s.lastResult
}
// downloadUpdate downloads an update in the background.
func (s *Service) downloadUpdate(release *ReleaseInfo) {
if release == nil {
return
}
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Minute)
defer cancel()
log.Printf("Downloading update %s...", release.Version)
result, err := s.downloader.Download(ctx, release)
if err != nil {
log.Printf("Failed to download update: %v", err)
return
}
log.Printf("Update %s downloaded and staged at %s", release.Version, result.BinaryPath)
s.mu.Lock()
s.pendingUpdate = result
s.mu.Unlock()
}
// DownloadUpdate downloads the latest available update.
func (s *Service) DownloadUpdate() (*DownloadResult, error) {
s.mu.RLock()
lastResult := s.lastResult
s.mu.RUnlock()
if lastResult == nil || !lastResult.Available || lastResult.Release == nil {
// Need to check first
result, err := s.CheckForUpdate()
if err != nil {
return nil, err
}
if !result.Available {
return nil, nil
}
lastResult = result
}
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Minute)
defer cancel()
downloadResult, err := s.downloader.Download(ctx, lastResult.Release)
if err != nil {
return nil, err
}
s.mu.Lock()
s.pendingUpdate = downloadResult
s.mu.Unlock()
return downloadResult, nil
}
// InstallUpdate installs a previously downloaded update.
func (s *Service) InstallUpdate() (*InstallResult, error) {
s.mu.RLock()
pending := s.pendingUpdate
s.mu.RUnlock()
if pending == nil {
// Try to download first
downloadResult, err := s.DownloadUpdate()
if err != nil {
return nil, err
}
if downloadResult == nil {
return &InstallResult{
Success: false,
Error: "No update available",
}, nil
}
pending = downloadResult
}
result, err := s.installer.Install(pending.BinaryPath)
if err != nil {
return result, err
}
// Clear pending update
s.mu.Lock()
s.pendingUpdate = nil
s.mu.Unlock()
return result, nil
}
// InstallAndRestart installs the update and restarts the application.
func (s *Service) InstallAndRestart() error {
result, err := s.InstallUpdate()
if err != nil {
return err
}
if !result.Success {
return nil
}
return s.installer.Restart()
}
// HasPendingUpdate returns true if there's a downloaded update ready to install.
func (s *Service) HasPendingUpdate() bool {
s.mu.RLock()
defer s.mu.RUnlock()
return s.pendingUpdate != nil
}
// GetPendingUpdate returns information about the pending update.
func (s *Service) GetPendingUpdate() *DownloadResult {
s.mu.RLock()
defer s.mu.RUnlock()
return s.pendingUpdate
}
// CancelPendingUpdate cancels and removes the pending update.
func (s *Service) CancelPendingUpdate() error {
s.mu.Lock()
defer s.mu.Unlock()
s.pendingUpdate = nil
return s.downloader.Cleanup()
}
// CanSelfUpdate returns true if the application can update itself.
func (s *Service) CanSelfUpdate() bool {
return CanSelfUpdate()
}
// NeedsElevation returns true if the update requires elevated privileges.
func (s *Service) NeedsElevation() bool {
return NeedsElevation()
}
// Rollback restores the previous version.
func (s *Service) Rollback() error {
return s.installer.Rollback()
}
// CleanupAfterUpdate cleans up backup files after a successful update.
func (s *Service) CleanupAfterUpdate() error {
return s.installer.CleanupBackup()
}