f47e8211fb
* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
40 lines
1 KiB
Makefile
40 lines
1 KiB
Makefile
.PHONY: build dev release-local test coverage
|
|
|
|
BINARY_NAME=updater
|
|
CMD_PATH=./cmd/updater
|
|
|
|
# Default LDFLAGS to empty
|
|
LDFLAGS = ""
|
|
|
|
# If VERSION is set, override LDFLAGS
|
|
ifdef VERSION
|
|
LDFLAGS = -ldflags "-X 'github.com/snider/updater.Version=$(VERSION)'"
|
|
endif
|
|
|
|
.PHONY: generate
|
|
generate:
|
|
@echo "Generating code..."
|
|
@go generate ./...
|
|
|
|
build: generate
|
|
@echo "Building $(BINARY_NAME)..."
|
|
@cd $(CMD_PATH) && go build $(LDFLAGS)
|
|
|
|
dev: build
|
|
@echo "Running $(BINARY_NAME)..."
|
|
@$(CMD_PATH)/$(BINARY_NAME) --check-update
|
|
|
|
release-local:
|
|
@echo "Running local release with GoReleaser..."
|
|
@~/go/bin/goreleaser release --snapshot --clean
|
|
|
|
test:
|
|
@echo "Running tests..."
|
|
@go test ./...
|
|
|
|
coverage:
|
|
@echo "Generating code coverage report..."
|
|
@go test -coverprofile=coverage.out ./...
|
|
@echo "Coverage report generated: coverage.out"
|
|
@echo "To view in browser: go tool cover -html=coverage.out"
|
|
@echo "To upload to Codecov, ensure you have the Codecov CLI installed (e.g., 'go install github.com/codecov/codecov-cli@latest') and run: codecov -f coverage.out"
|