* feat: add security logging and fix framework regressions This commit implements comprehensive security event logging and resolves critical regressions in the core framework. Security Logging: - Enhanced `pkg/log` with a `Security` level and helper. - Added `log.Username()` to consistently identify the executing user. - Instrumented GitHub CLI auth, Agentic configuration, filesystem sandbox, MCP handlers, and MCP TCP transport with security logs. - Added `SecurityStyle` to the CLI for consistent visual representation of security events. UniFi Security (CodeQL): - Refactored `pkg/unifi` to remove hardcoded `InsecureSkipVerify`, resolving a high-severity alert. - Added a `--verify-tls` flag and configuration option to control TLS verification. - Updated command handlers to support the new verification parameter. Framework Fixes: - Restored original signatures for `MustServiceFor`, `Config()`, and `Display()` in `pkg/framework/core`, which had been corrupted during a merge. - Fixed `pkg/framework/framework.go` and `pkg/framework/core/runtime_pkg.go` to match the restored signatures. - These fixes resolve project-wide compilation errors caused by the signature mismatches. I encountered significant blockers due to a corrupted state of the `dev` branch after a merge, which introduced breaking changes in the core framework's DI system. I had to manually reconcile these signatures with the expected usage across the codebase to restore build stability. * feat(mcp): add RAG tools (query, ingest, collections) Add vector database tools to the MCP server for RAG operations: - rag_query: Search for relevant documentation using semantic similarity - rag_ingest: Ingest files or directories into the vector database - rag_collections: List available collections Uses existing internal/cmd/rag exports (QueryDocs, IngestDirectory, IngestFile) and pkg/rag for Qdrant client access. Default collection is "hostuk-docs" with topK=5 for queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add metrics tools (record, query) Add MCP tools for recording and querying AI/security metrics events. The metrics_record tool writes events to daily JSONL files, and the metrics_query tool provides aggregated statistics by type, repo, and agent. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add 'core mcp serve' command Add CLI command to start the MCP server for AI tool integration. - Create internal/cmd/mcpcmd package with serve subcommand - Support --workspace flag for directory restriction - Handle SIGINT/SIGTERM for clean shutdown - Register in full.go build variant Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(ws): add WebSocket hub package for real-time streaming Add pkg/ws package implementing a hub pattern for WebSocket connections: - Hub manages client connections, broadcasts, and channel subscriptions - Client struct represents connected WebSocket clients - Message types: process_output, process_status, event, error, ping/pong - Channel-based subscription system (subscribe/unsubscribe) - SendProcessOutput and SendProcessStatus for process streaming integration - Full test coverage including concurrency tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add process management and WebSocket MCP tools Add MCP tools for process management: - process_start: Start a new external process - process_stop: Gracefully stop a running process - process_kill: Force kill a process - process_list: List all managed processes - process_output: Get captured process output - process_input: Send input to process stdin Add MCP tools for WebSocket: - ws_start: Start WebSocket server for real-time streaming - ws_info: Get hub statistics (clients, channels) Update Service struct with optional process.Service and ws.Hub fields, new WithProcessService and WithWSHub options, getter methods, and Shutdown method for cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(webview): add browser automation package via Chrome DevTools Protocol Add pkg/webview package for browser automation: - webview.go: Main interface with Connect, Navigate, Click, Type, QuerySelector, Screenshot, Evaluate - cdp.go: Chrome DevTools Protocol WebSocket client implementation - actions.go: DOM action types (Click, Type, Hover, Scroll, etc.) and ActionSequence builder - console.go: Console message capture and filtering with ConsoleWatcher and ExceptionWatcher - angular.go: Angular-specific helpers for router navigation, component access, and Zone.js stability Add MCP tools for webview: - webview_connect/disconnect: Connection management - webview_navigate: Page navigation - webview_click/type/query/wait: DOM interaction - webview_console: Console output capture - webview_eval: JavaScript execution - webview_screenshot: Screenshot capture Add documentation: - docs/mcp/angular-testing.md: Guide for Angular application testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: document new packages and BugSETI application - Update CLAUDE.md with documentation for: - pkg/ws (WebSocket hub for real-time streaming) - pkg/webview (Browser automation via CDP) - pkg/mcp (MCP server tools: process, ws, webview) - BugSETI application overview - Add comprehensive README for BugSETI with: - Installation and configuration guide - Usage workflow documentation - Architecture overview - Contributing guidelines Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(bugseti): add BugSETI system tray app with auto-update BugSETI - Distributed Bug Fixing like SETI@home but for code Features: - System tray app with Wails v3 - GitHub issue fetching with label filters - Issue queue with priority management - AI context seeding via seed-agent-developer skill - Automated PR submission flow - Stats tracking and leaderboard - Cross-platform notifications - Self-updating with stable/beta/nightly channels Includes: - cmd/bugseti: Main application with Angular frontend - internal/bugseti: Core services (fetcher, queue, seeder, submit, config, stats, notify) - internal/bugseti/updater: Auto-update system (checker, downloader, installer) - .github/workflows/bugseti-release.yml: CI/CD for all platforms Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: resolve import cycle and code duplication - Remove pkg/log import from pkg/io/local to break import cycle (pkg/log/rotation.go imports pkg/io, creating circular dependency) - Use stderr logging for security events in sandbox escape detection - Remove unused sync/atomic import from core.go - Fix duplicate LogSecurity function declarations in cli/log.go - Update workspace/service.go Crypt() call to match interface Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: update tests for new function signatures and format code - Update core_test.go: Config(), Display() now panic instead of returning error - Update runtime_pkg_test.go: sr.Config() now panics instead of returning error - Update MustServiceFor tests to use assert.Panics - Format BugSETI, MCP tools, and webview packages with gofmt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Snider <631881+Snider@users.noreply.github.com> Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
296 lines
6.9 KiB
Go
296 lines
6.9 KiB
Go
// Package bugseti provides services for the BugSETI distributed bug fixing application.
|
|
package bugseti
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"log"
|
|
"os/exec"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
// FetcherService fetches issues from configured OSS repositories.
|
|
type FetcherService struct {
|
|
config *ConfigService
|
|
notify *NotifyService
|
|
running bool
|
|
mu sync.RWMutex
|
|
stopCh chan struct{}
|
|
issuesCh chan []*Issue
|
|
}
|
|
|
|
// NewFetcherService creates a new FetcherService.
|
|
func NewFetcherService(config *ConfigService, notify *NotifyService) *FetcherService {
|
|
return &FetcherService{
|
|
config: config,
|
|
notify: notify,
|
|
issuesCh: make(chan []*Issue, 10),
|
|
}
|
|
}
|
|
|
|
// ServiceName returns the service name for Wails.
|
|
func (f *FetcherService) ServiceName() string {
|
|
return "FetcherService"
|
|
}
|
|
|
|
// Start begins fetching issues from configured repositories.
|
|
func (f *FetcherService) Start() error {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
|
|
if f.running {
|
|
return nil
|
|
}
|
|
|
|
f.running = true
|
|
f.stopCh = make(chan struct{})
|
|
|
|
go f.fetchLoop()
|
|
log.Println("FetcherService started")
|
|
return nil
|
|
}
|
|
|
|
// Pause stops fetching issues.
|
|
func (f *FetcherService) Pause() {
|
|
f.mu.Lock()
|
|
defer f.mu.Unlock()
|
|
|
|
if !f.running {
|
|
return
|
|
}
|
|
|
|
f.running = false
|
|
close(f.stopCh)
|
|
log.Println("FetcherService paused")
|
|
}
|
|
|
|
// IsRunning returns whether the fetcher is actively running.
|
|
func (f *FetcherService) IsRunning() bool {
|
|
f.mu.RLock()
|
|
defer f.mu.RUnlock()
|
|
return f.running
|
|
}
|
|
|
|
// Issues returns a channel that receives batches of fetched issues.
|
|
func (f *FetcherService) Issues() <-chan []*Issue {
|
|
return f.issuesCh
|
|
}
|
|
|
|
// fetchLoop periodically fetches issues from all configured repositories.
|
|
func (f *FetcherService) fetchLoop() {
|
|
// Initial fetch
|
|
f.fetchAll()
|
|
|
|
// Set up ticker for periodic fetching
|
|
interval := f.config.GetFetchInterval()
|
|
if interval < time.Minute {
|
|
interval = 15 * time.Minute
|
|
}
|
|
ticker := time.NewTicker(interval)
|
|
defer ticker.Stop()
|
|
|
|
for {
|
|
select {
|
|
case <-f.stopCh:
|
|
return
|
|
case <-ticker.C:
|
|
// Check if within work hours
|
|
if f.config.IsWithinWorkHours() {
|
|
f.fetchAll()
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// fetchAll fetches issues from all configured repositories.
|
|
func (f *FetcherService) fetchAll() {
|
|
repos := f.config.GetWatchedRepos()
|
|
if len(repos) == 0 {
|
|
log.Println("No repositories configured")
|
|
return
|
|
}
|
|
|
|
var allIssues []*Issue
|
|
for _, repo := range repos {
|
|
issues, err := f.fetchFromRepo(repo)
|
|
if err != nil {
|
|
log.Printf("Error fetching from %s: %v", repo, err)
|
|
continue
|
|
}
|
|
allIssues = append(allIssues, issues...)
|
|
}
|
|
|
|
if len(allIssues) > 0 {
|
|
select {
|
|
case f.issuesCh <- allIssues:
|
|
f.notify.Notify("BugSETI", fmt.Sprintf("Found %d new issues", len(allIssues)))
|
|
default:
|
|
// Channel full, skip
|
|
}
|
|
}
|
|
}
|
|
|
|
// fetchFromRepo fetches issues from a single repository using GitHub CLI.
|
|
func (f *FetcherService) fetchFromRepo(repo string) ([]*Issue, error) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
|
|
defer cancel()
|
|
|
|
// Build query for good first issues
|
|
labels := f.config.GetLabels()
|
|
if len(labels) == 0 {
|
|
labels = []string{"good first issue", "help wanted", "beginner-friendly"}
|
|
}
|
|
|
|
labelQuery := strings.Join(labels, ",")
|
|
|
|
// Use gh CLI to fetch issues
|
|
cmd := exec.CommandContext(ctx, "gh", "issue", "list",
|
|
"--repo", repo,
|
|
"--label", labelQuery,
|
|
"--state", "open",
|
|
"--limit", "20",
|
|
"--json", "number,title,body,url,labels,createdAt,author")
|
|
|
|
output, err := cmd.Output()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("gh issue list failed: %w", err)
|
|
}
|
|
|
|
var ghIssues []struct {
|
|
Number int `json:"number"`
|
|
Title string `json:"title"`
|
|
Body string `json:"body"`
|
|
URL string `json:"url"`
|
|
CreatedAt time.Time `json:"createdAt"`
|
|
Author struct {
|
|
Login string `json:"login"`
|
|
} `json:"author"`
|
|
Labels []struct {
|
|
Name string `json:"name"`
|
|
} `json:"labels"`
|
|
}
|
|
|
|
if err := json.Unmarshal(output, &ghIssues); err != nil {
|
|
return nil, fmt.Errorf("failed to parse gh output: %w", err)
|
|
}
|
|
|
|
issues := make([]*Issue, 0, len(ghIssues))
|
|
for _, gi := range ghIssues {
|
|
labels := make([]string, len(gi.Labels))
|
|
for i, l := range gi.Labels {
|
|
labels[i] = l.Name
|
|
}
|
|
|
|
issues = append(issues, &Issue{
|
|
ID: fmt.Sprintf("%s#%d", repo, gi.Number),
|
|
Number: gi.Number,
|
|
Repo: repo,
|
|
Title: gi.Title,
|
|
Body: gi.Body,
|
|
URL: gi.URL,
|
|
Labels: labels,
|
|
Author: gi.Author.Login,
|
|
CreatedAt: gi.CreatedAt,
|
|
Priority: calculatePriority(labels),
|
|
})
|
|
}
|
|
|
|
return issues, nil
|
|
}
|
|
|
|
// FetchIssue fetches a single issue by repo and number.
|
|
func (f *FetcherService) FetchIssue(repo string, number int) (*Issue, error) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
|
|
defer cancel()
|
|
|
|
cmd := exec.CommandContext(ctx, "gh", "issue", "view",
|
|
"--repo", repo,
|
|
fmt.Sprintf("%d", number),
|
|
"--json", "number,title,body,url,labels,createdAt,author,comments")
|
|
|
|
output, err := cmd.Output()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("gh issue view failed: %w", err)
|
|
}
|
|
|
|
var ghIssue struct {
|
|
Number int `json:"number"`
|
|
Title string `json:"title"`
|
|
Body string `json:"body"`
|
|
URL string `json:"url"`
|
|
CreatedAt time.Time `json:"createdAt"`
|
|
Author struct {
|
|
Login string `json:"login"`
|
|
} `json:"author"`
|
|
Labels []struct {
|
|
Name string `json:"name"`
|
|
} `json:"labels"`
|
|
Comments []struct {
|
|
Body string `json:"body"`
|
|
Author struct {
|
|
Login string `json:"login"`
|
|
} `json:"author"`
|
|
} `json:"comments"`
|
|
}
|
|
|
|
if err := json.Unmarshal(output, &ghIssue); err != nil {
|
|
return nil, fmt.Errorf("failed to parse gh output: %w", err)
|
|
}
|
|
|
|
labels := make([]string, len(ghIssue.Labels))
|
|
for i, l := range ghIssue.Labels {
|
|
labels[i] = l.Name
|
|
}
|
|
|
|
comments := make([]Comment, len(ghIssue.Comments))
|
|
for i, c := range ghIssue.Comments {
|
|
comments[i] = Comment{
|
|
Author: c.Author.Login,
|
|
Body: c.Body,
|
|
}
|
|
}
|
|
|
|
return &Issue{
|
|
ID: fmt.Sprintf("%s#%d", repo, ghIssue.Number),
|
|
Number: ghIssue.Number,
|
|
Repo: repo,
|
|
Title: ghIssue.Title,
|
|
Body: ghIssue.Body,
|
|
URL: ghIssue.URL,
|
|
Labels: labels,
|
|
Author: ghIssue.Author.Login,
|
|
CreatedAt: ghIssue.CreatedAt,
|
|
Priority: calculatePriority(labels),
|
|
Comments: comments,
|
|
}, nil
|
|
}
|
|
|
|
// calculatePriority assigns a priority score based on labels.
|
|
func calculatePriority(labels []string) int {
|
|
priority := 50 // Default priority
|
|
|
|
for _, label := range labels {
|
|
lower := strings.ToLower(label)
|
|
switch {
|
|
case strings.Contains(lower, "good first issue"):
|
|
priority += 30
|
|
case strings.Contains(lower, "help wanted"):
|
|
priority += 20
|
|
case strings.Contains(lower, "beginner"):
|
|
priority += 25
|
|
case strings.Contains(lower, "easy"):
|
|
priority += 20
|
|
case strings.Contains(lower, "bug"):
|
|
priority += 10
|
|
case strings.Contains(lower, "documentation"):
|
|
priority += 5
|
|
case strings.Contains(lower, "priority"):
|
|
priority += 15
|
|
}
|
|
}
|
|
|
|
return priority
|
|
}
|