* feat(go): make go fmt git-aware by default - By default, only check changed Go files (modified, staged, untracked) - Add --all flag to check all files (previous behaviour) - Reduces noise when running fmt on large codebases Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(build): minimal output by default, add missing i18n - Default output now shows single line: "Success Built N artifacts (dir)" - Add --verbose/-v flag to show full detailed output - Add all missing i18n translations for build commands - Errors still show failure reason in minimal mode Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add root-level `core git` command - Create pkg/gitcmd with git workflow commands as root menu - Export command builders from pkg/dev (AddCommitCommand, etc.) - Commands available under both `core git` and `core dev` for compatibility - Git commands: health, commit, push, pull, work, sync, apply - GitHub orchestration stays in dev: issues, reviews, ci, impact Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(qa): add docblock coverage checking Implement docblock/docstring coverage analysis for Go code: - New `core qa docblock` command to check coverage - Shows compact file:line list when under threshold - Integrate with `core go qa` as a default check - Add --docblock-threshold flag (default 80%) The checker uses Go AST parsing to find exported symbols (functions, types, consts, vars) without documentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - Fix doc comment: "status" → "health" in gitcmd package - Implement --check flag for `core go fmt` (exits non-zero if files need formatting) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: add docstrings for 100% coverage Add documentation comments to all exported symbols: - pkg/build: ProjectType constants - pkg/cli: LogLevel, RenderStyle, TableStyle - pkg/framework: ServiceFor, MustServiceFor, Core.Core - pkg/git: GitError.Error, GitError.Unwrap - pkg/i18n: Handler Match/Handle methods - pkg/log: Level constants - pkg/mcp: Tool input/output types - pkg/php: Service constants, QA types, service methods - pkg/process: ServiceError.Error - pkg/repos: RepoType constants - pkg/setup: ChangeType, ChangeCategory constants - pkg/workspace: AddWorkspaceCommands Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: standardize line endings to LF Add .gitattributes to enforce LF line endings for all text files. Normalize all existing files to use Unix-style line endings. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr - cmd_docblock.go: return error instead of os.Exit(1) for proper error handling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback (round 2) - linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit - mcp.go: guard against empty old_string in editDiff to prevent runaway edits - cmd_docblock.go: log parse errors instead of silently skipping Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
208 lines
5.2 KiB
Go
208 lines
5.2 KiB
Go
package dev
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"os/exec"
|
|
"sort"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/host-uk/core/pkg/cli"
|
|
"github.com/host-uk/core/pkg/i18n"
|
|
)
|
|
|
|
// Issue-specific styles (aliases to shared)
|
|
var (
|
|
issueRepoStyle = cli.DimStyle
|
|
issueNumberStyle = cli.TitleStyle
|
|
issueTitleStyle = cli.ValueStyle
|
|
issueLabelStyle = cli.WarningStyle
|
|
issueAssigneeStyle = cli.SuccessStyle
|
|
issueAgeStyle = cli.DimStyle
|
|
)
|
|
|
|
// GitHubIssue represents a GitHub issue from the API.
|
|
type GitHubIssue struct {
|
|
Number int `json:"number"`
|
|
Title string `json:"title"`
|
|
State string `json:"state"`
|
|
CreatedAt time.Time `json:"createdAt"`
|
|
Author struct {
|
|
Login string `json:"login"`
|
|
} `json:"author"`
|
|
Assignees struct {
|
|
Nodes []struct {
|
|
Login string `json:"login"`
|
|
} `json:"nodes"`
|
|
} `json:"assignees"`
|
|
Labels struct {
|
|
Nodes []struct {
|
|
Name string `json:"name"`
|
|
} `json:"nodes"`
|
|
} `json:"labels"`
|
|
URL string `json:"url"`
|
|
|
|
// Added by us
|
|
RepoName string `json:"-"`
|
|
}
|
|
|
|
// Issues command flags
|
|
var (
|
|
issuesRegistryPath string
|
|
issuesLimit int
|
|
issuesAssignee string
|
|
)
|
|
|
|
// addIssuesCommand adds the 'issues' command to the given parent command.
|
|
func addIssuesCommand(parent *cli.Command) {
|
|
issuesCmd := &cli.Command{
|
|
Use: "issues",
|
|
Short: i18n.T("cmd.dev.issues.short"),
|
|
Long: i18n.T("cmd.dev.issues.long"),
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
limit := issuesLimit
|
|
if limit == 0 {
|
|
limit = 10
|
|
}
|
|
return runIssues(issuesRegistryPath, limit, issuesAssignee)
|
|
},
|
|
}
|
|
|
|
issuesCmd.Flags().StringVar(&issuesRegistryPath, "registry", "", i18n.T("common.flag.registry"))
|
|
issuesCmd.Flags().IntVarP(&issuesLimit, "limit", "l", 10, i18n.T("cmd.dev.issues.flag.limit"))
|
|
issuesCmd.Flags().StringVarP(&issuesAssignee, "assignee", "a", "", i18n.T("cmd.dev.issues.flag.assignee"))
|
|
|
|
parent.AddCommand(issuesCmd)
|
|
}
|
|
|
|
func runIssues(registryPath string, limit int, assignee string) error {
|
|
// Check gh is available
|
|
if _, err := exec.LookPath("gh"); err != nil {
|
|
return errors.New(i18n.T("error.gh_not_found"))
|
|
}
|
|
|
|
// Find or use provided registry
|
|
reg, _, err := loadRegistryWithConfig(registryPath)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Fetch issues sequentially (avoid GitHub rate limits)
|
|
var allIssues []GitHubIssue
|
|
var fetchErrors []error
|
|
|
|
repoList := reg.List()
|
|
for i, repo := range repoList {
|
|
repoFullName := cli.Sprintf("%s/%s", reg.Org, repo.Name)
|
|
cli.Print("\033[2K\r%s %d/%d %s", dimStyle.Render(i18n.T("i18n.progress.fetch")), i+1, len(repoList), repo.Name)
|
|
|
|
issues, err := fetchIssues(repoFullName, repo.Name, limit, assignee)
|
|
if err != nil {
|
|
fetchErrors = append(fetchErrors, cli.Wrap(err, repo.Name))
|
|
continue
|
|
}
|
|
allIssues = append(allIssues, issues...)
|
|
}
|
|
cli.Print("\033[2K\r") // Clear progress line
|
|
|
|
// Sort by created date (newest first)
|
|
sort.Slice(allIssues, func(i, j int) bool {
|
|
return allIssues[i].CreatedAt.After(allIssues[j].CreatedAt)
|
|
})
|
|
|
|
// Print issues
|
|
if len(allIssues) == 0 {
|
|
cli.Text(i18n.T("cmd.dev.issues.no_issues"))
|
|
return nil
|
|
}
|
|
|
|
cli.Print("\n%s\n\n", i18n.T("cmd.dev.issues.open_issues", map[string]interface{}{"Count": len(allIssues)}))
|
|
|
|
for _, issue := range allIssues {
|
|
printIssue(issue)
|
|
}
|
|
|
|
// Print any errors
|
|
if len(fetchErrors) > 0 {
|
|
cli.Blank()
|
|
for _, err := range fetchErrors {
|
|
cli.Print("%s %s\n", errorStyle.Render(i18n.Label("error")), err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func fetchIssues(repoFullName, repoName string, limit int, assignee string) ([]GitHubIssue, error) {
|
|
args := []string{
|
|
"issue", "list",
|
|
"--repo", repoFullName,
|
|
"--state", "open",
|
|
"--limit", cli.Sprintf("%d", limit),
|
|
"--json", "number,title,state,createdAt,author,assignees,labels,url",
|
|
}
|
|
|
|
if assignee != "" {
|
|
args = append(args, "--assignee", assignee)
|
|
}
|
|
|
|
cmd := exec.Command("gh", args...)
|
|
output, err := cmd.Output()
|
|
if err != nil {
|
|
// Check if it's just "no issues" vs actual error
|
|
if exitErr, ok := err.(*exec.ExitError); ok {
|
|
stderr := string(exitErr.Stderr)
|
|
if strings.Contains(stderr, "no issues") || strings.Contains(stderr, "Could not resolve") {
|
|
return nil, nil
|
|
}
|
|
return nil, cli.Err("%s", stderr)
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
var issues []GitHubIssue
|
|
if err := json.Unmarshal(output, &issues); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Tag with repo name
|
|
for i := range issues {
|
|
issues[i].RepoName = repoName
|
|
}
|
|
|
|
return issues, nil
|
|
}
|
|
|
|
func printIssue(issue GitHubIssue) {
|
|
// #42 [core-bio] Fix avatar upload
|
|
num := issueNumberStyle.Render(cli.Sprintf("#%d", issue.Number))
|
|
repo := issueRepoStyle.Render(cli.Sprintf("[%s]", issue.RepoName))
|
|
title := issueTitleStyle.Render(cli.Truncate(issue.Title, 60))
|
|
|
|
line := cli.Sprintf(" %s %s %s", num, repo, title)
|
|
|
|
// Add labels if any
|
|
if len(issue.Labels.Nodes) > 0 {
|
|
var labels []string
|
|
for _, l := range issue.Labels.Nodes {
|
|
labels = append(labels, l.Name)
|
|
}
|
|
line += " " + issueLabelStyle.Render("["+strings.Join(labels, ", ")+"]")
|
|
}
|
|
|
|
// Add assignee if any
|
|
if len(issue.Assignees.Nodes) > 0 {
|
|
var assignees []string
|
|
for _, a := range issue.Assignees.Nodes {
|
|
assignees = append(assignees, "@"+a.Login)
|
|
}
|
|
line += " " + issueAssigneeStyle.Render(strings.Join(assignees, ", "))
|
|
}
|
|
|
|
// Add age
|
|
age := cli.FormatAge(issue.CreatedAt)
|
|
line += " " + issueAgeStyle.Render(age)
|
|
|
|
cli.Text(line)
|
|
}
|