* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
236 lines
5.8 KiB
Go
236 lines
5.8 KiB
Go
package gocmd
|
|
|
|
import (
|
|
"errors"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
|
|
"github.com/host-uk/core/pkg/cli"
|
|
"github.com/host-uk/core/pkg/i18n"
|
|
)
|
|
|
|
var (
|
|
installVerbose bool
|
|
installNoCgo bool
|
|
)
|
|
|
|
func addGoInstallCommand(parent *cli.Command) {
|
|
installCmd := &cli.Command{
|
|
Use: "install [path]",
|
|
Short: "Install Go binary",
|
|
Long: "Install Go binary to $GOPATH/bin",
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
// Get install path from args or default to current dir
|
|
installPath := "./..."
|
|
if len(args) > 0 {
|
|
installPath = args[0]
|
|
}
|
|
|
|
// Detect if we're in a module with cmd/ subdirectories or a root main.go
|
|
if installPath == "./..." {
|
|
if _, err := os.Stat("core.go"); err == nil {
|
|
installPath = "."
|
|
} else if entries, err := os.ReadDir("cmd"); err == nil && len(entries) > 0 {
|
|
installPath = "./cmd/..."
|
|
} else if _, err := os.Stat("main.go"); err == nil {
|
|
installPath = "."
|
|
}
|
|
}
|
|
|
|
cli.Print("%s %s\n", dimStyle.Render(i18n.Label("install")), i18n.Progress("install"))
|
|
cli.Print(" %s %s\n", dimStyle.Render(i18n.Label("path")), installPath)
|
|
if installNoCgo {
|
|
cli.Print(" %s %s\n", dimStyle.Render(i18n.Label("cgo")), "disabled")
|
|
}
|
|
|
|
cmdArgs := []string{"install"}
|
|
if installVerbose {
|
|
cmdArgs = append(cmdArgs, "-v")
|
|
}
|
|
cmdArgs = append(cmdArgs, installPath)
|
|
|
|
execCmd := exec.Command("go", cmdArgs...)
|
|
if installNoCgo {
|
|
execCmd.Env = append(os.Environ(), "CGO_ENABLED=0")
|
|
}
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
|
|
if err := execCmd.Run(); err != nil {
|
|
cli.Print("\n%s\n", errorStyle.Render(i18n.T("i18n.fail.install", "binary")))
|
|
return err
|
|
}
|
|
|
|
// Show where it was installed
|
|
gopath := os.Getenv("GOPATH")
|
|
if gopath == "" {
|
|
home, _ := os.UserHomeDir()
|
|
gopath = filepath.Join(home, "go")
|
|
}
|
|
binDir := filepath.Join(gopath, "bin")
|
|
|
|
cli.Print("\n%s %s\n", successStyle.Render(i18n.T("i18n.done.install")), binDir)
|
|
return nil
|
|
},
|
|
}
|
|
|
|
installCmd.Flags().BoolVarP(&installVerbose, "verbose", "v", false, "Verbose output")
|
|
installCmd.Flags().BoolVar(&installNoCgo, "no-cgo", false, "Disable CGO")
|
|
|
|
parent.AddCommand(installCmd)
|
|
}
|
|
|
|
func addGoModCommand(parent *cli.Command) {
|
|
modCmd := &cli.Command{
|
|
Use: "mod",
|
|
Short: "Module management",
|
|
Long: "Go module management commands",
|
|
}
|
|
|
|
// tidy
|
|
tidyCmd := &cli.Command{
|
|
Use: "tidy",
|
|
Short: "Run go mod tidy",
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
execCmd := exec.Command("go", "mod", "tidy")
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
return execCmd.Run()
|
|
},
|
|
}
|
|
|
|
// download
|
|
downloadCmd := &cli.Command{
|
|
Use: "download",
|
|
Short: "Download module dependencies",
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
execCmd := exec.Command("go", "mod", "download")
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
return execCmd.Run()
|
|
},
|
|
}
|
|
|
|
// verify
|
|
verifyCmd := &cli.Command{
|
|
Use: "verify",
|
|
Short: "Verify module checksums",
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
execCmd := exec.Command("go", "mod", "verify")
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
return execCmd.Run()
|
|
},
|
|
}
|
|
|
|
// graph
|
|
graphCmd := &cli.Command{
|
|
Use: "graph",
|
|
Short: "Print module dependency graph",
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
execCmd := exec.Command("go", "mod", "graph")
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
return execCmd.Run()
|
|
},
|
|
}
|
|
|
|
modCmd.AddCommand(tidyCmd)
|
|
modCmd.AddCommand(downloadCmd)
|
|
modCmd.AddCommand(verifyCmd)
|
|
modCmd.AddCommand(graphCmd)
|
|
parent.AddCommand(modCmd)
|
|
}
|
|
|
|
func addGoWorkCommand(parent *cli.Command) {
|
|
workCmd := &cli.Command{
|
|
Use: "work",
|
|
Short: "Workspace management",
|
|
Long: "Go workspace management commands",
|
|
}
|
|
|
|
// sync
|
|
syncCmd := &cli.Command{
|
|
Use: "sync",
|
|
Short: "Sync workspace modules",
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
execCmd := exec.Command("go", "work", "sync")
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
return execCmd.Run()
|
|
},
|
|
}
|
|
|
|
// init
|
|
initCmd := &cli.Command{
|
|
Use: "init",
|
|
Short: "Initialise a new workspace",
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
execCmd := exec.Command("go", "work", "init")
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
if err := execCmd.Run(); err != nil {
|
|
return err
|
|
}
|
|
// Auto-add current module if go.mod exists
|
|
if _, err := os.Stat("go.mod"); err == nil {
|
|
execCmd = exec.Command("go", "work", "use", ".")
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
return execCmd.Run()
|
|
}
|
|
return nil
|
|
},
|
|
}
|
|
|
|
// use
|
|
useCmd := &cli.Command{
|
|
Use: "use [modules...]",
|
|
Short: "Add modules to workspace",
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
if len(args) == 0 {
|
|
// Auto-detect modules
|
|
modules := findGoModules(".")
|
|
if len(modules) == 0 {
|
|
return errors.New("no Go modules found")
|
|
}
|
|
for _, mod := range modules {
|
|
execCmd := exec.Command("go", "work", "use", mod)
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
if err := execCmd.Run(); err != nil {
|
|
return err
|
|
}
|
|
cli.Print("%s %s\n", successStyle.Render(i18n.T("i18n.done.add")), mod)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
cmdArgs := append([]string{"work", "use"}, args...)
|
|
execCmd := exec.Command("go", cmdArgs...)
|
|
execCmd.Stdout = os.Stdout
|
|
execCmd.Stderr = os.Stderr
|
|
return execCmd.Run()
|
|
},
|
|
}
|
|
|
|
workCmd.AddCommand(syncCmd)
|
|
workCmd.AddCommand(initCmd)
|
|
workCmd.AddCommand(useCmd)
|
|
parent.AddCommand(workCmd)
|
|
}
|
|
|
|
func findGoModules(root string) []string {
|
|
var modules []string
|
|
filepath.Walk(root, func(path string, info os.FileInfo, err error) error {
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
if info.Name() == "go.mod" && path != "go.mod" {
|
|
modules = append(modules, filepath.Dir(path))
|
|
}
|
|
return nil
|
|
})
|
|
return modules
|
|
}
|