* Remove StrictHostKeyChecking=no and implement proper host key verification This commit addresses security concerns from the OWASP audit by enforcing strict host key verification for all SSH and SCP commands. Key changes: - Replaced StrictHostKeyChecking=accept-new with yes in pkg/container and pkg/devops. - Removed insecure host key verification from pkg/ansible SSH client. - Implemented a synchronous host key discovery mechanism during VM boot using ssh-keyscan to populate ~/.core/known_hosts. - Updated the devops Boot lifecycle to wait until the host key is verified. - Ensured pkg/ansible correctly handles missing known_hosts files. - Refactored hardcoded SSH port 2222 to a package constant DefaultSSHPort. - Added CORE_SKIP_SSH_SCAN environment variable for test environments. * Remove StrictHostKeyChecking=no and implement proper host key verification Addresses security concerns from OWASP audit by enforcing strict host key verification. Changes: - Replaced StrictHostKeyChecking=accept-new with yes in pkg/container and devops. - Removed insecure host key verification from pkg/ansible. - Added synchronous host key discovery using ssh-keyscan during VM boot. - Updated Boot lifecycle to wait for host key verification. - Handled missing known_hosts file in pkg/ansible. - Refactored hardcoded SSH port to DefaultSSHPort constant. - Fixed formatting issues identified by QA check. * Secure SSH commands and fix auto-merge CI failure Addresses OWASP security audit by enforcing strict host key verification and fixes a CI failure in the auto-merge workflow. Key changes: - Replaced StrictHostKeyChecking=accept-new with yes in pkg/container and pkg/devops. - Removed insecure host key verification from pkg/ansible. - Implemented synchronous host key discovery using ssh-keyscan during VM boot. - Handled missing known_hosts file in pkg/ansible. - Refactored hardcoded SSH port to DefaultSSHPort constant. - Added pkg/ansible/ssh_test.go to verify SSH client initialization. - Fixed formatting in pkg/io/local/client.go. - Fixed auto-merge.yml by inlining the script and providing repository context to 'gh' command, resolving the "not a git repository" error in CI. * Secure SSH, fix CI auto-merge, and resolve merge conflicts This commit addresses the OWASP security audit by enforcing strict host key verification and resolves persistent CI issues. Security Changes: - Replaced StrictHostKeyChecking=accept-new with yes in pkg/container and devops. - Removed insecure host key verification from pkg/ansible. - Implemented synchronous host key discovery using ssh-keyscan during VM boot. - Updated Boot lifecycle to wait for host key verification. - Handled missing known_hosts file in pkg/ansible. - Refactored hardcoded SSH port to DefaultSSHPort constant. CI and Maintenance: - Fixed auto-merge.yml by inlining the script and adding repository context to 'gh' command, resolving the "not a git repository" error in CI. - Resolved merge conflicts in .github/workflows/auto-merge.yml with dev branch. - Added pkg/ansible/ssh_test.go for SSH client verification. - Fixed formatting in pkg/io/local/client.go to pass QA checks. * Secure SSH and TLS connections, and fix CI issues Addresses security concerns from OWASP audit and CodeQL by enforcing strict host key verification and TLS certificate verification. Security Changes: - Enforced strict SSH host key checking in pkg/container and devops. - Removed insecure SSH host key verification from pkg/ansible. - Added synchronous host key discovery during VM boot using ssh-keyscan. - Updated UniFi client to enforce TLS certificate verification by default. - Added --insecure flag and config option for UniFi to allow opt-in to skipping TLS verification for self-signed certificates. CI and Maintenance: - Fixed auto-merge workflow by providing repository context to 'gh' command. - Resolved merge conflicts in .github/workflows/auto-merge.yml. - Added unit tests for secured Ansible SSH client. - Fixed formatting issues identified by QA checks. * fix: gofmt alignment in cmd_config.go Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Secure connections, fix CI auto-merge, and resolve formatting Addresses OWASP security audit and CodeQL security alerts by enforcing secure defaults for SSH and TLS connections. Key changes: - Enforced strict SSH host key checking (StrictHostKeyChecking=yes). - Implemented synchronous host key verification during VM boot using ssh-keyscan. - Updated UniFi client to enforce TLS certificate verification by default. - Added --insecure flag and config option for UniFi to allow opt-in to skipping TLS verification. - Fixed auto-merge workflow by providing repository context to 'gh' command. - Resolved merge conflicts in .github/workflows/auto-merge.yml. - Fixed formatting in internal/cmd/unifi/cmd_config.go and pkg/io/local/client.go. - Added unit tests for secured Ansible SSH client. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Claude <developers@lethean.io>
143 lines
3.6 KiB
Go
143 lines
3.6 KiB
Go
package devops
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/host-uk/core/pkg/io"
|
|
)
|
|
|
|
// ClaudeOptions configures the Claude sandbox session.
|
|
type ClaudeOptions struct {
|
|
NoAuth bool // Don't forward any auth
|
|
Auth []string // Selective auth: "gh", "anthropic", "ssh", "git"
|
|
Model string // Model to use: opus, sonnet
|
|
}
|
|
|
|
// Claude starts a sandboxed Claude session in the dev environment.
|
|
func (d *DevOps) Claude(ctx context.Context, projectDir string, opts ClaudeOptions) error {
|
|
// Auto-boot if not running
|
|
running, err := d.IsRunning(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if !running {
|
|
fmt.Println("Dev environment not running, booting...")
|
|
if err := d.Boot(ctx, DefaultBootOptions()); err != nil {
|
|
return fmt.Errorf("failed to boot: %w", err)
|
|
}
|
|
}
|
|
|
|
// Mount project
|
|
if err := d.mountProject(ctx, projectDir); err != nil {
|
|
return fmt.Errorf("failed to mount project: %w", err)
|
|
}
|
|
|
|
// Prepare environment variables to forward
|
|
envVars := []string{}
|
|
|
|
if !opts.NoAuth {
|
|
authTypes := opts.Auth
|
|
if len(authTypes) == 0 {
|
|
authTypes = []string{"gh", "anthropic", "ssh", "git"}
|
|
}
|
|
|
|
for _, auth := range authTypes {
|
|
switch auth {
|
|
case "anthropic":
|
|
if key := os.Getenv("ANTHROPIC_API_KEY"); key != "" {
|
|
envVars = append(envVars, "ANTHROPIC_API_KEY="+key)
|
|
}
|
|
case "git":
|
|
// Forward git config
|
|
name, _ := exec.Command("git", "config", "user.name").Output()
|
|
email, _ := exec.Command("git", "config", "user.email").Output()
|
|
if len(name) > 0 {
|
|
envVars = append(envVars, "GIT_AUTHOR_NAME="+strings.TrimSpace(string(name)))
|
|
envVars = append(envVars, "GIT_COMMITTER_NAME="+strings.TrimSpace(string(name)))
|
|
}
|
|
if len(email) > 0 {
|
|
envVars = append(envVars, "GIT_AUTHOR_EMAIL="+strings.TrimSpace(string(email)))
|
|
envVars = append(envVars, "GIT_COMMITTER_EMAIL="+strings.TrimSpace(string(email)))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Build SSH command with agent forwarding
|
|
args := []string{
|
|
"-o", "StrictHostKeyChecking=yes",
|
|
"-o", "UserKnownHostsFile=~/.core/known_hosts",
|
|
"-o", "LogLevel=ERROR",
|
|
"-A", // SSH agent forwarding
|
|
"-p", fmt.Sprintf("%d", DefaultSSHPort),
|
|
}
|
|
|
|
args = append(args, "root@localhost")
|
|
|
|
// Build command to run inside
|
|
claudeCmd := "cd /app && claude"
|
|
if opts.Model != "" {
|
|
claudeCmd += " --model " + opts.Model
|
|
}
|
|
args = append(args, claudeCmd)
|
|
|
|
// Set environment for SSH
|
|
cmd := exec.CommandContext(ctx, "ssh", args...)
|
|
cmd.Stdin = os.Stdin
|
|
cmd.Stdout = os.Stdout
|
|
cmd.Stderr = os.Stderr
|
|
|
|
// Pass environment variables through SSH
|
|
for _, env := range envVars {
|
|
parts := strings.SplitN(env, "=", 2)
|
|
if len(parts) == 2 {
|
|
cmd.Env = append(os.Environ(), env)
|
|
}
|
|
}
|
|
|
|
fmt.Println("Starting Claude in sandboxed environment...")
|
|
fmt.Println("Project mounted at /app")
|
|
fmt.Println("Auth forwarded: SSH agent" + formatAuthList(opts))
|
|
fmt.Println()
|
|
|
|
return cmd.Run()
|
|
}
|
|
|
|
func formatAuthList(opts ClaudeOptions) string {
|
|
if opts.NoAuth {
|
|
return " (none)"
|
|
}
|
|
if len(opts.Auth) == 0 {
|
|
return ", gh, anthropic, git"
|
|
}
|
|
return ", " + strings.Join(opts.Auth, ", ")
|
|
}
|
|
|
|
// CopyGHAuth copies GitHub CLI auth to the VM.
|
|
func (d *DevOps) CopyGHAuth(ctx context.Context) error {
|
|
home, err := os.UserHomeDir()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
ghConfigDir := filepath.Join(home, ".config", "gh")
|
|
if !io.Local.IsDir(ghConfigDir) {
|
|
return nil // No gh config to copy
|
|
}
|
|
|
|
// Use scp to copy gh config
|
|
cmd := exec.CommandContext(ctx, "scp",
|
|
"-o", "StrictHostKeyChecking=yes",
|
|
"-o", "UserKnownHostsFile=~/.core/known_hosts",
|
|
"-o", "LogLevel=ERROR",
|
|
"-P", fmt.Sprintf("%d", DefaultSSHPort),
|
|
"-r", ghConfigDir,
|
|
"root@localhost:/root/.config/",
|
|
)
|
|
return cmd.Run()
|
|
}
|