* feat: add security logging and fix framework regressions This commit implements comprehensive security event logging and resolves critical regressions in the core framework. Security Logging: - Enhanced `pkg/log` with a `Security` level and helper. - Added `log.Username()` to consistently identify the executing user. - Instrumented GitHub CLI auth, Agentic configuration, filesystem sandbox, MCP handlers, and MCP TCP transport with security logs. - Added `SecurityStyle` to the CLI for consistent visual representation of security events. UniFi Security (CodeQL): - Refactored `pkg/unifi` to remove hardcoded `InsecureSkipVerify`, resolving a high-severity alert. - Added a `--verify-tls` flag and configuration option to control TLS verification. - Updated command handlers to support the new verification parameter. Framework Fixes: - Restored original signatures for `MustServiceFor`, `Config()`, and `Display()` in `pkg/framework/core`, which had been corrupted during a merge. - Fixed `pkg/framework/framework.go` and `pkg/framework/core/runtime_pkg.go` to match the restored signatures. - These fixes resolve project-wide compilation errors caused by the signature mismatches. I encountered significant blockers due to a corrupted state of the `dev` branch after a merge, which introduced breaking changes in the core framework's DI system. I had to manually reconcile these signatures with the expected usage across the codebase to restore build stability. * feat(mcp): add RAG tools (query, ingest, collections) Add vector database tools to the MCP server for RAG operations: - rag_query: Search for relevant documentation using semantic similarity - rag_ingest: Ingest files or directories into the vector database - rag_collections: List available collections Uses existing internal/cmd/rag exports (QueryDocs, IngestDirectory, IngestFile) and pkg/rag for Qdrant client access. Default collection is "hostuk-docs" with topK=5 for queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add metrics tools (record, query) Add MCP tools for recording and querying AI/security metrics events. The metrics_record tool writes events to daily JSONL files, and the metrics_query tool provides aggregated statistics by type, repo, and agent. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add 'core mcp serve' command Add CLI command to start the MCP server for AI tool integration. - Create internal/cmd/mcpcmd package with serve subcommand - Support --workspace flag for directory restriction - Handle SIGINT/SIGTERM for clean shutdown - Register in full.go build variant Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(ws): add WebSocket hub package for real-time streaming Add pkg/ws package implementing a hub pattern for WebSocket connections: - Hub manages client connections, broadcasts, and channel subscriptions - Client struct represents connected WebSocket clients - Message types: process_output, process_status, event, error, ping/pong - Channel-based subscription system (subscribe/unsubscribe) - SendProcessOutput and SendProcessStatus for process streaming integration - Full test coverage including concurrency tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add process management and WebSocket MCP tools Add MCP tools for process management: - process_start: Start a new external process - process_stop: Gracefully stop a running process - process_kill: Force kill a process - process_list: List all managed processes - process_output: Get captured process output - process_input: Send input to process stdin Add MCP tools for WebSocket: - ws_start: Start WebSocket server for real-time streaming - ws_info: Get hub statistics (clients, channels) Update Service struct with optional process.Service and ws.Hub fields, new WithProcessService and WithWSHub options, getter methods, and Shutdown method for cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(webview): add browser automation package via Chrome DevTools Protocol Add pkg/webview package for browser automation: - webview.go: Main interface with Connect, Navigate, Click, Type, QuerySelector, Screenshot, Evaluate - cdp.go: Chrome DevTools Protocol WebSocket client implementation - actions.go: DOM action types (Click, Type, Hover, Scroll, etc.) and ActionSequence builder - console.go: Console message capture and filtering with ConsoleWatcher and ExceptionWatcher - angular.go: Angular-specific helpers for router navigation, component access, and Zone.js stability Add MCP tools for webview: - webview_connect/disconnect: Connection management - webview_navigate: Page navigation - webview_click/type/query/wait: DOM interaction - webview_console: Console output capture - webview_eval: JavaScript execution - webview_screenshot: Screenshot capture Add documentation: - docs/mcp/angular-testing.md: Guide for Angular application testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: document new packages and BugSETI application - Update CLAUDE.md with documentation for: - pkg/ws (WebSocket hub for real-time streaming) - pkg/webview (Browser automation via CDP) - pkg/mcp (MCP server tools: process, ws, webview) - BugSETI application overview - Add comprehensive README for BugSETI with: - Installation and configuration guide - Usage workflow documentation - Architecture overview - Contributing guidelines Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(bugseti): add BugSETI system tray app with auto-update BugSETI - Distributed Bug Fixing like SETI@home but for code Features: - System tray app with Wails v3 - GitHub issue fetching with label filters - Issue queue with priority management - AI context seeding via seed-agent-developer skill - Automated PR submission flow - Stats tracking and leaderboard - Cross-platform notifications - Self-updating with stable/beta/nightly channels Includes: - cmd/bugseti: Main application with Angular frontend - internal/bugseti: Core services (fetcher, queue, seeder, submit, config, stats, notify) - internal/bugseti/updater: Auto-update system (checker, downloader, installer) - .github/workflows/bugseti-release.yml: CI/CD for all platforms Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: resolve import cycle and code duplication - Remove pkg/log import from pkg/io/local to break import cycle (pkg/log/rotation.go imports pkg/io, creating circular dependency) - Use stderr logging for security events in sandbox escape detection - Remove unused sync/atomic import from core.go - Fix duplicate LogSecurity function declarations in cli/log.go - Update workspace/service.go Crypt() call to match interface Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: update tests for new function signatures and format code - Update core_test.go: Config(), Display() now panic instead of returning error - Update runtime_pkg_test.go: sr.Config() now panics instead of returning error - Update MustServiceFor tests to use assert.Panics - Format BugSETI, MCP tools, and webview packages with gofmt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Snider <631881+Snider@users.noreply.github.com> Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
229 lines
6.2 KiB
Go
229 lines
6.2 KiB
Go
package gocmd
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/host-uk/core/pkg/cli"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCalculateBlockCoverage(t *testing.T) {
|
|
// Create a dummy coverage profile
|
|
content := `mode: set
|
|
github.com/host-uk/core/pkg/foo.go:1.2,3.4 5 1
|
|
github.com/host-uk/core/pkg/foo.go:5.6,7.8 2 0
|
|
github.com/host-uk/core/pkg/bar.go:10.1,12.20 10 5
|
|
`
|
|
tmpfile, err := os.CreateTemp("", "test-coverage-*.out")
|
|
assert.NoError(t, err)
|
|
defer os.Remove(tmpfile.Name())
|
|
|
|
_, err = tmpfile.Write([]byte(content))
|
|
assert.NoError(t, err)
|
|
err = tmpfile.Close()
|
|
assert.NoError(t, err)
|
|
|
|
// Test calculation
|
|
// 3 blocks total, 2 covered (count > 0)
|
|
// Expect (2/3) * 100 = 66.666...
|
|
pct, err := calculateBlockCoverage(tmpfile.Name())
|
|
assert.NoError(t, err)
|
|
assert.InDelta(t, 66.67, pct, 0.01)
|
|
|
|
// Test empty file (only header)
|
|
contentEmpty := "mode: atomic\n"
|
|
tmpfileEmpty, _ := os.CreateTemp("", "test-coverage-empty-*.out")
|
|
defer os.Remove(tmpfileEmpty.Name())
|
|
tmpfileEmpty.Write([]byte(contentEmpty))
|
|
tmpfileEmpty.Close()
|
|
|
|
pct, err = calculateBlockCoverage(tmpfileEmpty.Name())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 0.0, pct)
|
|
|
|
// Test non-existent file
|
|
pct, err = calculateBlockCoverage("non-existent-file")
|
|
assert.Error(t, err)
|
|
assert.Equal(t, 0.0, pct)
|
|
|
|
// Test malformed file
|
|
contentMalformed := `mode: set
|
|
github.com/host-uk/core/pkg/foo.go:1.2,3.4 5
|
|
github.com/host-uk/core/pkg/foo.go:1.2,3.4 5 notanumber
|
|
`
|
|
tmpfileMalformed, _ := os.CreateTemp("", "test-coverage-malformed-*.out")
|
|
defer os.Remove(tmpfileMalformed.Name())
|
|
tmpfileMalformed.Write([]byte(contentMalformed))
|
|
tmpfileMalformed.Close()
|
|
|
|
pct, err = calculateBlockCoverage(tmpfileMalformed.Name())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 0.0, pct)
|
|
|
|
// Test malformed file - missing fields
|
|
contentMalformed2 := `mode: set
|
|
github.com/host-uk/core/pkg/foo.go:1.2,3.4 5
|
|
`
|
|
tmpfileMalformed2, _ := os.CreateTemp("", "test-coverage-malformed2-*.out")
|
|
defer os.Remove(tmpfileMalformed2.Name())
|
|
tmpfileMalformed2.Write([]byte(contentMalformed2))
|
|
tmpfileMalformed2.Close()
|
|
|
|
pct, err = calculateBlockCoverage(tmpfileMalformed2.Name())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 0.0, pct)
|
|
|
|
// Test completely empty file
|
|
tmpfileEmpty2, _ := os.CreateTemp("", "test-coverage-empty2-*.out")
|
|
defer os.Remove(tmpfileEmpty2.Name())
|
|
tmpfileEmpty2.Close()
|
|
pct, err = calculateBlockCoverage(tmpfileEmpty2.Name())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 0.0, pct)
|
|
}
|
|
|
|
func TestParseOverallCoverage(t *testing.T) {
|
|
output := `ok github.com/host-uk/core/pkg/foo 0.100s coverage: 50.0% of statements
|
|
ok github.com/host-uk/core/pkg/bar 0.200s coverage: 100.0% of statements
|
|
`
|
|
pct := parseOverallCoverage(output)
|
|
assert.Equal(t, 75.0, pct)
|
|
|
|
outputNoCov := "ok github.com/host-uk/core/pkg/foo 0.100s"
|
|
pct = parseOverallCoverage(outputNoCov)
|
|
assert.Equal(t, 0.0, pct)
|
|
}
|
|
|
|
func TestFormatCoverage(t *testing.T) {
|
|
assert.Contains(t, formatCoverage(85.0), "85.0%")
|
|
assert.Contains(t, formatCoverage(65.0), "65.0%")
|
|
assert.Contains(t, formatCoverage(25.0), "25.0%")
|
|
}
|
|
|
|
func TestAddGoCovCommand(t *testing.T) {
|
|
cmd := &cli.Command{Use: "test"}
|
|
addGoCovCommand(cmd)
|
|
assert.True(t, cmd.HasSubCommands())
|
|
sub := cmd.Commands()[0]
|
|
assert.Equal(t, "cov", sub.Name())
|
|
}
|
|
|
|
func TestAddGoQACommand(t *testing.T) {
|
|
cmd := &cli.Command{Use: "test"}
|
|
addGoQACommand(cmd)
|
|
assert.True(t, cmd.HasSubCommands())
|
|
sub := cmd.Commands()[0]
|
|
assert.Equal(t, "qa", sub.Name())
|
|
}
|
|
|
|
func TestDetermineChecks(t *testing.T) {
|
|
// Default checks
|
|
qaOnly = ""
|
|
qaSkip = ""
|
|
qaRace = false
|
|
qaBench = false
|
|
checks := determineChecks()
|
|
assert.Contains(t, checks, "fmt")
|
|
assert.Contains(t, checks, "test")
|
|
|
|
// Only
|
|
qaOnly = "fmt,lint"
|
|
checks = determineChecks()
|
|
assert.Equal(t, []string{"fmt", "lint"}, checks)
|
|
|
|
// Skip
|
|
qaOnly = ""
|
|
qaSkip = "fmt,lint"
|
|
checks = determineChecks()
|
|
assert.NotContains(t, checks, "fmt")
|
|
assert.NotContains(t, checks, "lint")
|
|
assert.Contains(t, checks, "test")
|
|
|
|
// Race
|
|
qaSkip = ""
|
|
qaRace = true
|
|
checks = determineChecks()
|
|
assert.Contains(t, checks, "race")
|
|
assert.NotContains(t, checks, "test")
|
|
|
|
// Reset
|
|
qaRace = false
|
|
}
|
|
|
|
func TestBuildCheck(t *testing.T) {
|
|
qaFix = false
|
|
c := buildCheck("fmt")
|
|
assert.Equal(t, "format", c.Name)
|
|
assert.Equal(t, []string{"-l", "."}, c.Args)
|
|
|
|
qaFix = true
|
|
c = buildCheck("fmt")
|
|
assert.Equal(t, []string{"-w", "."}, c.Args)
|
|
|
|
c = buildCheck("vet")
|
|
assert.Equal(t, "vet", c.Name)
|
|
|
|
c = buildCheck("lint")
|
|
assert.Equal(t, "lint", c.Name)
|
|
|
|
c = buildCheck("test")
|
|
assert.Equal(t, "test", c.Name)
|
|
|
|
c = buildCheck("race")
|
|
assert.Equal(t, "race", c.Name)
|
|
|
|
c = buildCheck("bench")
|
|
assert.Equal(t, "bench", c.Name)
|
|
|
|
c = buildCheck("vuln")
|
|
assert.Equal(t, "vuln", c.Name)
|
|
|
|
c = buildCheck("sec")
|
|
assert.Equal(t, "sec", c.Name)
|
|
|
|
c = buildCheck("fuzz")
|
|
assert.Equal(t, "fuzz", c.Name)
|
|
|
|
c = buildCheck("docblock")
|
|
assert.Equal(t, "docblock", c.Name)
|
|
|
|
c = buildCheck("unknown")
|
|
assert.Equal(t, "", c.Name)
|
|
}
|
|
|
|
func TestBuildChecks(t *testing.T) {
|
|
checks := buildChecks([]string{"fmt", "vet", "unknown"})
|
|
assert.Equal(t, 2, len(checks))
|
|
assert.Equal(t, "format", checks[0].Name)
|
|
assert.Equal(t, "vet", checks[1].Name)
|
|
}
|
|
|
|
func TestFixHintFor(t *testing.T) {
|
|
assert.Contains(t, fixHintFor("format", ""), "core go qa fmt --fix")
|
|
assert.Contains(t, fixHintFor("vet", ""), "go vet")
|
|
assert.Contains(t, fixHintFor("lint", ""), "core go qa lint --fix")
|
|
assert.Contains(t, fixHintFor("test", "--- FAIL: TestFoo"), "TestFoo")
|
|
assert.Contains(t, fixHintFor("race", ""), "Data race")
|
|
assert.Contains(t, fixHintFor("bench", ""), "Benchmark regression")
|
|
assert.Contains(t, fixHintFor("vuln", ""), "govulncheck")
|
|
assert.Contains(t, fixHintFor("sec", ""), "gosec")
|
|
assert.Contains(t, fixHintFor("fuzz", ""), "crashing input")
|
|
assert.Contains(t, fixHintFor("docblock", ""), "doc comments")
|
|
assert.Equal(t, "", fixHintFor("unknown", ""))
|
|
}
|
|
|
|
func TestRunGoQA_NoGoMod(t *testing.T) {
|
|
// runGoQA should fail if go.mod is not present in CWD
|
|
// We run it in a temp dir without go.mod
|
|
tmpDir, _ := os.MkdirTemp("", "test-qa-*")
|
|
defer os.RemoveAll(tmpDir)
|
|
cwd, _ := os.Getwd()
|
|
os.Chdir(tmpDir)
|
|
defer os.Chdir(cwd)
|
|
|
|
cmd := &cli.Command{Use: "qa"}
|
|
err := runGoQA(cmd, []string{})
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "no go.mod found")
|
|
}
|