* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
133 lines
3 KiB
Go
133 lines
3 KiB
Go
// Package release provides release automation with changelog generation and publishing.
|
|
package release
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/host-uk/core/internal/cmd/sdk"
|
|
)
|
|
|
|
// SDKRelease holds the result of an SDK release.
|
|
type SDKRelease struct {
|
|
// Version is the SDK version.
|
|
Version string
|
|
// Languages that were generated.
|
|
Languages []string
|
|
// Output directory.
|
|
Output string
|
|
}
|
|
|
|
// RunSDK executes SDK-only release: diff check + generate.
|
|
// If dryRun is true, it shows what would be done without generating.
|
|
func RunSDK(ctx context.Context, cfg *Config, dryRun bool) (*SDKRelease, error) {
|
|
if cfg == nil {
|
|
return nil, fmt.Errorf("release.RunSDK: config is nil")
|
|
}
|
|
if cfg.SDK == nil {
|
|
return nil, fmt.Errorf("release.RunSDK: sdk not configured in .core/release.yaml")
|
|
}
|
|
|
|
projectDir := cfg.projectDir
|
|
if projectDir == "" {
|
|
projectDir = "."
|
|
}
|
|
|
|
// Determine version
|
|
version := cfg.version
|
|
if version == "" {
|
|
var err error
|
|
version, err = DetermineVersion(projectDir)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("release.RunSDK: failed to determine version: %w", err)
|
|
}
|
|
}
|
|
|
|
// Run diff check if enabled
|
|
if cfg.SDK.Diff.Enabled {
|
|
breaking, err := checkBreakingChanges(projectDir, cfg.SDK)
|
|
if err != nil {
|
|
// Non-fatal: warn and continue
|
|
fmt.Printf("Warning: diff check failed: %v\n", err)
|
|
} else if breaking {
|
|
if cfg.SDK.Diff.FailOnBreaking {
|
|
return nil, fmt.Errorf("release.RunSDK: breaking API changes detected")
|
|
}
|
|
fmt.Printf("Warning: breaking API changes detected\n")
|
|
}
|
|
}
|
|
|
|
// Prepare result
|
|
output := cfg.SDK.Output
|
|
if output == "" {
|
|
output = "sdk"
|
|
}
|
|
|
|
result := &SDKRelease{
|
|
Version: version,
|
|
Languages: cfg.SDK.Languages,
|
|
Output: output,
|
|
}
|
|
|
|
if dryRun {
|
|
return result, nil
|
|
}
|
|
|
|
// Generate SDKs
|
|
sdkCfg := toSDKConfig(cfg.SDK)
|
|
s := sdk.New(projectDir, sdkCfg)
|
|
s.SetVersion(version)
|
|
|
|
if err := s.Generate(ctx); err != nil {
|
|
return nil, fmt.Errorf("release.RunSDK: generation failed: %w", err)
|
|
}
|
|
|
|
return result, nil
|
|
}
|
|
|
|
// checkBreakingChanges runs oasdiff to detect breaking changes.
|
|
func checkBreakingChanges(projectDir string, cfg *SDKConfig) (bool, error) {
|
|
// Get previous tag for comparison (uses getPreviousTag from changelog.go)
|
|
prevTag, err := getPreviousTag(projectDir, "HEAD")
|
|
if err != nil {
|
|
return false, fmt.Errorf("no previous tag found: %w", err)
|
|
}
|
|
|
|
// Detect spec path
|
|
specPath := cfg.Spec
|
|
if specPath == "" {
|
|
s := sdk.New(projectDir, nil)
|
|
specPath, err = s.DetectSpec()
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
}
|
|
|
|
// Run diff
|
|
result, err := sdk.Diff(prevTag, specPath)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
return result.Breaking, nil
|
|
}
|
|
|
|
// toSDKConfig converts release.SDKConfig to sdk.Config.
|
|
func toSDKConfig(cfg *SDKConfig) *sdk.Config {
|
|
if cfg == nil {
|
|
return nil
|
|
}
|
|
return &sdk.Config{
|
|
Spec: cfg.Spec,
|
|
Languages: cfg.Languages,
|
|
Output: cfg.Output,
|
|
Package: sdk.PackageConfig{
|
|
Name: cfg.Package.Name,
|
|
Version: cfg.Package.Version,
|
|
},
|
|
Diff: sdk.DiffConfig{
|
|
Enabled: cfg.Diff.Enabled,
|
|
FailOnBreaking: cfg.Diff.FailOnBreaking,
|
|
},
|
|
}
|
|
}
|