f47e8211fb
* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
101 lines
2.6 KiB
Go
101 lines
2.6 KiB
Go
package doctor
|
|
|
|
import (
|
|
"os/exec"
|
|
"strings"
|
|
|
|
"github.com/host-uk/core/pkg/i18n"
|
|
)
|
|
|
|
// check represents a tool check configuration
|
|
type check struct {
|
|
name string
|
|
description string
|
|
command string
|
|
args []string
|
|
versionFlag string
|
|
}
|
|
|
|
// requiredChecks returns tools that must be installed
|
|
func requiredChecks() []check {
|
|
return []check{
|
|
{
|
|
name: i18n.T("cmd.doctor.check.git.name"),
|
|
description: i18n.T("cmd.doctor.check.git.description"),
|
|
command: "git",
|
|
args: []string{"--version"},
|
|
versionFlag: "--version",
|
|
},
|
|
{
|
|
name: i18n.T("cmd.doctor.check.gh.name"),
|
|
description: i18n.T("cmd.doctor.check.gh.description"),
|
|
command: "gh",
|
|
args: []string{"--version"},
|
|
versionFlag: "--version",
|
|
},
|
|
{
|
|
name: i18n.T("cmd.doctor.check.php.name"),
|
|
description: i18n.T("cmd.doctor.check.php.description"),
|
|
command: "php",
|
|
args: []string{"-v"},
|
|
versionFlag: "-v",
|
|
},
|
|
{
|
|
name: i18n.T("cmd.doctor.check.composer.name"),
|
|
description: i18n.T("cmd.doctor.check.composer.description"),
|
|
command: "composer",
|
|
args: []string{"--version"},
|
|
versionFlag: "--version",
|
|
},
|
|
{
|
|
name: i18n.T("cmd.doctor.check.node.name"),
|
|
description: i18n.T("cmd.doctor.check.node.description"),
|
|
command: "node",
|
|
args: []string{"--version"},
|
|
versionFlag: "--version",
|
|
},
|
|
}
|
|
}
|
|
|
|
// optionalChecks returns tools that are nice to have
|
|
func optionalChecks() []check {
|
|
return []check{
|
|
{
|
|
name: i18n.T("cmd.doctor.check.pnpm.name"),
|
|
description: i18n.T("cmd.doctor.check.pnpm.description"),
|
|
command: "pnpm",
|
|
args: []string{"--version"},
|
|
versionFlag: "--version",
|
|
},
|
|
{
|
|
name: i18n.T("cmd.doctor.check.claude.name"),
|
|
description: i18n.T("cmd.doctor.check.claude.description"),
|
|
command: "claude",
|
|
args: []string{"--version"},
|
|
versionFlag: "--version",
|
|
},
|
|
{
|
|
name: i18n.T("cmd.doctor.check.docker.name"),
|
|
description: i18n.T("cmd.doctor.check.docker.description"),
|
|
command: "docker",
|
|
args: []string{"--version"},
|
|
versionFlag: "--version",
|
|
},
|
|
}
|
|
}
|
|
|
|
// runCheck executes a tool check and returns success status and version info
|
|
func runCheck(c check) (bool, string) {
|
|
cmd := exec.Command(c.command, c.args...)
|
|
output, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
return false, ""
|
|
}
|
|
|
|
// Extract first line as version
|
|
lines := strings.Split(strings.TrimSpace(string(output)), "\n")
|
|
if len(lines) > 0 {
|
|
return true, strings.TrimSpace(lines[0])
|
|
}
|
|
return true, ""
|
|
}
|