* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
193 lines
4.4 KiB
Go
193 lines
4.4 KiB
Go
package php
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
|
|
"github.com/host-uk/core/pkg/cli"
|
|
)
|
|
|
|
// TestOptions configures PHP test execution.
|
|
type TestOptions struct {
|
|
// Dir is the project directory (defaults to current working directory).
|
|
Dir string
|
|
|
|
// Filter filters tests by name pattern.
|
|
Filter string
|
|
|
|
// Parallel runs tests in parallel.
|
|
Parallel bool
|
|
|
|
// Coverage generates code coverage.
|
|
Coverage bool
|
|
|
|
// CoverageFormat is the coverage output format (text, html, clover).
|
|
CoverageFormat string
|
|
|
|
// Groups runs only tests in the specified groups.
|
|
Groups []string
|
|
|
|
// JUnit outputs results in JUnit XML format via --log-junit.
|
|
JUnit bool
|
|
|
|
// Output is the writer for test output (defaults to os.Stdout).
|
|
Output io.Writer
|
|
}
|
|
|
|
// TestRunner represents the detected test runner.
|
|
type TestRunner string
|
|
|
|
// Test runner type constants.
|
|
const (
|
|
// TestRunnerPest indicates Pest testing framework.
|
|
TestRunnerPest TestRunner = "pest"
|
|
// TestRunnerPHPUnit indicates PHPUnit testing framework.
|
|
TestRunnerPHPUnit TestRunner = "phpunit"
|
|
)
|
|
|
|
// DetectTestRunner detects which test runner is available in the project.
|
|
// Returns Pest if tests/Pest.php exists, otherwise PHPUnit.
|
|
func DetectTestRunner(dir string) TestRunner {
|
|
// Check for Pest
|
|
pestFile := filepath.Join(dir, "tests", "Pest.php")
|
|
if _, err := os.Stat(pestFile); err == nil {
|
|
return TestRunnerPest
|
|
}
|
|
|
|
return TestRunnerPHPUnit
|
|
}
|
|
|
|
// RunTests runs PHPUnit or Pest tests.
|
|
func RunTests(ctx context.Context, opts TestOptions) error {
|
|
if opts.Dir == "" {
|
|
cwd, err := os.Getwd()
|
|
if err != nil {
|
|
return cli.WrapVerb(err, "get", "working directory")
|
|
}
|
|
opts.Dir = cwd
|
|
}
|
|
|
|
if opts.Output == nil {
|
|
opts.Output = os.Stdout
|
|
}
|
|
|
|
// Detect test runner
|
|
runner := DetectTestRunner(opts.Dir)
|
|
|
|
// Build command based on runner
|
|
var cmdName string
|
|
var args []string
|
|
|
|
switch runner {
|
|
case TestRunnerPest:
|
|
cmdName, args = buildPestCommand(opts)
|
|
default:
|
|
cmdName, args = buildPHPUnitCommand(opts)
|
|
}
|
|
|
|
cmd := exec.CommandContext(ctx, cmdName, args...)
|
|
cmd.Dir = opts.Dir
|
|
cmd.Stdout = opts.Output
|
|
cmd.Stderr = opts.Output
|
|
cmd.Stdin = os.Stdin
|
|
|
|
// Set XDEBUG_MODE=coverage to avoid PHPUnit 11 warning
|
|
cmd.Env = append(os.Environ(), "XDEBUG_MODE=coverage")
|
|
|
|
return cmd.Run()
|
|
}
|
|
|
|
// RunParallel runs tests in parallel using the appropriate runner.
|
|
func RunParallel(ctx context.Context, opts TestOptions) error {
|
|
opts.Parallel = true
|
|
return RunTests(ctx, opts)
|
|
}
|
|
|
|
// buildPestCommand builds the command for running Pest tests.
|
|
func buildPestCommand(opts TestOptions) (string, []string) {
|
|
// Check for vendor binary first
|
|
vendorBin := filepath.Join(opts.Dir, "vendor", "bin", "pest")
|
|
cmdName := "pest"
|
|
if _, err := os.Stat(vendorBin); err == nil {
|
|
cmdName = vendorBin
|
|
}
|
|
|
|
var args []string
|
|
|
|
if opts.Filter != "" {
|
|
args = append(args, "--filter", opts.Filter)
|
|
}
|
|
|
|
if opts.Parallel {
|
|
args = append(args, "--parallel")
|
|
}
|
|
|
|
if opts.Coverage {
|
|
switch opts.CoverageFormat {
|
|
case "html":
|
|
args = append(args, "--coverage-html", "coverage")
|
|
case "clover":
|
|
args = append(args, "--coverage-clover", "coverage.xml")
|
|
default:
|
|
args = append(args, "--coverage")
|
|
}
|
|
}
|
|
|
|
for _, group := range opts.Groups {
|
|
args = append(args, "--group", group)
|
|
}
|
|
|
|
if opts.JUnit {
|
|
args = append(args, "--log-junit", "test-results.xml")
|
|
}
|
|
|
|
return cmdName, args
|
|
}
|
|
|
|
// buildPHPUnitCommand builds the command for running PHPUnit tests.
|
|
func buildPHPUnitCommand(opts TestOptions) (string, []string) {
|
|
// Check for vendor binary first
|
|
vendorBin := filepath.Join(opts.Dir, "vendor", "bin", "phpunit")
|
|
cmdName := "phpunit"
|
|
if _, err := os.Stat(vendorBin); err == nil {
|
|
cmdName = vendorBin
|
|
}
|
|
|
|
var args []string
|
|
|
|
if opts.Filter != "" {
|
|
args = append(args, "--filter", opts.Filter)
|
|
}
|
|
|
|
if opts.Parallel {
|
|
// PHPUnit uses paratest for parallel execution
|
|
paratestBin := filepath.Join(opts.Dir, "vendor", "bin", "paratest")
|
|
if _, err := os.Stat(paratestBin); err == nil {
|
|
cmdName = paratestBin
|
|
}
|
|
}
|
|
|
|
if opts.Coverage {
|
|
switch opts.CoverageFormat {
|
|
case "html":
|
|
args = append(args, "--coverage-html", "coverage")
|
|
case "clover":
|
|
args = append(args, "--coverage-clover", "coverage.xml")
|
|
default:
|
|
args = append(args, "--coverage-text")
|
|
}
|
|
}
|
|
|
|
for _, group := range opts.Groups {
|
|
args = append(args, "--group", group)
|
|
}
|
|
|
|
if opts.JUnit {
|
|
args = append(args, "--log-junit", "test-results.xml", "--testdox")
|
|
}
|
|
|
|
return cmdName, args
|
|
}
|