* feat: add security logging and fix framework regressions This commit implements comprehensive security event logging and resolves critical regressions in the core framework. Security Logging: - Enhanced `pkg/log` with a `Security` level and helper. - Added `log.Username()` to consistently identify the executing user. - Instrumented GitHub CLI auth, Agentic configuration, filesystem sandbox, MCP handlers, and MCP TCP transport with security logs. - Added `SecurityStyle` to the CLI for consistent visual representation of security events. UniFi Security (CodeQL): - Refactored `pkg/unifi` to remove hardcoded `InsecureSkipVerify`, resolving a high-severity alert. - Added a `--verify-tls` flag and configuration option to control TLS verification. - Updated command handlers to support the new verification parameter. Framework Fixes: - Restored original signatures for `MustServiceFor`, `Config()`, and `Display()` in `pkg/framework/core`, which had been corrupted during a merge. - Fixed `pkg/framework/framework.go` and `pkg/framework/core/runtime_pkg.go` to match the restored signatures. - These fixes resolve project-wide compilation errors caused by the signature mismatches. I encountered significant blockers due to a corrupted state of the `dev` branch after a merge, which introduced breaking changes in the core framework's DI system. I had to manually reconcile these signatures with the expected usage across the codebase to restore build stability. * feat(mcp): add RAG tools (query, ingest, collections) Add vector database tools to the MCP server for RAG operations: - rag_query: Search for relevant documentation using semantic similarity - rag_ingest: Ingest files or directories into the vector database - rag_collections: List available collections Uses existing internal/cmd/rag exports (QueryDocs, IngestDirectory, IngestFile) and pkg/rag for Qdrant client access. Default collection is "hostuk-docs" with topK=5 for queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add metrics tools (record, query) Add MCP tools for recording and querying AI/security metrics events. The metrics_record tool writes events to daily JSONL files, and the metrics_query tool provides aggregated statistics by type, repo, and agent. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add 'core mcp serve' command Add CLI command to start the MCP server for AI tool integration. - Create internal/cmd/mcpcmd package with serve subcommand - Support --workspace flag for directory restriction - Handle SIGINT/SIGTERM for clean shutdown - Register in full.go build variant Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(ws): add WebSocket hub package for real-time streaming Add pkg/ws package implementing a hub pattern for WebSocket connections: - Hub manages client connections, broadcasts, and channel subscriptions - Client struct represents connected WebSocket clients - Message types: process_output, process_status, event, error, ping/pong - Channel-based subscription system (subscribe/unsubscribe) - SendProcessOutput and SendProcessStatus for process streaming integration - Full test coverage including concurrency tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add process management and WebSocket MCP tools Add MCP tools for process management: - process_start: Start a new external process - process_stop: Gracefully stop a running process - process_kill: Force kill a process - process_list: List all managed processes - process_output: Get captured process output - process_input: Send input to process stdin Add MCP tools for WebSocket: - ws_start: Start WebSocket server for real-time streaming - ws_info: Get hub statistics (clients, channels) Update Service struct with optional process.Service and ws.Hub fields, new WithProcessService and WithWSHub options, getter methods, and Shutdown method for cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(webview): add browser automation package via Chrome DevTools Protocol Add pkg/webview package for browser automation: - webview.go: Main interface with Connect, Navigate, Click, Type, QuerySelector, Screenshot, Evaluate - cdp.go: Chrome DevTools Protocol WebSocket client implementation - actions.go: DOM action types (Click, Type, Hover, Scroll, etc.) and ActionSequence builder - console.go: Console message capture and filtering with ConsoleWatcher and ExceptionWatcher - angular.go: Angular-specific helpers for router navigation, component access, and Zone.js stability Add MCP tools for webview: - webview_connect/disconnect: Connection management - webview_navigate: Page navigation - webview_click/type/query/wait: DOM interaction - webview_console: Console output capture - webview_eval: JavaScript execution - webview_screenshot: Screenshot capture Add documentation: - docs/mcp/angular-testing.md: Guide for Angular application testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: document new packages and BugSETI application - Update CLAUDE.md with documentation for: - pkg/ws (WebSocket hub for real-time streaming) - pkg/webview (Browser automation via CDP) - pkg/mcp (MCP server tools: process, ws, webview) - BugSETI application overview - Add comprehensive README for BugSETI with: - Installation and configuration guide - Usage workflow documentation - Architecture overview - Contributing guidelines Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(bugseti): add BugSETI system tray app with auto-update BugSETI - Distributed Bug Fixing like SETI@home but for code Features: - System tray app with Wails v3 - GitHub issue fetching with label filters - Issue queue with priority management - AI context seeding via seed-agent-developer skill - Automated PR submission flow - Stats tracking and leaderboard - Cross-platform notifications - Self-updating with stable/beta/nightly channels Includes: - cmd/bugseti: Main application with Angular frontend - internal/bugseti: Core services (fetcher, queue, seeder, submit, config, stats, notify) - internal/bugseti/updater: Auto-update system (checker, downloader, installer) - .github/workflows/bugseti-release.yml: CI/CD for all platforms Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: resolve import cycle and code duplication - Remove pkg/log import from pkg/io/local to break import cycle (pkg/log/rotation.go imports pkg/io, creating circular dependency) - Use stderr logging for security events in sandbox escape detection - Remove unused sync/atomic import from core.go - Fix duplicate LogSecurity function declarations in cli/log.go - Update workspace/service.go Crypt() call to match interface Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: update tests for new function signatures and format code - Update core_test.go: Config(), Display() now panic instead of returning error - Update runtime_pkg_test.go: sr.Config() now panics instead of returning error - Update MustServiceFor tests to use assert.Panics - Format BugSETI, MCP tools, and webview packages with gofmt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Snider <631881+Snider@users.noreply.github.com> Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
308 lines
6.7 KiB
Go
308 lines
6.7 KiB
Go
// Package bugseti provides services for the BugSETI distributed bug fixing application.
|
|
package bugseti
|
|
|
|
import (
|
|
"container/heap"
|
|
"encoding/json"
|
|
"log"
|
|
"os"
|
|
"path/filepath"
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
// IssueStatus represents the status of an issue in the queue.
|
|
type IssueStatus string
|
|
|
|
const (
|
|
StatusPending IssueStatus = "pending"
|
|
StatusClaimed IssueStatus = "claimed"
|
|
StatusInProgress IssueStatus = "in_progress"
|
|
StatusCompleted IssueStatus = "completed"
|
|
StatusSkipped IssueStatus = "skipped"
|
|
)
|
|
|
|
// Issue represents a GitHub issue in the queue.
|
|
type Issue struct {
|
|
ID string `json:"id"`
|
|
Number int `json:"number"`
|
|
Repo string `json:"repo"`
|
|
Title string `json:"title"`
|
|
Body string `json:"body"`
|
|
URL string `json:"url"`
|
|
Labels []string `json:"labels"`
|
|
Author string `json:"author"`
|
|
CreatedAt time.Time `json:"createdAt"`
|
|
Priority int `json:"priority"`
|
|
Status IssueStatus `json:"status"`
|
|
ClaimedAt time.Time `json:"claimedAt,omitempty"`
|
|
Context *IssueContext `json:"context,omitempty"`
|
|
Comments []Comment `json:"comments,omitempty"`
|
|
index int // For heap interface
|
|
}
|
|
|
|
// Comment represents a comment on an issue.
|
|
type Comment struct {
|
|
Author string `json:"author"`
|
|
Body string `json:"body"`
|
|
}
|
|
|
|
// IssueContext contains AI-prepared context for an issue.
|
|
type IssueContext struct {
|
|
Summary string `json:"summary"`
|
|
RelevantFiles []string `json:"relevantFiles"`
|
|
SuggestedFix string `json:"suggestedFix"`
|
|
RelatedIssues []string `json:"relatedIssues"`
|
|
Complexity string `json:"complexity"`
|
|
EstimatedTime string `json:"estimatedTime"`
|
|
PreparedAt time.Time `json:"preparedAt"`
|
|
}
|
|
|
|
// QueueService manages the priority queue of issues.
|
|
type QueueService struct {
|
|
config *ConfigService
|
|
issues issueHeap
|
|
seen map[string]bool
|
|
current *Issue
|
|
mu sync.RWMutex
|
|
}
|
|
|
|
// issueHeap implements heap.Interface for priority queue.
|
|
type issueHeap []*Issue
|
|
|
|
func (h issueHeap) Len() int { return len(h) }
|
|
func (h issueHeap) Less(i, j int) bool { return h[i].Priority > h[j].Priority } // Higher priority first
|
|
func (h issueHeap) Swap(i, j int) {
|
|
h[i], h[j] = h[j], h[i]
|
|
h[i].index = i
|
|
h[j].index = j
|
|
}
|
|
|
|
func (h *issueHeap) Push(x any) {
|
|
n := len(*h)
|
|
item := x.(*Issue)
|
|
item.index = n
|
|
*h = append(*h, item)
|
|
}
|
|
|
|
func (h *issueHeap) Pop() any {
|
|
old := *h
|
|
n := len(old)
|
|
item := old[n-1]
|
|
old[n-1] = nil
|
|
item.index = -1
|
|
*h = old[0 : n-1]
|
|
return item
|
|
}
|
|
|
|
// NewQueueService creates a new QueueService.
|
|
func NewQueueService(config *ConfigService) *QueueService {
|
|
q := &QueueService{
|
|
config: config,
|
|
issues: make(issueHeap, 0),
|
|
seen: make(map[string]bool),
|
|
}
|
|
heap.Init(&q.issues)
|
|
q.load() // Load persisted queue
|
|
return q
|
|
}
|
|
|
|
// ServiceName returns the service name for Wails.
|
|
func (q *QueueService) ServiceName() string {
|
|
return "QueueService"
|
|
}
|
|
|
|
// Add adds issues to the queue, deduplicating by ID.
|
|
func (q *QueueService) Add(issues []*Issue) int {
|
|
q.mu.Lock()
|
|
defer q.mu.Unlock()
|
|
|
|
added := 0
|
|
for _, issue := range issues {
|
|
if q.seen[issue.ID] {
|
|
continue
|
|
}
|
|
q.seen[issue.ID] = true
|
|
issue.Status = StatusPending
|
|
heap.Push(&q.issues, issue)
|
|
added++
|
|
}
|
|
|
|
if added > 0 {
|
|
q.save()
|
|
}
|
|
return added
|
|
}
|
|
|
|
// Size returns the number of issues in the queue.
|
|
func (q *QueueService) Size() int {
|
|
q.mu.RLock()
|
|
defer q.mu.RUnlock()
|
|
return len(q.issues)
|
|
}
|
|
|
|
// CurrentIssue returns the issue currently being worked on.
|
|
func (q *QueueService) CurrentIssue() *Issue {
|
|
q.mu.RLock()
|
|
defer q.mu.RUnlock()
|
|
return q.current
|
|
}
|
|
|
|
// Next claims and returns the next issue from the queue.
|
|
func (q *QueueService) Next() *Issue {
|
|
q.mu.Lock()
|
|
defer q.mu.Unlock()
|
|
|
|
if len(q.issues) == 0 {
|
|
return nil
|
|
}
|
|
|
|
// Pop the highest priority issue
|
|
issue := heap.Pop(&q.issues).(*Issue)
|
|
issue.Status = StatusClaimed
|
|
issue.ClaimedAt = time.Now()
|
|
q.current = issue
|
|
q.save()
|
|
return issue
|
|
}
|
|
|
|
// Skip marks the current issue as skipped and moves to the next.
|
|
func (q *QueueService) Skip() {
|
|
q.mu.Lock()
|
|
defer q.mu.Unlock()
|
|
|
|
if q.current != nil {
|
|
q.current.Status = StatusSkipped
|
|
q.current = nil
|
|
q.save()
|
|
}
|
|
}
|
|
|
|
// Complete marks the current issue as completed.
|
|
func (q *QueueService) Complete() {
|
|
q.mu.Lock()
|
|
defer q.mu.Unlock()
|
|
|
|
if q.current != nil {
|
|
q.current.Status = StatusCompleted
|
|
q.current = nil
|
|
q.save()
|
|
}
|
|
}
|
|
|
|
// SetInProgress marks the current issue as in progress.
|
|
func (q *QueueService) SetInProgress() {
|
|
q.mu.Lock()
|
|
defer q.mu.Unlock()
|
|
|
|
if q.current != nil {
|
|
q.current.Status = StatusInProgress
|
|
q.save()
|
|
}
|
|
}
|
|
|
|
// SetContext sets the AI-prepared context for the current issue.
|
|
func (q *QueueService) SetContext(ctx *IssueContext) {
|
|
q.mu.Lock()
|
|
defer q.mu.Unlock()
|
|
|
|
if q.current != nil {
|
|
q.current.Context = ctx
|
|
q.save()
|
|
}
|
|
}
|
|
|
|
// GetPending returns all pending issues.
|
|
func (q *QueueService) GetPending() []*Issue {
|
|
q.mu.RLock()
|
|
defer q.mu.RUnlock()
|
|
|
|
result := make([]*Issue, 0, len(q.issues))
|
|
for _, issue := range q.issues {
|
|
if issue.Status == StatusPending {
|
|
result = append(result, issue)
|
|
}
|
|
}
|
|
return result
|
|
}
|
|
|
|
// Clear removes all issues from the queue.
|
|
func (q *QueueService) Clear() {
|
|
q.mu.Lock()
|
|
defer q.mu.Unlock()
|
|
|
|
q.issues = make(issueHeap, 0)
|
|
q.seen = make(map[string]bool)
|
|
q.current = nil
|
|
heap.Init(&q.issues)
|
|
q.save()
|
|
}
|
|
|
|
// queueState represents the persisted queue state.
|
|
type queueState struct {
|
|
Issues []*Issue `json:"issues"`
|
|
Current *Issue `json:"current"`
|
|
Seen []string `json:"seen"`
|
|
}
|
|
|
|
// save persists the queue to disk.
|
|
func (q *QueueService) save() {
|
|
dataDir := q.config.GetDataDir()
|
|
if dataDir == "" {
|
|
return
|
|
}
|
|
|
|
path := filepath.Join(dataDir, "queue.json")
|
|
|
|
seen := make([]string, 0, len(q.seen))
|
|
for id := range q.seen {
|
|
seen = append(seen, id)
|
|
}
|
|
|
|
state := queueState{
|
|
Issues: []*Issue(q.issues),
|
|
Current: q.current,
|
|
Seen: seen,
|
|
}
|
|
|
|
data, err := json.MarshalIndent(state, "", " ")
|
|
if err != nil {
|
|
log.Printf("Failed to marshal queue: %v", err)
|
|
return
|
|
}
|
|
|
|
if err := os.WriteFile(path, data, 0644); err != nil {
|
|
log.Printf("Failed to save queue: %v", err)
|
|
}
|
|
}
|
|
|
|
// load restores the queue from disk.
|
|
func (q *QueueService) load() {
|
|
dataDir := q.config.GetDataDir()
|
|
if dataDir == "" {
|
|
return
|
|
}
|
|
|
|
path := filepath.Join(dataDir, "queue.json")
|
|
data, err := os.ReadFile(path)
|
|
if err != nil {
|
|
if !os.IsNotExist(err) {
|
|
log.Printf("Failed to read queue: %v", err)
|
|
}
|
|
return
|
|
}
|
|
|
|
var state queueState
|
|
if err := json.Unmarshal(data, &state); err != nil {
|
|
log.Printf("Failed to unmarshal queue: %v", err)
|
|
return
|
|
}
|
|
|
|
q.issues = state.Issues
|
|
heap.Init(&q.issues)
|
|
q.current = state.Current
|
|
q.seen = make(map[string]bool)
|
|
for _, id := range state.Seen {
|
|
q.seen[id] = true
|
|
}
|
|
}
|