cli/pkg/i18n/i18n_test.go
Vi 4debdc1449 feat: BugSETI app, WebSocket hub, browser automation, and MCP tools (#336)
* feat: add security logging and fix framework regressions

This commit implements comprehensive security event logging and resolves critical regressions in the core framework.

Security Logging:
- Enhanced `pkg/log` with a `Security` level and helper.
- Added `log.Username()` to consistently identify the executing user.
- Instrumented GitHub CLI auth, Agentic configuration, filesystem sandbox, MCP handlers, and MCP TCP transport with security logs.
- Added `SecurityStyle` to the CLI for consistent visual representation of security events.

UniFi Security (CodeQL):
- Refactored `pkg/unifi` to remove hardcoded `InsecureSkipVerify`, resolving a high-severity alert.
- Added a `--verify-tls` flag and configuration option to control TLS verification.
- Updated command handlers to support the new verification parameter.

Framework Fixes:
- Restored original signatures for `MustServiceFor`, `Config()`, and `Display()` in `pkg/framework/core`, which had been corrupted during a merge.
- Fixed `pkg/framework/framework.go` and `pkg/framework/core/runtime_pkg.go` to match the restored signatures.
- These fixes resolve project-wide compilation errors caused by the signature mismatches.

I encountered significant blockers due to a corrupted state of the `dev` branch after a merge, which introduced breaking changes in the core framework's DI system. I had to manually reconcile these signatures with the expected usage across the codebase to restore build stability.

* feat(mcp): add RAG tools (query, ingest, collections)

Add vector database tools to the MCP server for RAG operations:
- rag_query: Search for relevant documentation using semantic similarity
- rag_ingest: Ingest files or directories into the vector database
- rag_collections: List available collections

Uses existing internal/cmd/rag exports (QueryDocs, IngestDirectory, IngestFile)
and pkg/rag for Qdrant client access. Default collection is "hostuk-docs"
with topK=5 for queries.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(mcp): add metrics tools (record, query)

Add MCP tools for recording and querying AI/security metrics events.
The metrics_record tool writes events to daily JSONL files, and the
metrics_query tool provides aggregated statistics by type, repo, and agent.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: add 'core mcp serve' command

Add CLI command to start the MCP server for AI tool integration.

- Create internal/cmd/mcpcmd package with serve subcommand
- Support --workspace flag for directory restriction
- Handle SIGINT/SIGTERM for clean shutdown
- Register in full.go build variant

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(ws): add WebSocket hub package for real-time streaming

Add pkg/ws package implementing a hub pattern for WebSocket connections:
- Hub manages client connections, broadcasts, and channel subscriptions
- Client struct represents connected WebSocket clients
- Message types: process_output, process_status, event, error, ping/pong
- Channel-based subscription system (subscribe/unsubscribe)
- SendProcessOutput and SendProcessStatus for process streaming integration
- Full test coverage including concurrency tests

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(mcp): add process management and WebSocket MCP tools

Add MCP tools for process management:
- process_start: Start a new external process
- process_stop: Gracefully stop a running process
- process_kill: Force kill a process
- process_list: List all managed processes
- process_output: Get captured process output
- process_input: Send input to process stdin

Add MCP tools for WebSocket:
- ws_start: Start WebSocket server for real-time streaming
- ws_info: Get hub statistics (clients, channels)

Update Service struct with optional process.Service and ws.Hub fields,
new WithProcessService and WithWSHub options, getter methods, and
Shutdown method for cleanup.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(webview): add browser automation package via Chrome DevTools Protocol

Add pkg/webview package for browser automation:
- webview.go: Main interface with Connect, Navigate, Click, Type, QuerySelector, Screenshot, Evaluate
- cdp.go: Chrome DevTools Protocol WebSocket client implementation
- actions.go: DOM action types (Click, Type, Hover, Scroll, etc.) and ActionSequence builder
- console.go: Console message capture and filtering with ConsoleWatcher and ExceptionWatcher
- angular.go: Angular-specific helpers for router navigation, component access, and Zone.js stability

Add MCP tools for webview:
- webview_connect/disconnect: Connection management
- webview_navigate: Page navigation
- webview_click/type/query/wait: DOM interaction
- webview_console: Console output capture
- webview_eval: JavaScript execution
- webview_screenshot: Screenshot capture

Add documentation:
- docs/mcp/angular-testing.md: Guide for Angular application testing

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* docs: document new packages and BugSETI application

- Update CLAUDE.md with documentation for:
  - pkg/ws (WebSocket hub for real-time streaming)
  - pkg/webview (Browser automation via CDP)
  - pkg/mcp (MCP server tools: process, ws, webview)
  - BugSETI application overview
- Add comprehensive README for BugSETI with:
  - Installation and configuration guide
  - Usage workflow documentation
  - Architecture overview
  - Contributing guidelines

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(bugseti): add BugSETI system tray app with auto-update

BugSETI - Distributed Bug Fixing like SETI@home but for code

Features:
- System tray app with Wails v3
- GitHub issue fetching with label filters
- Issue queue with priority management
- AI context seeding via seed-agent-developer skill
- Automated PR submission flow
- Stats tracking and leaderboard
- Cross-platform notifications
- Self-updating with stable/beta/nightly channels

Includes:
- cmd/bugseti: Main application with Angular frontend
- internal/bugseti: Core services (fetcher, queue, seeder, submit, config, stats, notify)
- internal/bugseti/updater: Auto-update system (checker, downloader, installer)
- .github/workflows/bugseti-release.yml: CI/CD for all platforms

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: resolve import cycle and code duplication

- Remove pkg/log import from pkg/io/local to break import cycle
  (pkg/log/rotation.go imports pkg/io, creating circular dependency)
- Use stderr logging for security events in sandbox escape detection
- Remove unused sync/atomic import from core.go
- Fix duplicate LogSecurity function declarations in cli/log.go
- Update workspace/service.go Crypt() call to match interface

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: update tests for new function signatures and format code

- Update core_test.go: Config(), Display() now panic instead of returning error
- Update runtime_pkg_test.go: sr.Config() now panics instead of returning error
- Update MustServiceFor tests to use assert.Panics
- Format BugSETI, MCP tools, and webview packages with gofmt

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Snider <631881+Snider@users.noreply.github.com>
Co-authored-by: Claude <developers@lethean.io>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-05 17:22:05 +00:00

582 lines
14 KiB
Go

package i18n
import (
"sync"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestNew(t *testing.T) {
svc, err := New()
require.NoError(t, err)
require.NotNil(t, svc)
// Should have English available
langs := svc.AvailableLanguages()
assert.Contains(t, langs, "en-GB")
}
func TestTranslate(t *testing.T) {
svc, err := New()
require.NoError(t, err)
// Basic translation
result := svc.T("cmd.dev.short")
assert.Equal(t, "Multi-repo development workflow", result)
// Missing key returns the key
result = svc.T("nonexistent.key")
assert.Equal(t, "nonexistent.key", result)
}
func TestTranslateWithArgs(t *testing.T) {
svc, err := New()
require.NoError(t, err)
// Translation with template data
result := svc.T("error.repo_not_found", map[string]string{"Name": "config.yaml"})
assert.Equal(t, "Repository 'config.yaml' not found", result)
result = svc.T("cmd.ai.task_pr.branch_error", map[string]string{"Branch": "main"})
assert.Equal(t, "cannot create PR from main branch; create a feature branch first", result)
}
func TestSetLanguage(t *testing.T) {
// Clear locale env vars to ensure fallback to en-GB
t.Setenv("LANG", "")
t.Setenv("LC_ALL", "")
t.Setenv("LC_MESSAGES", "")
svc, err := New()
require.NoError(t, err)
// Default is en-GB (when no system locale detected)
assert.Equal(t, "en-GB", svc.Language())
// Setting invalid language should error
err = svc.SetLanguage("xx-invalid")
assert.Error(t, err)
// Language should still be en-GB
assert.Equal(t, "en-GB", svc.Language())
}
func TestDefaultService(t *testing.T) {
// Reset default for test
defaultService.Store(nil)
defaultOnce = sync.Once{}
defaultErr = nil
err := Init()
require.NoError(t, err)
svc := Default()
require.NotNil(t, svc)
// Global T function should work
result := T("cmd.dev.short")
assert.Equal(t, "Multi-repo development workflow", result)
}
func TestAddMessages(t *testing.T) {
svc, err := New()
require.NoError(t, err)
// Add custom messages
svc.AddMessages("en-GB", map[string]string{
"custom.greeting": "Hello, {{.Name}}!",
})
result := svc.T("custom.greeting", map[string]string{"Name": "World"})
assert.Equal(t, "Hello, World!", result)
}
func TestAvailableLanguages(t *testing.T) {
svc, err := New()
require.NoError(t, err)
langs := svc.AvailableLanguages()
assert.NotEmpty(t, langs)
assert.Contains(t, langs, "en-GB")
}
func TestDetectLanguage(t *testing.T) {
tests := []struct {
name string
langEnv string
expected string
}{
{
name: "English exact",
langEnv: "en-GB",
expected: "en-GB",
},
{
name: "English with encoding",
langEnv: "en_GB.UTF-8",
expected: "en-GB",
},
{
name: "Empty LANG",
langEnv: "",
expected: "",
},
}
svc, err := New()
require.NoError(t, err)
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Setenv("LANG", tt.langEnv)
t.Setenv("LC_ALL", "")
t.Setenv("LC_MESSAGES", "")
result := detectLanguage(svc.availableLangs)
assert.Equal(t, tt.expected, result)
})
}
}
func TestPluralization(t *testing.T) {
svc, err := New()
require.NoError(t, err)
SetDefault(svc)
// Singular - uses i18n.count.* magic
result := svc.T("i18n.count.item", 1)
assert.Equal(t, "1 item", result)
// Plural
result = svc.T("i18n.count.item", 5)
assert.Equal(t, "5 items", result)
// Zero uses plural
result = svc.T("i18n.count.item", 0)
assert.Equal(t, "0 items", result)
}
func TestNestedKeys(t *testing.T) {
svc, err := New()
require.NoError(t, err)
// Nested key
result := svc.T("cmd.dev.short")
assert.Equal(t, "Multi-repo development workflow", result)
// Deeper nested key (flat key with dots)
result = svc.T("cmd.dev.push.short")
assert.Equal(t, "Push commits across all repos", result)
}
func TestMessage_ForCategory(t *testing.T) {
t.Run("basic categories", func(t *testing.T) {
msg := Message{
Zero: "no items",
One: "1 item",
Two: "2 items",
Few: "a few items",
Many: "many items",
Other: "some items",
}
assert.Equal(t, "no items", msg.ForCategory(PluralZero))
assert.Equal(t, "1 item", msg.ForCategory(PluralOne))
assert.Equal(t, "2 items", msg.ForCategory(PluralTwo))
assert.Equal(t, "a few items", msg.ForCategory(PluralFew))
assert.Equal(t, "many items", msg.ForCategory(PluralMany))
assert.Equal(t, "some items", msg.ForCategory(PluralOther))
})
t.Run("fallback to other", func(t *testing.T) {
msg := Message{
One: "1 item",
Other: "items",
}
// Categories without explicit values fall back to Other
assert.Equal(t, "items", msg.ForCategory(PluralZero))
assert.Equal(t, "1 item", msg.ForCategory(PluralOne))
assert.Equal(t, "items", msg.ForCategory(PluralFew))
})
t.Run("fallback to one then text", func(t *testing.T) {
msg := Message{
One: "single item",
}
// Falls back to One when Other is empty
assert.Equal(t, "single item", msg.ForCategory(PluralOther))
assert.Equal(t, "single item", msg.ForCategory(PluralMany))
})
}
func TestServiceFormality(t *testing.T) {
svc, err := New()
require.NoError(t, err)
t.Run("default is neutral", func(t *testing.T) {
assert.Equal(t, FormalityNeutral, svc.Formality())
})
t.Run("set formality", func(t *testing.T) {
svc.SetFormality(FormalityFormal)
assert.Equal(t, FormalityFormal, svc.Formality())
svc.SetFormality(FormalityInformal)
assert.Equal(t, FormalityInformal, svc.Formality())
})
}
func TestServiceDirection(t *testing.T) {
svc, err := New()
require.NoError(t, err)
t.Run("English is LTR", func(t *testing.T) {
err := svc.SetLanguage("en-GB")
require.NoError(t, err)
assert.Equal(t, DirLTR, svc.Direction())
assert.False(t, svc.IsRTL())
})
}
func TestServicePluralCategory(t *testing.T) {
svc, err := New()
require.NoError(t, err)
t.Run("English plural rules", func(t *testing.T) {
assert.Equal(t, PluralOne, svc.PluralCategory(1))
assert.Equal(t, PluralOther, svc.PluralCategory(0))
assert.Equal(t, PluralOther, svc.PluralCategory(5))
})
}
func TestDebugMode(t *testing.T) {
t.Run("default is disabled", func(t *testing.T) {
svc, err := New()
require.NoError(t, err)
assert.False(t, svc.Debug())
})
t.Run("T with debug mode", func(t *testing.T) {
svc, err := New()
require.NoError(t, err)
// Without debug
result := svc.T("cmd.dev.short")
assert.Equal(t, "Multi-repo development workflow", result)
// Enable debug
svc.SetDebug(true)
assert.True(t, svc.Debug())
// With debug - shows key prefix
result = svc.T("cmd.dev.short")
assert.Equal(t, "[cmd.dev.short] Multi-repo development workflow", result)
// Disable debug
svc.SetDebug(false)
result = svc.T("cmd.dev.short")
assert.Equal(t, "Multi-repo development workflow", result)
})
t.Run("package-level SetDebug", func(t *testing.T) {
// Reset default
defaultService.Store(nil)
defaultOnce = sync.Once{}
defaultErr = nil
err := Init()
require.NoError(t, err)
// Enable debug via package function
SetDebug(true)
assert.True(t, Default().Debug())
// Translate
result := T("cmd.dev.short")
assert.Equal(t, "[cmd.dev.short] Multi-repo development workflow", result)
// Cleanup
SetDebug(false)
})
}
func TestI18nNamespaceMagic(t *testing.T) {
svc, err := New()
require.NoError(t, err)
SetDefault(svc)
tests := []struct {
name string
key string
args []any
expected string
}{
{"label", "i18n.label.status", nil, "Status:"},
{"label version", "i18n.label.version", nil, "Version:"},
{"progress", "i18n.progress.build", nil, "Building..."},
{"progress check", "i18n.progress.check", nil, "Checking..."},
{"progress with subject", "i18n.progress.check", []any{"config"}, "Checking config..."},
{"count singular", "i18n.count.file", []any{1}, "1 file"},
{"count plural", "i18n.count.file", []any{5}, "5 files"},
{"done", "i18n.done.delete", []any{"file"}, "File deleted"},
{"done build", "i18n.done.build", []any{"project"}, "Project built"},
{"fail", "i18n.fail.delete", []any{"file"}, "Failed to delete file"},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := svc.T(tt.key, tt.args...)
assert.Equal(t, tt.expected, result)
})
}
}
func TestRawBypassesI18nNamespace(t *testing.T) {
svc, err := New()
require.NoError(t, err)
// Raw() should return key as-is since i18n.label.status isn't in JSON
result := svc.Raw("i18n.label.status")
assert.Equal(t, "i18n.label.status", result)
// T() should compose it
result = svc.T("i18n.label.status")
assert.Equal(t, "Status:", result)
}
func TestFormalityMessageSelection(t *testing.T) {
svc, err := New()
require.NoError(t, err)
// Add test messages with formality variants
svc.AddMessages("en-GB", map[string]string{
"greeting": "Hello",
"greeting._formal": "Good morning, sir",
"greeting._informal": "Hey there",
"farewell": "Goodbye",
"farewell._formal": "Farewell",
})
t.Run("neutral formality uses base key", func(t *testing.T) {
svc.SetFormality(FormalityNeutral)
assert.Equal(t, "Hello", svc.T("greeting"))
assert.Equal(t, "Goodbye", svc.T("farewell"))
})
t.Run("formal uses ._formal variant", func(t *testing.T) {
svc.SetFormality(FormalityFormal)
assert.Equal(t, "Good morning, sir", svc.T("greeting"))
assert.Equal(t, "Farewell", svc.T("farewell"))
})
t.Run("informal uses ._informal variant", func(t *testing.T) {
svc.SetFormality(FormalityInformal)
assert.Equal(t, "Hey there", svc.T("greeting"))
// No informal variant for farewell, falls back to base
assert.Equal(t, "Goodbye", svc.T("farewell"))
})
t.Run("subject formality overrides service formality", func(t *testing.T) {
svc.SetFormality(FormalityNeutral)
// Subject with formal overrides neutral service
result := svc.T("greeting", S("user", "test").Formal())
assert.Equal(t, "Good morning, sir", result)
// Subject with informal overrides neutral service
result = svc.T("greeting", S("user", "test").Informal())
assert.Equal(t, "Hey there", result)
})
t.Run("subject formality overrides service formal", func(t *testing.T) {
svc.SetFormality(FormalityFormal)
// Subject with informal overrides formal service
result := svc.T("greeting", S("user", "test").Informal())
assert.Equal(t, "Hey there", result)
})
t.Run("context formality overrides service formality", func(t *testing.T) {
svc.SetFormality(FormalityNeutral)
// TranslationContext with formal overrides neutral service
result := svc.T("greeting", C("user greeting").Formal())
assert.Equal(t, "Good morning, sir", result)
// TranslationContext with informal overrides neutral service
result = svc.T("greeting", C("user greeting").Informal())
assert.Equal(t, "Hey there", result)
})
t.Run("context formality overrides service formal", func(t *testing.T) {
svc.SetFormality(FormalityFormal)
// TranslationContext with informal overrides formal service
result := svc.T("greeting", C("user greeting").Informal())
assert.Equal(t, "Hey there", result)
})
}
func TestNewWithOptions(t *testing.T) {
t.Run("WithFallback", func(t *testing.T) {
svc, err := New(WithFallback("de-DE"))
require.NoError(t, err)
assert.Equal(t, "de-DE", svc.fallbackLang)
})
t.Run("WithFormality", func(t *testing.T) {
svc, err := New(WithFormality(FormalityFormal))
require.NoError(t, err)
assert.Equal(t, FormalityFormal, svc.Formality())
})
t.Run("WithMode", func(t *testing.T) {
svc, err := New(WithMode(ModeStrict))
require.NoError(t, err)
assert.Equal(t, ModeStrict, svc.Mode())
})
t.Run("WithDebug", func(t *testing.T) {
svc, err := New(WithDebug(true))
require.NoError(t, err)
assert.True(t, svc.Debug())
})
t.Run("WithHandlers replaces defaults", func(t *testing.T) {
customHandler := LabelHandler{}
svc, err := New(WithHandlers(customHandler))
require.NoError(t, err)
assert.Len(t, svc.Handlers(), 1)
})
t.Run("WithDefaultHandlers adds back defaults", func(t *testing.T) {
svc, err := New(WithHandlers(), WithDefaultHandlers())
require.NoError(t, err)
assert.Len(t, svc.Handlers(), 6) // 6 default handlers
})
t.Run("multiple options", func(t *testing.T) {
svc, err := New(
WithFallback("fr-FR"),
WithFormality(FormalityInformal),
WithMode(ModeCollect),
WithDebug(true),
)
require.NoError(t, err)
assert.Equal(t, "fr-FR", svc.fallbackLang)
assert.Equal(t, FormalityInformal, svc.Formality())
assert.Equal(t, ModeCollect, svc.Mode())
assert.True(t, svc.Debug())
})
}
func TestNewWithLoader(t *testing.T) {
t.Run("uses custom loader", func(t *testing.T) {
loader := NewFSLoader(localeFS, "locales")
svc, err := NewWithLoader(loader)
require.NoError(t, err)
assert.NotNil(t, svc.loader)
assert.Contains(t, svc.AvailableLanguages(), "en-GB")
})
t.Run("with options", func(t *testing.T) {
loader := NewFSLoader(localeFS, "locales")
svc, err := NewWithLoader(loader, WithFallback("de-DE"), WithFormality(FormalityFormal))
require.NoError(t, err)
assert.Equal(t, "de-DE", svc.fallbackLang)
assert.Equal(t, FormalityFormal, svc.Formality())
})
}
func TestNewWithFS(t *testing.T) {
t.Run("with options", func(t *testing.T) {
svc, err := NewWithFS(localeFS, "locales", WithDebug(true))
require.NoError(t, err)
assert.True(t, svc.Debug())
})
}
func TestConcurrentTranslation(t *testing.T) {
svc, err := New()
require.NoError(t, err)
t.Run("concurrent T calls", func(t *testing.T) {
var wg sync.WaitGroup
for i := 0; i < 100; i++ {
wg.Add(1)
go func() {
defer wg.Done()
result := svc.T("cmd.dev.short")
assert.Equal(t, "Multi-repo development workflow", result)
}()
}
wg.Wait()
})
t.Run("concurrent T with args", func(t *testing.T) {
var wg sync.WaitGroup
for i := 0; i < 100; i++ {
wg.Add(1)
go func(n int) {
defer wg.Done()
result := svc.T("i18n.count.file", n)
if n == 1 {
assert.Equal(t, "1 file", result)
} else {
assert.Contains(t, result, "files")
}
}(i)
}
wg.Wait()
})
t.Run("concurrent read and write", func(t *testing.T) {
var wg sync.WaitGroup
// Readers
for i := 0; i < 50; i++ {
wg.Add(1)
go func() {
defer wg.Done()
_ = svc.T("cmd.dev.short")
_ = svc.Language()
_ = svc.Formality()
}()
}
// Writers
for i := 0; i < 10; i++ {
wg.Add(1)
go func() {
defer wg.Done()
svc.SetFormality(FormalityNeutral)
svc.SetDebug(false)
}()
}
wg.Wait()
})
}
func TestConcurrentDefault(t *testing.T) {
// Reset for test
defaultService.Store(nil)
defaultOnce = sync.Once{}
defaultErr = nil
var wg sync.WaitGroup
for i := 0; i < 50; i++ {
wg.Add(1)
go func() {
defer wg.Done()
svc := Default()
assert.NotNil(t, svc)
}()
}
wg.Wait()
}