cli/pkg/release/publishers/scoop_test.go
Snider f2bc912ebe feat: infrastructure packages and lint cleanup (#281)
* ci: consolidate duplicate workflows and merge CodeQL configs

Remove 17 duplicate workflow files that were split copies of the
combined originals. Each family (CI, CodeQL, Coverage, PR Build,
Alpha Release) had the same job duplicated across separate
push/pull_request/schedule/manual trigger files.

Merge codeql.yml and codescan.yml into a single codeql.yml with
a language matrix covering go, javascript-typescript, python,
and actions — matching the previous default setup coverage.

Remaining workflows (one per family):
- ci.yml (push + PR + manual)
- codeql.yml (push + PR + schedule, all languages)
- coverage.yml (push + PR + manual)
- alpha-release.yml (push + manual)
- pr-build.yml (PR + manual)
- release.yml (tag push)
- agent-verify.yml, auto-label.yml, auto-project.yml

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: add collect, config, crypt, plugin packages and fix all lint issues

Add four new infrastructure packages with CLI commands:
- pkg/config: layered configuration (defaults → file → env → flags)
- pkg/crypt: crypto primitives (Argon2id, AES-GCM, ChaCha20, HMAC, checksums)
- pkg/plugin: plugin system with GitHub-based install/update/remove
- pkg/collect: collection subsystem (GitHub, BitcoinTalk, market, papers, excavate)

Fix all golangci-lint issues across the entire codebase (~100 errcheck,
staticcheck SA1012/SA1019/ST1005, unused, ineffassign fixes) so that
`core go qa` passes with 0 issues.

Closes #167, #168, #170, #250, #251, #252, #253, #254, #255, #256

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 11:34:43 +00:00

308 lines
8 KiB
Go

package publishers
import (
"bytes"
"context"
"os"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestScoopPublisher_Name_Good(t *testing.T) {
t.Run("returns scoop", func(t *testing.T) {
p := NewScoopPublisher()
assert.Equal(t, "scoop", p.Name())
})
}
func TestScoopPublisher_ParseConfig_Good(t *testing.T) {
p := NewScoopPublisher()
t.Run("uses defaults when no extended config", func(t *testing.T) {
pubCfg := PublisherConfig{Type: "scoop"}
relCfg := &mockReleaseConfig{repository: "owner/repo"}
cfg := p.parseConfig(pubCfg, relCfg)
assert.Empty(t, cfg.Bucket)
assert.Nil(t, cfg.Official)
})
t.Run("parses bucket from extended config", func(t *testing.T) {
pubCfg := PublisherConfig{
Type: "scoop",
Extended: map[string]any{
"bucket": "host-uk/scoop-bucket",
},
}
relCfg := &mockReleaseConfig{repository: "owner/repo"}
cfg := p.parseConfig(pubCfg, relCfg)
assert.Equal(t, "host-uk/scoop-bucket", cfg.Bucket)
})
t.Run("parses official config", func(t *testing.T) {
pubCfg := PublisherConfig{
Type: "scoop",
Extended: map[string]any{
"official": map[string]any{
"enabled": true,
"output": "dist/scoop-manifest",
},
},
}
relCfg := &mockReleaseConfig{repository: "owner/repo"}
cfg := p.parseConfig(pubCfg, relCfg)
require.NotNil(t, cfg.Official)
assert.True(t, cfg.Official.Enabled)
assert.Equal(t, "dist/scoop-manifest", cfg.Official.Output)
})
t.Run("handles missing official fields", func(t *testing.T) {
pubCfg := PublisherConfig{
Type: "scoop",
Extended: map[string]any{
"official": map[string]any{},
},
}
relCfg := &mockReleaseConfig{repository: "owner/repo"}
cfg := p.parseConfig(pubCfg, relCfg)
require.NotNil(t, cfg.Official)
assert.False(t, cfg.Official.Enabled)
assert.Empty(t, cfg.Official.Output)
})
t.Run("handles nil extended config", func(t *testing.T) {
pubCfg := PublisherConfig{
Type: "scoop",
Extended: nil,
}
relCfg := &mockReleaseConfig{repository: "owner/repo"}
cfg := p.parseConfig(pubCfg, relCfg)
assert.Empty(t, cfg.Bucket)
assert.Nil(t, cfg.Official)
})
}
func TestScoopPublisher_RenderTemplate_Good(t *testing.T) {
p := NewScoopPublisher()
t.Run("renders manifest template with data", func(t *testing.T) {
data := scoopTemplateData{
PackageName: "myapp",
Description: "My awesome CLI",
Repository: "owner/myapp",
Version: "1.2.3",
License: "MIT",
BinaryName: "myapp",
Checksums: ChecksumMap{
WindowsAmd64: "abc123",
WindowsArm64: "def456",
},
}
result, err := p.renderTemplate("templates/scoop/manifest.json.tmpl", data)
require.NoError(t, err)
assert.Contains(t, result, `"version": "1.2.3"`)
assert.Contains(t, result, `"description": "My awesome CLI"`)
assert.Contains(t, result, `"homepage": "https://github.com/owner/myapp"`)
assert.Contains(t, result, `"license": "MIT"`)
assert.Contains(t, result, `"64bit"`)
assert.Contains(t, result, `"arm64"`)
assert.Contains(t, result, "myapp-windows-amd64.zip")
assert.Contains(t, result, "myapp-windows-arm64.zip")
assert.Contains(t, result, `"hash": "abc123"`)
assert.Contains(t, result, `"hash": "def456"`)
assert.Contains(t, result, `"bin": "myapp.exe"`)
})
t.Run("includes autoupdate configuration", func(t *testing.T) {
data := scoopTemplateData{
PackageName: "tool",
Description: "A tool",
Repository: "org/tool",
Version: "2.0.0",
License: "Apache-2.0",
BinaryName: "tool",
Checksums: ChecksumMap{},
}
result, err := p.renderTemplate("templates/scoop/manifest.json.tmpl", data)
require.NoError(t, err)
assert.Contains(t, result, `"checkver"`)
assert.Contains(t, result, `"github": "https://github.com/org/tool"`)
assert.Contains(t, result, `"autoupdate"`)
})
}
func TestScoopPublisher_RenderTemplate_Bad(t *testing.T) {
p := NewScoopPublisher()
t.Run("returns error for non-existent template", func(t *testing.T) {
data := scoopTemplateData{}
_, err := p.renderTemplate("templates/scoop/nonexistent.tmpl", data)
assert.Error(t, err)
assert.Contains(t, err.Error(), "failed to read template")
})
}
func TestScoopPublisher_DryRunPublish_Good(t *testing.T) {
p := NewScoopPublisher()
t.Run("outputs expected dry run information", func(t *testing.T) {
oldStdout := os.Stdout
r, w, _ := os.Pipe()
os.Stdout = w
data := scoopTemplateData{
PackageName: "myapp",
Version: "1.0.0",
Repository: "owner/repo",
BinaryName: "myapp",
Checksums: ChecksumMap{},
}
cfg := ScoopConfig{
Bucket: "owner/scoop-bucket",
}
err := p.dryRunPublish(data, cfg)
_ = w.Close()
var buf bytes.Buffer
_, _ = buf.ReadFrom(r)
os.Stdout = oldStdout
require.NoError(t, err)
output := buf.String()
assert.Contains(t, output, "DRY RUN: Scoop Publish")
assert.Contains(t, output, "Package: myapp")
assert.Contains(t, output, "Version: 1.0.0")
assert.Contains(t, output, "Bucket: owner/scoop-bucket")
assert.Contains(t, output, "Repository: owner/repo")
assert.Contains(t, output, "Generated manifest.json:")
assert.Contains(t, output, "Would commit to bucket: owner/scoop-bucket")
assert.Contains(t, output, "END DRY RUN")
})
t.Run("shows official output path when enabled", func(t *testing.T) {
oldStdout := os.Stdout
r, w, _ := os.Pipe()
os.Stdout = w
data := scoopTemplateData{
PackageName: "myapp",
Version: "1.0.0",
BinaryName: "myapp",
Checksums: ChecksumMap{},
}
cfg := ScoopConfig{
Official: &OfficialConfig{
Enabled: true,
Output: "custom/scoop/path",
},
}
err := p.dryRunPublish(data, cfg)
_ = w.Close()
var buf bytes.Buffer
_, _ = buf.ReadFrom(r)
os.Stdout = oldStdout
require.NoError(t, err)
output := buf.String()
assert.Contains(t, output, "Would write files for official PR to: custom/scoop/path")
})
t.Run("uses default official output path when not specified", func(t *testing.T) {
oldStdout := os.Stdout
r, w, _ := os.Pipe()
os.Stdout = w
data := scoopTemplateData{
PackageName: "myapp",
Version: "1.0.0",
BinaryName: "myapp",
Checksums: ChecksumMap{},
}
cfg := ScoopConfig{
Official: &OfficialConfig{
Enabled: true,
},
}
err := p.dryRunPublish(data, cfg)
_ = w.Close()
var buf bytes.Buffer
_, _ = buf.ReadFrom(r)
os.Stdout = oldStdout
require.NoError(t, err)
output := buf.String()
assert.Contains(t, output, "Would write files for official PR to: dist/scoop")
})
}
func TestScoopPublisher_Publish_Bad(t *testing.T) {
p := NewScoopPublisher()
t.Run("fails when bucket not configured and not official mode", func(t *testing.T) {
release := &Release{
Version: "v1.0.0",
ProjectDir: "/project",
}
pubCfg := PublisherConfig{Type: "scoop"}
relCfg := &mockReleaseConfig{repository: "owner/repo"}
err := p.Publish(context.TODO(), release, pubCfg, relCfg, false)
assert.Error(t, err)
assert.Contains(t, err.Error(), "bucket is required")
})
}
func TestScoopConfig_Defaults_Good(t *testing.T) {
t.Run("has sensible defaults", func(t *testing.T) {
p := NewScoopPublisher()
pubCfg := PublisherConfig{Type: "scoop"}
relCfg := &mockReleaseConfig{repository: "owner/repo"}
cfg := p.parseConfig(pubCfg, relCfg)
assert.Empty(t, cfg.Bucket)
assert.Nil(t, cfg.Official)
})
}
func TestScoopTemplateData_Good(t *testing.T) {
t.Run("struct has all expected fields", func(t *testing.T) {
data := scoopTemplateData{
PackageName: "myapp",
Description: "description",
Repository: "org/repo",
Version: "1.0.0",
License: "MIT",
BinaryName: "myapp",
Checksums: ChecksumMap{
WindowsAmd64: "hash1",
WindowsArm64: "hash2",
},
}
assert.Equal(t, "myapp", data.PackageName)
assert.Equal(t, "description", data.Description)
assert.Equal(t, "org/repo", data.Repository)
assert.Equal(t, "1.0.0", data.Version)
assert.Equal(t, "MIT", data.License)
assert.Equal(t, "myapp", data.BinaryName)
assert.Equal(t, "hash1", data.Checksums.WindowsAmd64)
assert.Equal(t, "hash2", data.Checksums.WindowsArm64)
})
}