* feat(go): make go fmt git-aware by default - By default, only check changed Go files (modified, staged, untracked) - Add --all flag to check all files (previous behaviour) - Reduces noise when running fmt on large codebases Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(build): minimal output by default, add missing i18n - Default output now shows single line: "Success Built N artifacts (dir)" - Add --verbose/-v flag to show full detailed output - Add all missing i18n translations for build commands - Errors still show failure reason in minimal mode Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add root-level `core git` command - Create pkg/gitcmd with git workflow commands as root menu - Export command builders from pkg/dev (AddCommitCommand, etc.) - Commands available under both `core git` and `core dev` for compatibility - Git commands: health, commit, push, pull, work, sync, apply - GitHub orchestration stays in dev: issues, reviews, ci, impact Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(qa): add docblock coverage checking Implement docblock/docstring coverage analysis for Go code: - New `core qa docblock` command to check coverage - Shows compact file:line list when under threshold - Integrate with `core go qa` as a default check - Add --docblock-threshold flag (default 80%) The checker uses Go AST parsing to find exported symbols (functions, types, consts, vars) without documentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - Fix doc comment: "status" → "health" in gitcmd package - Implement --check flag for `core go fmt` (exits non-zero if files need formatting) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: add docstrings for 100% coverage Add documentation comments to all exported symbols: - pkg/build: ProjectType constants - pkg/cli: LogLevel, RenderStyle, TableStyle - pkg/framework: ServiceFor, MustServiceFor, Core.Core - pkg/git: GitError.Error, GitError.Unwrap - pkg/i18n: Handler Match/Handle methods - pkg/log: Level constants - pkg/mcp: Tool input/output types - pkg/php: Service constants, QA types, service methods - pkg/process: ServiceError.Error - pkg/repos: RepoType constants - pkg/setup: ChangeType, ChangeCategory constants - pkg/workspace: AddWorkspaceCommands Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: standardize line endings to LF Add .gitattributes to enforce LF line endings for all text files. Normalize all existing files to use Unix-style line endings. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr - cmd_docblock.go: return error instead of os.Exit(1) for proper error handling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback (round 2) - linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit - mcp.go: guard against empty old_string in editDiff to prevent runaway edits - cmd_docblock.go: log parse errors instead of silently skipping Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
254 lines
6.1 KiB
Go
254 lines
6.1 KiB
Go
package devops
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestDefaultConfig(t *testing.T) {
|
|
cfg := DefaultConfig()
|
|
assert.Equal(t, 1, cfg.Version)
|
|
assert.Equal(t, "auto", cfg.Images.Source)
|
|
assert.Equal(t, "host-uk/core-images", cfg.Images.GitHub.Repo)
|
|
}
|
|
|
|
func TestConfigPath(t *testing.T) {
|
|
path, err := ConfigPath()
|
|
assert.NoError(t, err)
|
|
assert.Contains(t, path, ".core/config.yaml")
|
|
}
|
|
|
|
func TestLoadConfig_Good(t *testing.T) {
|
|
t.Run("returns default if not exists", func(t *testing.T) {
|
|
// Mock HOME to a temp dir
|
|
tempHome := t.TempDir()
|
|
origHome := os.Getenv("HOME")
|
|
t.Setenv("HOME", tempHome)
|
|
defer os.Setenv("HOME", origHome)
|
|
|
|
cfg, err := LoadConfig()
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, DefaultConfig(), cfg)
|
|
})
|
|
|
|
t.Run("loads existing config", func(t *testing.T) {
|
|
tempHome := t.TempDir()
|
|
t.Setenv("HOME", tempHome)
|
|
|
|
coreDir := filepath.Join(tempHome, ".core")
|
|
err := os.MkdirAll(coreDir, 0755)
|
|
require.NoError(t, err)
|
|
|
|
configData := `
|
|
version: 2
|
|
images:
|
|
source: cdn
|
|
cdn:
|
|
url: https://cdn.example.com
|
|
`
|
|
err = os.WriteFile(filepath.Join(coreDir, "config.yaml"), []byte(configData), 0644)
|
|
require.NoError(t, err)
|
|
|
|
cfg, err := LoadConfig()
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 2, cfg.Version)
|
|
assert.Equal(t, "cdn", cfg.Images.Source)
|
|
assert.Equal(t, "https://cdn.example.com", cfg.Images.CDN.URL)
|
|
})
|
|
}
|
|
|
|
func TestLoadConfig_Bad(t *testing.T) {
|
|
t.Run("invalid yaml", func(t *testing.T) {
|
|
tempHome := t.TempDir()
|
|
t.Setenv("HOME", tempHome)
|
|
|
|
coreDir := filepath.Join(tempHome, ".core")
|
|
err := os.MkdirAll(coreDir, 0755)
|
|
require.NoError(t, err)
|
|
|
|
err = os.WriteFile(filepath.Join(coreDir, "config.yaml"), []byte("invalid: yaml: :"), 0644)
|
|
require.NoError(t, err)
|
|
|
|
_, err = LoadConfig()
|
|
assert.Error(t, err)
|
|
})
|
|
}
|
|
|
|
func TestConfig_Struct(t *testing.T) {
|
|
cfg := &Config{
|
|
Version: 2,
|
|
Images: ImagesConfig{
|
|
Source: "github",
|
|
GitHub: GitHubConfig{
|
|
Repo: "owner/repo",
|
|
},
|
|
Registry: RegistryConfig{
|
|
Image: "ghcr.io/owner/image",
|
|
},
|
|
CDN: CDNConfig{
|
|
URL: "https://cdn.example.com",
|
|
},
|
|
},
|
|
}
|
|
assert.Equal(t, 2, cfg.Version)
|
|
assert.Equal(t, "github", cfg.Images.Source)
|
|
assert.Equal(t, "owner/repo", cfg.Images.GitHub.Repo)
|
|
assert.Equal(t, "ghcr.io/owner/image", cfg.Images.Registry.Image)
|
|
assert.Equal(t, "https://cdn.example.com", cfg.Images.CDN.URL)
|
|
}
|
|
|
|
func TestDefaultConfig_Complete(t *testing.T) {
|
|
cfg := DefaultConfig()
|
|
assert.Equal(t, 1, cfg.Version)
|
|
assert.Equal(t, "auto", cfg.Images.Source)
|
|
assert.Equal(t, "host-uk/core-images", cfg.Images.GitHub.Repo)
|
|
assert.Equal(t, "ghcr.io/host-uk/core-devops", cfg.Images.Registry.Image)
|
|
assert.Empty(t, cfg.Images.CDN.URL)
|
|
}
|
|
|
|
func TestLoadConfig_Good_PartialConfig(t *testing.T) {
|
|
tempHome := t.TempDir()
|
|
t.Setenv("HOME", tempHome)
|
|
|
|
coreDir := filepath.Join(tempHome, ".core")
|
|
err := os.MkdirAll(coreDir, 0755)
|
|
require.NoError(t, err)
|
|
|
|
// Config only specifies source, should merge with defaults
|
|
configData := `
|
|
version: 1
|
|
images:
|
|
source: github
|
|
`
|
|
err = os.WriteFile(filepath.Join(coreDir, "config.yaml"), []byte(configData), 0644)
|
|
require.NoError(t, err)
|
|
|
|
cfg, err := LoadConfig()
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, cfg.Version)
|
|
assert.Equal(t, "github", cfg.Images.Source)
|
|
// Default values should be preserved
|
|
assert.Equal(t, "host-uk/core-images", cfg.Images.GitHub.Repo)
|
|
}
|
|
|
|
func TestLoadConfig_Good_AllSourceTypes(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
config string
|
|
check func(*testing.T, *Config)
|
|
}{
|
|
{
|
|
name: "github source",
|
|
config: `
|
|
version: 1
|
|
images:
|
|
source: github
|
|
github:
|
|
repo: custom/repo
|
|
`,
|
|
check: func(t *testing.T, cfg *Config) {
|
|
assert.Equal(t, "github", cfg.Images.Source)
|
|
assert.Equal(t, "custom/repo", cfg.Images.GitHub.Repo)
|
|
},
|
|
},
|
|
{
|
|
name: "cdn source",
|
|
config: `
|
|
version: 1
|
|
images:
|
|
source: cdn
|
|
cdn:
|
|
url: https://custom-cdn.com
|
|
`,
|
|
check: func(t *testing.T, cfg *Config) {
|
|
assert.Equal(t, "cdn", cfg.Images.Source)
|
|
assert.Equal(t, "https://custom-cdn.com", cfg.Images.CDN.URL)
|
|
},
|
|
},
|
|
{
|
|
name: "registry source",
|
|
config: `
|
|
version: 1
|
|
images:
|
|
source: registry
|
|
registry:
|
|
image: docker.io/custom/image
|
|
`,
|
|
check: func(t *testing.T, cfg *Config) {
|
|
assert.Equal(t, "registry", cfg.Images.Source)
|
|
assert.Equal(t, "docker.io/custom/image", cfg.Images.Registry.Image)
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
tempHome := t.TempDir()
|
|
t.Setenv("HOME", tempHome)
|
|
|
|
coreDir := filepath.Join(tempHome, ".core")
|
|
err := os.MkdirAll(coreDir, 0755)
|
|
require.NoError(t, err)
|
|
|
|
err = os.WriteFile(filepath.Join(coreDir, "config.yaml"), []byte(tt.config), 0644)
|
|
require.NoError(t, err)
|
|
|
|
cfg, err := LoadConfig()
|
|
assert.NoError(t, err)
|
|
tt.check(t, cfg)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestImagesConfig_Struct(t *testing.T) {
|
|
ic := ImagesConfig{
|
|
Source: "auto",
|
|
GitHub: GitHubConfig{Repo: "test/repo"},
|
|
}
|
|
assert.Equal(t, "auto", ic.Source)
|
|
assert.Equal(t, "test/repo", ic.GitHub.Repo)
|
|
}
|
|
|
|
func TestGitHubConfig_Struct(t *testing.T) {
|
|
gc := GitHubConfig{Repo: "owner/repo"}
|
|
assert.Equal(t, "owner/repo", gc.Repo)
|
|
}
|
|
|
|
func TestRegistryConfig_Struct(t *testing.T) {
|
|
rc := RegistryConfig{Image: "ghcr.io/owner/image:latest"}
|
|
assert.Equal(t, "ghcr.io/owner/image:latest", rc.Image)
|
|
}
|
|
|
|
func TestCDNConfig_Struct(t *testing.T) {
|
|
cc := CDNConfig{URL: "https://cdn.example.com/images"}
|
|
assert.Equal(t, "https://cdn.example.com/images", cc.URL)
|
|
}
|
|
|
|
func TestLoadConfig_Bad_UnreadableFile(t *testing.T) {
|
|
// This test is platform-specific and may not work on all systems
|
|
// Skip if we can't test file permissions properly
|
|
if os.Getuid() == 0 {
|
|
t.Skip("Skipping permission test when running as root")
|
|
}
|
|
|
|
tempHome := t.TempDir()
|
|
t.Setenv("HOME", tempHome)
|
|
|
|
coreDir := filepath.Join(tempHome, ".core")
|
|
err := os.MkdirAll(coreDir, 0755)
|
|
require.NoError(t, err)
|
|
|
|
configPath := filepath.Join(coreDir, "config.yaml")
|
|
err = os.WriteFile(configPath, []byte("version: 1"), 0000)
|
|
require.NoError(t, err)
|
|
|
|
_, err = LoadConfig()
|
|
assert.Error(t, err)
|
|
|
|
// Restore permissions so cleanup works
|
|
os.Chmod(configPath, 0644)
|
|
}
|