* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
78 lines
2 KiB
Go
78 lines
2 KiB
Go
package sdk
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
)
|
|
|
|
// commonSpecPaths are checked in order when no spec is configured.
|
|
var commonSpecPaths = []string{
|
|
"api/openapi.yaml",
|
|
"api/openapi.json",
|
|
"openapi.yaml",
|
|
"openapi.json",
|
|
"docs/api.yaml",
|
|
"docs/api.json",
|
|
"swagger.yaml",
|
|
"swagger.json",
|
|
}
|
|
|
|
// DetectSpec finds the OpenAPI spec file.
|
|
// Priority: config path -> common paths -> Laravel Scramble.
|
|
func (s *SDK) DetectSpec() (string, error) {
|
|
// 1. Check configured path
|
|
if s.config.Spec != "" {
|
|
specPath := filepath.Join(s.projectDir, s.config.Spec)
|
|
if _, err := os.Stat(specPath); err == nil {
|
|
return specPath, nil
|
|
}
|
|
return "", fmt.Errorf("sdk.DetectSpec: configured spec not found: %s", s.config.Spec)
|
|
}
|
|
|
|
// 2. Check common paths
|
|
for _, p := range commonSpecPaths {
|
|
specPath := filepath.Join(s.projectDir, p)
|
|
if _, err := os.Stat(specPath); err == nil {
|
|
return specPath, nil
|
|
}
|
|
}
|
|
|
|
// 3. Try Laravel Scramble detection
|
|
specPath, err := s.detectScramble()
|
|
if err == nil {
|
|
return specPath, nil
|
|
}
|
|
|
|
return "", fmt.Errorf("sdk.DetectSpec: no OpenAPI spec found (checked config, common paths, Scramble)")
|
|
}
|
|
|
|
// detectScramble checks for Laravel Scramble and exports the spec.
|
|
func (s *SDK) detectScramble() (string, error) {
|
|
composerPath := filepath.Join(s.projectDir, "composer.json")
|
|
if _, err := os.Stat(composerPath); err != nil {
|
|
return "", fmt.Errorf("no composer.json")
|
|
}
|
|
|
|
// Check for scramble in composer.json
|
|
data, err := os.ReadFile(composerPath)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
// Simple check for scramble package
|
|
if !containsScramble(data) {
|
|
return "", fmt.Errorf("scramble not found in composer.json")
|
|
}
|
|
|
|
// TODO: Run php artisan scramble:export
|
|
return "", fmt.Errorf("scramble export not implemented")
|
|
}
|
|
|
|
// containsScramble checks if composer.json includes scramble.
|
|
func containsScramble(data []byte) bool {
|
|
content := string(data)
|
|
return strings.Contains(content, "dedoc/scramble") ||
|
|
strings.Contains(content, "\"scramble\"")
|
|
}
|