f47e8211fb
* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
87 lines
2.2 KiB
Go
87 lines
2.2 KiB
Go
package sdk
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestDetectSpec_Good_ConfigPath(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
specPath := filepath.Join(tmpDir, "api", "spec.yaml")
|
|
err := os.MkdirAll(filepath.Dir(specPath), 0755)
|
|
require.NoError(t, err)
|
|
err = os.WriteFile(specPath, []byte("openapi: 3.0.0"), 0644)
|
|
require.NoError(t, err)
|
|
|
|
sdk := New(tmpDir, &Config{Spec: "api/spec.yaml"})
|
|
got, err := sdk.DetectSpec()
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, specPath, got)
|
|
}
|
|
|
|
func TestDetectSpec_Good_CommonPath(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
specPath := filepath.Join(tmpDir, "openapi.yaml")
|
|
err := os.WriteFile(specPath, []byte("openapi: 3.0.0"), 0644)
|
|
require.NoError(t, err)
|
|
|
|
sdk := New(tmpDir, nil)
|
|
got, err := sdk.DetectSpec()
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, specPath, got)
|
|
}
|
|
|
|
func TestDetectSpec_Bad_NotFound(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
sdk := New(tmpDir, nil)
|
|
_, err := sdk.DetectSpec()
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "no OpenAPI spec found")
|
|
}
|
|
|
|
func TestDetectSpec_Bad_ConfigNotFound(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
sdk := New(tmpDir, &Config{Spec: "non-existent.yaml"})
|
|
_, err := sdk.DetectSpec()
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "configured spec not found")
|
|
}
|
|
|
|
func TestContainsScramble(t *testing.T) {
|
|
tests := []struct {
|
|
data string
|
|
expected bool
|
|
}{
|
|
{`{"require": {"dedoc/scramble": "^0.1"}}`, true},
|
|
{`{"require": {"scramble": "^0.1"}}`, true},
|
|
{`{"require": {"laravel/framework": "^11.0"}}`, false},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
assert.Equal(t, tt.expected, containsScramble([]byte(tt.data)))
|
|
}
|
|
}
|
|
|
|
func TestDetectScramble_Bad(t *testing.T) {
|
|
t.Run("no composer.json", func(t *testing.T) {
|
|
sdk := New(t.TempDir(), nil)
|
|
_, err := sdk.detectScramble()
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "no composer.json")
|
|
})
|
|
|
|
t.Run("no scramble in composer.json", func(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
err := os.WriteFile(filepath.Join(tmpDir, "composer.json"), []byte(`{}`), 0644)
|
|
require.NoError(t, err)
|
|
|
|
sdk := New(tmpDir, nil)
|
|
_, err = sdk.detectScramble()
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "scramble not found")
|
|
})
|
|
}
|