f47e8211fb
* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
101 lines
1.9 KiB
Go
101 lines
1.9 KiB
Go
package sdk
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestDiff_Good_NoBreaking(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
|
|
baseSpec := `openapi: "3.0.0"
|
|
info:
|
|
title: Test API
|
|
version: "1.0.0"
|
|
paths:
|
|
/health:
|
|
get:
|
|
operationId: getHealth
|
|
responses:
|
|
"200":
|
|
description: OK
|
|
`
|
|
revSpec := `openapi: "3.0.0"
|
|
info:
|
|
title: Test API
|
|
version: "1.1.0"
|
|
paths:
|
|
/health:
|
|
get:
|
|
operationId: getHealth
|
|
responses:
|
|
"200":
|
|
description: OK
|
|
/status:
|
|
get:
|
|
operationId: getStatus
|
|
responses:
|
|
"200":
|
|
description: OK
|
|
`
|
|
basePath := filepath.Join(tmpDir, "base.yaml")
|
|
revPath := filepath.Join(tmpDir, "rev.yaml")
|
|
os.WriteFile(basePath, []byte(baseSpec), 0644)
|
|
os.WriteFile(revPath, []byte(revSpec), 0644)
|
|
|
|
result, err := Diff(basePath, revPath)
|
|
if err != nil {
|
|
t.Fatalf("Diff failed: %v", err)
|
|
}
|
|
if result.Breaking {
|
|
t.Error("expected no breaking changes for adding endpoint")
|
|
}
|
|
}
|
|
|
|
func TestDiff_Good_Breaking(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
|
|
baseSpec := `openapi: "3.0.0"
|
|
info:
|
|
title: Test API
|
|
version: "1.0.0"
|
|
paths:
|
|
/health:
|
|
get:
|
|
operationId: getHealth
|
|
responses:
|
|
"200":
|
|
description: OK
|
|
/users:
|
|
get:
|
|
operationId: getUsers
|
|
responses:
|
|
"200":
|
|
description: OK
|
|
`
|
|
revSpec := `openapi: "3.0.0"
|
|
info:
|
|
title: Test API
|
|
version: "2.0.0"
|
|
paths:
|
|
/health:
|
|
get:
|
|
operationId: getHealth
|
|
responses:
|
|
"200":
|
|
description: OK
|
|
`
|
|
basePath := filepath.Join(tmpDir, "base.yaml")
|
|
revPath := filepath.Join(tmpDir, "rev.yaml")
|
|
os.WriteFile(basePath, []byte(baseSpec), 0644)
|
|
os.WriteFile(revPath, []byte(revSpec), 0644)
|
|
|
|
result, err := Diff(basePath, revPath)
|
|
if err != nil {
|
|
t.Fatalf("Diff failed: %v", err)
|
|
}
|
|
if !result.Breaking {
|
|
t.Error("expected breaking change for removed endpoint")
|
|
}
|
|
}
|