* feat(mcp): add workspace root validation to prevent path traversal - Add workspaceRoot field to Service for restricting file operations - Add WithWorkspaceRoot() option for configuring the workspace directory - Add validatePath() helper to check paths are within workspace - Apply validation to all file operation handlers - Default to current working directory for security - Add comprehensive tests for path validation Closes #82 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: move CLI commands from pkg/ to internal/cmd/ - Move 18 CLI command packages to internal/cmd/ (not externally importable) - Keep 16 library packages in pkg/ (externally importable) - Update all import paths throughout codebase - Cleaner separation between CLI logic and reusable libraries CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor, php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace Libraries remaining: agentic, build, cache, cli, container, devops, errors, framework, git, i18n, io, log, mcp, process, release, repos Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(mcp): use pkg/io Medium for sandboxed file operations Replace manual path validation with pkg/io.Medium for all file operations. This delegates security (path traversal, symlink bypass) to the sandboxed local.Medium implementation. Changes: - Add io.NewSandboxed() for creating sandboxed Medium instances - Refactor MCP Service to use io.Medium instead of direct os.* calls - Remove validatePath and resolvePathWithSymlinks functions - Update tests to verify Medium-based behaviour Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: correct import path and workflow references - Fix pkg/io/io.go import from core-gui to core - Update CI workflows to use internal/cmd/updater path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(security): address CodeRabbit review issues for path validation - pkg/io/local: add symlink resolution and boundary-aware containment - Reject absolute paths in sandboxed Medium - Use filepath.EvalSymlinks to prevent symlink bypass attacks - Fix prefix check to prevent /tmp/root matching /tmp/root2 - pkg/mcp: fix resolvePath to validate and return errors - Changed resolvePath from (string) to (string, error) - Update deleteFile, renameFile, listDirectory, fileExists to handle errors - Changed New() to return (*Service, error) instead of *Service - Properly propagate option errors instead of silently discarding - pkg/io: wrap errors with E() helper for consistent context - Copy() and MockMedium.Read() now use coreerr.E() - tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines - Fix hardcoded /tmp in TestPath to use t.TempDir() - Add TestResolvePath_Bad_SymlinkTraversal test Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix gofmt formatting across all files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
86 lines
2.3 KiB
Go
86 lines
2.3 KiB
Go
package dev
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/host-uk/core/pkg/agentic"
|
|
"github.com/host-uk/core/pkg/framework"
|
|
"github.com/host-uk/core/pkg/git"
|
|
)
|
|
|
|
// WorkBundle contains the Core instance for dev work operations.
|
|
type WorkBundle struct {
|
|
Core *framework.Core
|
|
}
|
|
|
|
// WorkBundleOptions configures the work bundle.
|
|
type WorkBundleOptions struct {
|
|
RegistryPath string
|
|
AllowEdit bool // Allow agentic to use Write/Edit tools
|
|
}
|
|
|
|
// NewWorkBundle creates a bundle for dev work operations.
|
|
// Includes: dev (orchestration), git, agentic services.
|
|
func NewWorkBundle(opts WorkBundleOptions) (*WorkBundle, error) {
|
|
c, err := framework.New(
|
|
framework.WithService(NewService(ServiceOptions{
|
|
RegistryPath: opts.RegistryPath,
|
|
})),
|
|
framework.WithService(git.NewService(git.ServiceOptions{})),
|
|
framework.WithService(agentic.NewService(agentic.ServiceOptions{
|
|
AllowEdit: opts.AllowEdit,
|
|
})),
|
|
framework.WithServiceLock(),
|
|
)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &WorkBundle{Core: c}, nil
|
|
}
|
|
|
|
// Start initialises the bundle services.
|
|
func (b *WorkBundle) Start(ctx context.Context) error {
|
|
return b.Core.ServiceStartup(ctx, nil)
|
|
}
|
|
|
|
// Stop shuts down the bundle services.
|
|
func (b *WorkBundle) Stop(ctx context.Context) error {
|
|
return b.Core.ServiceShutdown(ctx)
|
|
}
|
|
|
|
// StatusBundle contains the Core instance for status-only operations.
|
|
type StatusBundle struct {
|
|
Core *framework.Core
|
|
}
|
|
|
|
// StatusBundleOptions configures the status bundle.
|
|
type StatusBundleOptions struct {
|
|
RegistryPath string
|
|
}
|
|
|
|
// NewStatusBundle creates a bundle for status-only operations.
|
|
// Includes: dev (orchestration), git services. No agentic - commits not available.
|
|
func NewStatusBundle(opts StatusBundleOptions) (*StatusBundle, error) {
|
|
c, err := framework.New(
|
|
framework.WithService(NewService(ServiceOptions(opts))),
|
|
framework.WithService(git.NewService(git.ServiceOptions{})),
|
|
// No agentic service - TaskCommit will be unhandled
|
|
framework.WithServiceLock(),
|
|
)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &StatusBundle{Core: c}, nil
|
|
}
|
|
|
|
// Start initialises the bundle services.
|
|
func (b *StatusBundle) Start(ctx context.Context) error {
|
|
return b.Core.ServiceStartup(ctx, nil)
|
|
}
|
|
|
|
// Stop shuts down the bundle services.
|
|
func (b *StatusBundle) Stop(ctx context.Context) error {
|
|
return b.Core.ServiceShutdown(ctx)
|
|
}
|